From: Brendan Jackman <jackmanb@google.com>
To: Peter Zijlstra <peterz@infradead.org>,
Brendan Jackman <jackmanb@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
<linux-kernel@vger.kernel.org>, <kees@kernel.org>,
<acarmina@redhat.com>, <jpoimboe@kernel.org>,
<mark.rutland@arm.com>, <maciej.wieczor-retman@intel.com>
Subject: Re: [PATCH] bug: hush suggest-attribute=format for __warn_printf()
Date: Mon, 08 Dec 2025 08:50:17 +0000 [thread overview]
Message-ID: <DESPFV5ANWM5.QON75G6PESZ5@google.com> (raw)
In-Reply-To: <20251208083857.GA3707837@noisy.programming.kicks-ass.net>
On Mon Dec 8, 2025 at 8:38 AM UTC, Peter Zijlstra wrote:
> On Sun, Dec 07, 2025 at 03:53:18AM +0000, Brendan Jackman wrote:
>> Recent additions to this function cause GCC 14.3.0 to get excited and
>> suggest a missing attribute:
>>
>> lib/bug.c: In function ‘__warn_printf’:
>> lib/bug.c:187:25: error: function ‘__warn_printf’ might be a candidate for ‘gnu_printf’ format attribute [-Werror=suggest-attribute=format]
>> 187 | vprintk(fmt, *args);
>> | ^~~~~~~
>>
>> Disable the diagnostic locally, following the pattern used for stuff
>> like va_format().
>
> No real objection, but why haven't I seen this in my own builds? Most of
> my machines are on gcc-14 / gcc-15.
Ah, yeah, apparently it only shows up with W=1.
next prev parent reply other threads:[~2025-12-08 8:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-07 3:53 [PATCH] bug: hush suggest-attribute=format for __warn_printf() Brendan Jackman
2025-12-08 8:38 ` Peter Zijlstra
2025-12-08 8:50 ` Brendan Jackman [this message]
2025-12-08 8:58 ` Peter Zijlstra
2025-12-09 9:16 ` [tip: core/urgent] bug: Hush " tip-bot2 for Brendan Jackman
2025-12-12 9:10 ` tip-bot2 for Brendan Jackman
2025-12-12 9:29 ` tip-bot2 for Brendan Jackman
2025-12-16 4:24 ` [PATCH] bug: hush " Andrew Morton
2025-12-16 8:49 ` Peter Zijlstra
2025-12-16 9:16 ` Brendan Jackman
2025-12-16 12:36 ` David Laight
2025-12-16 12:43 ` Brendan Jackman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DESPFV5ANWM5.QON75G6PESZ5@google.com \
--to=jackmanb@google.com \
--cc=acarmina@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=jpoimboe@kernel.org \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.wieczor-retman@intel.com \
--cc=mark.rutland@arm.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox