* [PATCH v1 1/1] drm/nouveau/gsp: simplify code with acpi_get_local_u64_address()
@ 2026-01-20 15:20 Andy Shevchenko
2026-02-08 14:03 ` Andy Shevchenko
2026-02-08 14:39 ` Danilo Krummrich
0 siblings, 2 replies; 3+ messages in thread
From: Andy Shevchenko @ 2026-01-20 15:20 UTC (permalink / raw)
To: Dave Airlie, dri-devel, nouveau, linux-kernel
Cc: Lyude Paul, Danilo Krummrich, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Andy Shevchenko
Now we have a helper so there's no need to open-code.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r535/gsp.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r535/gsp.c b/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r535/gsp.c
index 2a7e80c6d70f..c675324693af 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r535/gsp.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r535/gsp.c
@@ -796,7 +796,8 @@ r535_gsp_acpi_mux_id(acpi_handle handle, u32 id, MUX_METHOD_DATA_ELEMENT *mode,
struct acpi_object_list input = { 1, &mux_arg };
acpi_handle iter = NULL, handle_mux = NULL;
acpi_status status;
- unsigned long long value;
+ u64 value;
+ int ret;
mode->status = 0xffff;
part->status = 0xffff;
@@ -806,8 +807,8 @@ r535_gsp_acpi_mux_id(acpi_handle handle, u32 id, MUX_METHOD_DATA_ELEMENT *mode,
if (ACPI_FAILURE(status) || !iter)
return;
- status = acpi_evaluate_integer(iter, "_ADR", NULL, &value);
- if (ACPI_FAILURE(status) || value != id)
+ ret = acpi_get_local_u64_address(iter, &value);
+ if (ret || value != id)
continue;
handle_mux = iter;
--
2.50.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] drm/nouveau/gsp: simplify code with acpi_get_local_u64_address()
2026-01-20 15:20 [PATCH v1 1/1] drm/nouveau/gsp: simplify code with acpi_get_local_u64_address() Andy Shevchenko
@ 2026-02-08 14:03 ` Andy Shevchenko
2026-02-08 14:39 ` Danilo Krummrich
1 sibling, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2026-02-08 14:03 UTC (permalink / raw)
To: Dave Airlie, dri-devel, nouveau, linux-kernel
Cc: Lyude Paul, Danilo Krummrich, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter
On Tue, Jan 20, 2026 at 04:20:49PM +0100, Andy Shevchenko wrote:
> Now we have a helper so there's no need to open-code.
Anybody to comment on this?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] drm/nouveau/gsp: simplify code with acpi_get_local_u64_address()
2026-01-20 15:20 [PATCH v1 1/1] drm/nouveau/gsp: simplify code with acpi_get_local_u64_address() Andy Shevchenko
2026-02-08 14:03 ` Andy Shevchenko
@ 2026-02-08 14:39 ` Danilo Krummrich
1 sibling, 0 replies; 3+ messages in thread
From: Danilo Krummrich @ 2026-02-08 14:39 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Dave Airlie, dri-devel, nouveau, linux-kernel, Lyude Paul,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter
On Tue Jan 20, 2026 at 4:20 PM CET, Andy Shevchenko wrote:
> Now we have a helper so there's no need to open-code.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Applied to drm-misc-next, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-02-08 14:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-20 15:20 [PATCH v1 1/1] drm/nouveau/gsp: simplify code with acpi_get_local_u64_address() Andy Shevchenko
2026-02-08 14:03 ` Andy Shevchenko
2026-02-08 14:39 ` Danilo Krummrich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox