[PATCH] mtd: spi-nor: macronix: Document support for additional flash aliases

[PATCH] mtd: spi-nor: macronix: Document support for additional flash aliases

[Cheng Ming Lin]

From: Cheng Ming Lin <chengminglin@mxic.com.tw>

Several Macronix SPI NOR flash devices share the same ID.
For instance, the MX25L51245G and MX25L51273G share the same ID
(0xc2201a) with the currently listed MX66L51235F.

Add these equivalent part numbers to the comments above their
corresponding flash_info entries.

While this change does not affect the functional driver logic, it
significantly improves the searchability of the kernel source tree.
This helps users easily verify that their specific physical part is
fully supported, preventing confusion and deterring redundant patch
submissions that attempt to add duplicate entries for these alias parts.

Signed-off-by: Cheng Ming Lin <chengminglin@mxic.com.tw>
---
 drivers/mtd/spi-nor/macronix.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/mtd/spi-nor/macronix.c b/drivers/mtd/spi-nor/macronix.c
index e97f5cbd9..c557525b0 100644
--- a/drivers/mtd/spi-nor/macronix.c
+++ b/drivers/mtd/spi-nor/macronix.c
@@ -138,7 +138,7 @@ static const struct flash_info macronix_nor_parts[] = {
 		.id = SNOR_ID(0xc2, 0x20, 0x19),
 		.fixups = &mx25l25635_fixups
 	}, {
-		/* MX66L51235F */
+		/* MX25L51245G, MX25L51273G, MX66L51235F */
 		.id = SNOR_ID(0xc2, 0x20, 0x1a),
 		.fixup_flags = SPI_NOR_4B_OPCODES,
 		.fixups = &macronix_qpp4b_fixups,
@@ -186,11 +186,11 @@ static const struct flash_info macronix_nor_parts[] = {
 		.size = SZ_16M,
 		.no_sfdp_flags = SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ,
 	}, {
-		/* MX25U51245G */
+		/* MX25U51245G, MX25U51293G */
 		.id = SNOR_ID(0xc2, 0x25, 0x3a),
 		.fixups = &macronix_qpp4b_fixups,
 	}, {
-		/* MX66U1G45G */
+		/* MX66U1G45G, MX66U1G93G */
 		.id = SNOR_ID(0xc2, 0x25, 0x3b),
 		.fixups = &macronix_qpp4b_fixups,
 	}, {
-- 
2.25.1

Re: [PATCH] mtd: spi-nor: macronix: Document support for additional flash aliases

[Michael Walle]

[-- Attachment #1: Type: text/plain, Size: 1010 bytes --]

On Fri Apr 10, 2026 at 11:10 AM CEST, Cheng Ming Lin wrote:
> From: Cheng Ming Lin <chengminglin@mxic.com.tw>
>
> Several Macronix SPI NOR flash devices share the same ID.
> For instance, the MX25L51245G and MX25L51273G share the same ID
> (0xc2201a) with the currently listed MX66L51235F.
>
> Add these equivalent part numbers to the comments above their
> corresponding flash_info entries.
>
> While this change does not affect the functional driver logic, it
> significantly improves the searchability of the kernel source tree.
> This helps users easily verify that their specific physical part is
> fully supported, preventing confusion and deterring redundant patch
> submissions that attempt to add duplicate entries for these alias parts.
>
> Signed-off-by: Cheng Ming Lin <chengminglin@mxic.com.tw>

Hi Cheng,

could you please provide an SFDP dump of all these chips? See [1]
for more information.

Thanks,
-michael

[1] https://docs.kernel.org/driver-api/mtd/spi-nor.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 297 bytes --]

Re: [PATCH] mtd: spi-nor: macronix: Document support for additional flash aliases

[Cheng Ming Lin]

Hi Michael,

Michael Walle <mwalle@kernel.org> 於 2026年4月10日週五 下午5:26寫道：
>
> On Fri Apr 10, 2026 at 11:10 AM CEST, Cheng Ming Lin wrote:
> > From: Cheng Ming Lin <chengminglin@mxic.com.tw>
> >
> > Several Macronix SPI NOR flash devices share the same ID.
> > For instance, the MX25L51245G and MX25L51273G share the same ID
> > (0xc2201a) with the currently listed MX66L51235F.
> >
> > Add these equivalent part numbers to the comments above their
> > corresponding flash_info entries.
> >
> > While this change does not affect the functional driver logic, it
> > significantly improves the searchability of the kernel source tree.
> > This helps users easily verify that their specific physical part is
> > fully supported, preventing confusion and deterring redundant patch
> > submissions that attempt to add duplicate entries for these alias parts.
> >
> > Signed-off-by: Cheng Ming Lin <chengminglin@mxic.com.tw>
>
> Hi Cheng,
>
> could you please provide an SFDP dump of all these chips? See [1]
> for more information.

Sure. I will reply with the SFDP data as soon as I have them ready.

>
> Thanks,
> -michael
>
> [1] https://docs.kernel.org/driver-api/mtd/spi-nor.html

Thanks,
Cheng Ming Lin

Re: [PATCH] mtd: spi-nor: macronix: Document support for additional flash aliases

[Cheng Ming Lin]

Hi Michael,

Michael Walle <mwalle@kernel.org> 於 2026年4月10日週五 下午5:26寫道：
>
> On Fri Apr 10, 2026 at 11:10 AM CEST, Cheng Ming Lin wrote:
> > From: Cheng Ming Lin <chengminglin@mxic.com.tw>
> >
> > Several Macronix SPI NOR flash devices share the same ID.
> > For instance, the MX25L51245G and MX25L51273G share the same ID
> > (0xc2201a) with the currently listed MX66L51235F.
> >
> > Add these equivalent part numbers to the comments above their
> > corresponding flash_info entries.
> >
> > While this change does not affect the functional driver logic, it
> > significantly improves the searchability of the kernel source tree.
> > This helps users easily verify that their specific physical part is
> > fully supported, preventing confusion and deterring redundant patch
> > submissions that attempt to add duplicate entries for these alias parts.
> >
> > Signed-off-by: Cheng Ming Lin <chengminglin@mxic.com.tw>
>
> Hi Cheng,
>
> could you please provide an SFDP dump of all these chips? See [1]
> for more information.

1. MX25L51245G
zynq> cat /sys/kernel/debug/spi-nor/spi2.0/params
name            (null)
id              c2 20 1a c2 20 1a
size            64.0 MiB
write size      1
page size       256
address nbytes  4
flags           4B_OPCODES | HAS_4BAIT | SOFT_RESET

zynq> xxd -p /sys/bus/spi/devices/spi2.0/spi-nor/sfdp
53464450060102ff00060110300000ffc2000104100100ff84000102c000
00ffffffffffffffffffffffffffffffffffe520fbffffffff1f44eb086b
083b04bbfeffffffffff00ffffff44eb0c200f5210d800ffd649c50081df
04e34403673830b030b0f7bdd55c4a9e29fff050f985ffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffff7fefffff215cdcffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffff003600279df9c06485cbffffffffffff

zynq> sha256sum /sys/bus/spi/devices/spi2.0/spi-nor/sfdp
7281b0a355a4497ec6256c57b81c3d2b303bc34220cb77790278d719d7465276
/sys/bus/spi/devices/spi2.0/spi-nor/sfdp

2. MX25L51273G
zynq> cat /sys/kernel/debug/spi-nor/spi2.0/params
name            (null)
id              c2 20 1a c2 20 1a
size            64.0 MiB
write size      1
page size       256
address nbytes  4
flags           4B_OPCODES | HAS_4BAIT | SOFT_RESET

zynq> xxd -p /sys/bus/spi/devices/spi2.0/spi-nor/sfdp
53464450060102ff00060110300000ffc2000104100100ff84000102c000
00ffffffffffffffffffffffffffffffffffe520fbffffffff1f44eb086b
083b04bbfeffffffffff00ffffff44eb0c200f5210d800ffd649c50081df
04e34403673830b030b0f7bdd55c4a9e29fff050f985ffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffff7fefffff215cdcffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffff003600279df9c06485cbffffffffffff

zynq> sha256sum /sys/bus/spi/devices/spi2.0/spi-nor/sfdp
7281b0a355a4497ec6256c57b81c3d2b303bc34220cb77790278d719d7465276
/sys/bus/spi/devices/spi2.0/spi-nor/sfdp

3. MX25U51293G
zynq> cat /sys/kernel/debug/spi-nor/spi2.0/params
name            (null)
id              c2 25 3a c2 25 3a
size            64.0 MiB
write size      1
page size       256
address nbytes  4
flags           4B_OPCODES | HAS_4BAIT | SOFT_RESET

zynq> xxd -p /sys/bus/spi/devices/spi2.0/spi-nor/sfdp
53464450060102ff00060110300000ffc2000104100100ff84000102c000
00ffffffffffffffffffffffffffffffffffe520fbffffffff1f44eb086b
083b04bbfeffffffffff00ffffff44eb0c200f5210d800ff8749b50082df
04e24403673830b030b0f7bdd55c4a9e29fff050f985ffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffff7f8fffff215cdcffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffff002050169df9c06485cbffffffffffff

zynq> sha256sum /sys/bus/spi/devices/spi2.0/spi-nor/sfdp
faa50d0c2c8f26dbdfb400c995bd19a4a492404336588a72c596088c5641164f
/sys/bus/spi/devices/spi2.0/spi-nor/sfdp

4. MX66U1G93G
zynq> cat /sys/kernel/debug/spi-nor/spi2.0/params
name            (null)
id              c2 25 3b c2 25 3b
size            128 MiB
write size      1
page size       256
address nbytes  4
flags           4B_OPCODES | HAS_4BAIT | SOFT_RESET

zynq> xxd -p /sys/bus/spi/devices/spi2.0/spi-nor/sfdp
53464450060102ff00060110300000ffc2000104100100ff84000102c000
00ffffffffffffffffffffffffffffffffffe520fbffffffff3f44eb086b
083b04bbfeffffffffff00ffffff44eb0c200f5210d800ff8749b50082df
04e24403673830b030b0f7bdd55c4a9e29fff050f985ffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffff7f8fffff215cdcffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffff002050169df9c06485cbffffffffffff

zynq> sha256sum /sys/bus/spi/devices/spi2.0/spi-nor/sfdp
f693537f8b6660a8ed937dab65eff3821f58e03c026a64b153ddccbfd9a6df0c
/sys/bus/spi/devices/spi2.0/spi-nor/sfdp

>
> Thanks,
> -michael
>
> [1] https://docs.kernel.org/driver-api/mtd/spi-nor.html

Thanks,
Cheng Ming Lin

Re: [PATCH] mtd: spi-nor: macronix: Document support for additional flash aliases

[Michael Walle]

[-- Attachment #1: Type: text/plain, Size: 767 bytes --]

Hi

thanks for providing the dumps.

> 1. MX25L51245G
..
> zynq> sha256sum /sys/bus/spi/devices/spi2.0/spi-nor/sfdp
> 7281b0a355a4497ec6256c57b81c3d2b303bc34220cb77790278d719d7465276
> /sys/bus/spi/devices/spi2.0/spi-nor/sfdp
>
> 2. MX25L51273G
..
> zynq> sha256sum /sys/bus/spi/devices/spi2.0/spi-nor/sfdp
> 7281b0a355a4497ec6256c57b81c3d2b303bc34220cb77790278d719d7465276
> /sys/bus/spi/devices/spi2.0/spi-nor/sfdp

Different parts, same ID, same SFDP :(( Are they the same from a
software perspective? With Macronix reusing the same ID for
different flash chips it makes software support for different
features really hard.  And with even with the SFDP being the very
same, it's impossible to distinguish them during auto probing.

-michael

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 297 bytes --]

Re: [PATCH] mtd: spi-nor: macronix: Document support for additional flash aliases

[Michael Walle]

[-- Attachment #1: Type: text/plain, Size: 2477 bytes --]

Hi Cheng,

On Fri Apr 10, 2026 at 11:10 AM CEST, Cheng Ming Lin wrote:
> From: Cheng Ming Lin <chengminglin@mxic.com.tw>
>
> Several Macronix SPI NOR flash devices share the same ID.
> For instance, the MX25L51245G and MX25L51273G share the same ID
> (0xc2201a) with the currently listed MX66L51235F.
>
> Add these equivalent part numbers to the comments above their
> corresponding flash_info entries.
>
> While this change does not affect the functional driver logic, it
> significantly improves the searchability of the kernel source tree.
> This helps users easily verify that their specific physical part is
> fully supported, preventing confusion and deterring redundant patch
> submissions that attempt to add duplicate entries for these alias parts.

Honestly, this sounds a bit hyperbolic. Macronix is notoriously bad
with reusing flash ids where you actually have to be able to tell
them apart from each other in software.

So, if you really have to reuse your flash ids, how about having an
unique id in the SFDP tables, like in a manufacturer specific table?
That would really help us. Could you please discuss that with your
product management?

Anyway,

Reviewed-by: Michael Walle <mwalle@kernel.org>

Thanks,
-michael

>
> Signed-off-by: Cheng Ming Lin <chengminglin@mxic.com.tw>
> ---
>  drivers/mtd/spi-nor/macronix.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mtd/spi-nor/macronix.c b/drivers/mtd/spi-nor/macronix.c
> index e97f5cbd9..c557525b0 100644
> --- a/drivers/mtd/spi-nor/macronix.c
> +++ b/drivers/mtd/spi-nor/macronix.c
> @@ -138,7 +138,7 @@ static const struct flash_info macronix_nor_parts[] = {
>  		.id = SNOR_ID(0xc2, 0x20, 0x19),
>  		.fixups = &mx25l25635_fixups
>  	}, {
> -		/* MX66L51235F */
> +		/* MX25L51245G, MX25L51273G, MX66L51235F */
>  		.id = SNOR_ID(0xc2, 0x20, 0x1a),
>  		.fixup_flags = SPI_NOR_4B_OPCODES,
>  		.fixups = &macronix_qpp4b_fixups,
> @@ -186,11 +186,11 @@ static const struct flash_info macronix_nor_parts[] = {
>  		.size = SZ_16M,
>  		.no_sfdp_flags = SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ,
>  	}, {
> -		/* MX25U51245G */
> +		/* MX25U51245G, MX25U51293G */
>  		.id = SNOR_ID(0xc2, 0x25, 0x3a),
>  		.fixups = &macronix_qpp4b_fixups,
>  	}, {
> -		/* MX66U1G45G */
> +		/* MX66U1G45G, MX66U1G93G */
>  		.id = SNOR_ID(0xc2, 0x25, 0x3b),
>  		.fixups = &macronix_qpp4b_fixups,
>  	}, {


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 297 bytes --]

Re: [PATCH] mtd: spi-nor: macronix: Document support for additional flash aliases

[Cheng Ming Lin]

Hi Michael,

Michael Walle <mwalle@kernel.org> 於 2026年4月15日週三 下午7:01寫道：
>
> Hi Cheng,
>
> On Fri Apr 10, 2026 at 11:10 AM CEST, Cheng Ming Lin wrote:
> > From: Cheng Ming Lin <chengminglin@mxic.com.tw>
> >
> > Several Macronix SPI NOR flash devices share the same ID.
> > For instance, the MX25L51245G and MX25L51273G share the same ID
> > (0xc2201a) with the currently listed MX66L51235F.
> >
> > Add these equivalent part numbers to the comments above their
> > corresponding flash_info entries.
> >
> > While this change does not affect the functional driver logic, it
> > significantly improves the searchability of the kernel source tree.
> > This helps users easily verify that their specific physical part is
> > fully supported, preventing confusion and deterring redundant patch
> > submissions that attempt to add duplicate entries for these alias parts.
>
> Honestly, this sounds a bit hyperbolic. Macronix is notoriously bad
> with reusing flash ids where you actually have to be able to tell
> them apart from each other in software.
>
> So, if you really have to reuse your flash ids, how about having an
> unique id in the SFDP tables, like in a manufacturer specific table?
> That would really help us. Could you please discuss that with your
> product management?
>
> Anyway,
>
> Reviewed-by: Michael Walle <mwalle@kernel.org>

Fair point. I agree that simply adding comments in the code is just a
documentation improvement and doesn't solve the actual software burden
caused by shared JEDEC IDs.

Your suggestion to embed a unique ID in the manufacturer-specific SFDP
tables to programmatically distinguish these different part numbers is
a much better solution. I will definitely take this specific request back
to our product management to see how we can implement this in future
product planning.

Thanks for the R-b and the feedback.

>
> Thanks,
> -michael
>
> >
> > Signed-off-by: Cheng Ming Lin <chengminglin@mxic.com.tw>
> > ---
> >  drivers/mtd/spi-nor/macronix.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/mtd/spi-nor/macronix.c b/drivers/mtd/spi-nor/macronix.c
> > index e97f5cbd9..c557525b0 100644
> > --- a/drivers/mtd/spi-nor/macronix.c
> > +++ b/drivers/mtd/spi-nor/macronix.c
> > @@ -138,7 +138,7 @@ static const struct flash_info macronix_nor_parts[] = {
> >               .id = SNOR_ID(0xc2, 0x20, 0x19),
> >               .fixups = &mx25l25635_fixups
> >       }, {
> > -             /* MX66L51235F */
> > +             /* MX25L51245G, MX25L51273G, MX66L51235F */
> >               .id = SNOR_ID(0xc2, 0x20, 0x1a),
> >               .fixup_flags = SPI_NOR_4B_OPCODES,
> >               .fixups = &macronix_qpp4b_fixups,
> > @@ -186,11 +186,11 @@ static const struct flash_info macronix_nor_parts[] = {
> >               .size = SZ_16M,
> >               .no_sfdp_flags = SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ,
> >       }, {
> > -             /* MX25U51245G */
> > +             /* MX25U51245G, MX25U51293G */
> >               .id = SNOR_ID(0xc2, 0x25, 0x3a),
> >               .fixups = &macronix_qpp4b_fixups,
> >       }, {
> > -             /* MX66U1G45G */
> > +             /* MX66U1G45G, MX66U1G93G */
> >               .id = SNOR_ID(0xc2, 0x25, 0x3b),
> >               .fixups = &macronix_qpp4b_fixups,
> >       }, {
>

Thanks,
Cheng Ming Lin