* [PATCH] staging: rtl8723bs: os_dep: remove redundant else in rtw_dev_unload
@ 2026-04-18 17:09 Shyam Sunder Reddy Padira
2026-04-21 14:17 ` Luka Gejak
0 siblings, 1 reply; 2+ messages in thread
From: Shyam Sunder Reddy Padira @ 2026-04-18 17:09 UTC (permalink / raw)
To: gregkh, ethantidmore06, straube.linux, dan.carpenter,
samasth.norway.ananda, vcaron, adrishbora, ofirmirovsky
Cc: linux-staging, linux-kernel, Shyam Sunder Reddy Padira
Remove the unnecessary else block following a break
statment to simplify the control flow and improve
code readability.
Signed-off-by: Shyam Sunder Reddy Padira <shyamsunderreddypadira@gmail.com>
---
drivers/staging/rtl8723bs/os_dep/os_intfs.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
index 29939bf5a156..3207d6d2c727 100644
--- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
+++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
@@ -988,12 +988,10 @@ void rtw_dev_unload(struct adapter *padapter)
rtw_stop_drv_threads(padapter);
while (atomic_read(&pcmdpriv->cmdthd_running)) {
- if (cnt > 5) {
+ if (cnt > 5)
break;
- } else {
- cnt++;
- msleep(10);
- }
+ cnt++;
+ msleep(10);
}
/* check the status of IPS */
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: rtl8723bs: os_dep: remove redundant else in rtw_dev_unload
2026-04-18 17:09 [PATCH] staging: rtl8723bs: os_dep: remove redundant else in rtw_dev_unload Shyam Sunder Reddy Padira
@ 2026-04-21 14:17 ` Luka Gejak
0 siblings, 0 replies; 2+ messages in thread
From: Luka Gejak @ 2026-04-21 14:17 UTC (permalink / raw)
To: Shyam Sunder Reddy Padira, gregkh, ethantidmore06, straube.linux,
dan.carpenter, samasth.norway.ananda, vcaron, adrishbora,
ofirmirovsky
Cc: linux-staging, linux-kernel
On Sat Apr 18, 2026 at 7:09 PM CEST, Shyam Sunder Reddy Padira wrote:
> Remove the unnecessary else block following a break
> statment to simplify the control flow and improve
> code readability.
>
> Signed-off-by: Shyam Sunder Reddy Padira <shyamsunderreddypadira@gmail.com>
> ---
> drivers/staging/rtl8723bs/os_dep/os_intfs.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> index 29939bf5a156..3207d6d2c727 100644
> --- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> +++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> @@ -988,12 +988,10 @@ void rtw_dev_unload(struct adapter *padapter)
> rtw_stop_drv_threads(padapter);
>
> while (atomic_read(&pcmdpriv->cmdthd_running)) {
> - if (cnt > 5) {
> + if (cnt > 5)
> break;
> - } else {
> - cnt++;
> - msleep(10);
> - }
> + cnt++;
> + msleep(10);
> }
>
> /* check the status of IPS */
LGTM.
Reviewed-by: Luka Gejak <luka.gejak@linux.dev>
Best regards,
Luka Gejak
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-04-21 14:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-18 17:09 [PATCH] staging: rtl8723bs: os_dep: remove redundant else in rtw_dev_unload Shyam Sunder Reddy Padira
2026-04-21 14:17 ` Luka Gejak
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox