From: "Luca Ceresoli" <luca.ceresoli@bootlin.com>
To: "Osama Abdelkader" <osama.abdelkader@gmail.com>,
"Alain Volmat" <alain.volmat@foss.st.com>,
"Raphael Gallais-Pou" <rgallaispou@gmail.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/3] drm/sti: remove bridge when sti_hda component_add fails
Date: Thu, 23 Apr 2026 10:22:52 +0200 [thread overview]
Message-ID: <DI0E0YLZCSMB.31RKF71K1MBPG@bootlin.com> (raw)
In-Reply-To: <20260414175417.144625-2-osama.abdelkader@gmail.com>
On Tue Apr 14, 2026 at 7:54 PM CEST, Osama Abdelkader wrote:
> Use devm_drm_bridge_add() so the bridge is released if probe fails after
> registration, and drop the manual drm_bridge_remove() in remove().
>
> Check the return value of devm_drm_bridge_add().
>
> v2: devm_drm_bridge_add instead of drm_bridge_add + goto remove_bridge
>
> Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
Looks like a bigfix, right? So it should have a Fixes tag.
Luca
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2026-04-23 8:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260414175417.144625-1-osama.abdelkader@gmail.com>
2026-04-14 17:54 ` [PATCH v2 1/3] drm/sti: remove bridge when sti_hda component_add fails Osama Abdelkader
2026-04-23 8:22 ` Luca Ceresoli [this message]
2026-04-14 17:54 ` [PATCH v2 2/3] drm/exynos: remove bridge when " Osama Abdelkader
2026-04-14 17:54 ` [PATCH v2 3/3] drm/bridge: megachips: remove bridge when irq request fails Osama Abdelkader
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DI0E0YLZCSMB.31RKF71K1MBPG@bootlin.com \
--to=luca.ceresoli@bootlin.com \
--cc=airlied@gmail.com \
--cc=alain.volmat@foss.st.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=osama.abdelkader@gmail.com \
--cc=rgallaispou@gmail.com \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox