From: "Luca Ceresoli" <luca.ceresoli@bootlin.com>
To: "Myeonghun Pak" <mhun512@gmail.com>,
"Alain Volmat" <alain.volmat@foss.st.com>,
"Raphael Gallais-Pou" <rgallaispou@gmail.com>
Cc: "Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/sti: hda: Fix bridge leak on component_add() failure
Date: Mon, 27 Apr 2026 15:02:49 +0200 [thread overview]
Message-ID: <DI3YHHC57ZD8.4FCLYJZ8YU19@bootlin.com> (raw)
In-Reply-To: <20260424121206.14558-1-mhun512@gmail.com>
Hello Myeonghun,
On Fri Apr 24, 2026 at 2:11 PM CEST, Myeonghun Pak wrote:
> sti_hda_probe() registers its bridge before adding the component. If
> component_add() fails, probe returns the error directly and leaves the
> bridge registered.
>
> The remove callback unregisters the bridge, but remove is only called
> after a successful probe. Remove the bridge locally when component_add()
> fails so the probe error path matches the successful-probe remove path.
>
> Signed-off-by: Myeonghun Pak <mhun512@gmail.com>
Duplicate of [0]?
[0] https://lore.kernel.org/all/20260423200622.325076-1-osama.abdelkader@gmail.com/
Luca
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2026-04-27 13:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-24 12:11 [PATCH] drm/sti: hda: Fix bridge leak on component_add() failure Myeonghun Pak
2026-04-27 13:02 ` Luca Ceresoli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DI3YHHC57ZD8.4FCLYJZ8YU19@bootlin.com \
--to=luca.ceresoli@bootlin.com \
--cc=airlied@gmail.com \
--cc=alain.volmat@foss.st.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mhun512@gmail.com \
--cc=mripard@kernel.org \
--cc=rgallaispou@gmail.com \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox