From: "Luca Ceresoli" <luca.ceresoli@bootlin.com>
To: "Vitor Soares" <ivitro@gmail.com>,
"Andrzej Hajda" <andrzej.hajda@intel.com>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Robert Foss" <rfoss@kernel.org>,
"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
"Jonas Karlman" <jonas@kwiboo.se>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>
Cc: "Vitor Soares" <vitor.soares@toradex.com>,
<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
<stable@vger.kernel.org>,
"Tomi Valkeinen" <tomi.valkeinen@ideasonboard.com>
Subject: Re: [PATCH v4] drm/bridge: cdns-dsi: Replace deprecated UNIVERSAL_DEV_PM_OPS()
Date: Thu, 30 Apr 2026 11:05:30 +0200 [thread overview]
Message-ID: <DI6DBEZ98XQD.53GKJABIWR3G@bootlin.com> (raw)
In-Reply-To: <19d0a0b1d33061a0421edf883acaaa7e366646c2.camel@gmail.com>
Hello Vitor,
On Thu Apr 30, 2026 at 10:52 AM CEST, Vitor Soares wrote:
>> > -static UNIVERSAL_DEV_PM_OPS(cdns_dsi_pm_ops, cdns_dsi_suspend,
>> > cdns_dsi_resume,
>> > - NULL);
>> > +static const struct dev_pm_ops cdns_dsi_pm_ops = {
>> > + RUNTIME_PM_OPS(cdns_dsi_suspend, cdns_dsi_resume, NULL)
>> > +};
>>
>> Not an expert here, but the docs [0] suggest using
>> DEFINE_RUNTIME_DEV_PM_OPS(). Is there a good reason to not do so?
>>
>> [0]
>> https://elixir.bootlin.com/linux/v7.0.1/source/include/linux/pm.h#L455-L456
>>
>> Luca
>>
>
> In an earlier discussion [0], we concluded that bridges/panels should only deal
> with runtime PM:
Ah, good. Then please mention this in the commit message in v5. It can help
others doing the right thing in future similar cases.
Luca
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2026-04-30 9:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-07 14:41 [PATCH v4] drm/bridge: cdns-dsi: Replace deprecated UNIVERSAL_DEV_PM_OPS() Vitor Soares
2026-04-29 13:43 ` Francesco Dolcini
2026-04-30 8:10 ` Luca Ceresoli
2026-04-30 8:52 ` Vitor Soares
2026-04-30 9:05 ` Luca Ceresoli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DI6DBEZ98XQD.53GKJABIWR3G@bootlin.com \
--to=luca.ceresoli@bootlin.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=ivitro@gmail.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=simona@ffwll.ch \
--cc=stable@vger.kernel.org \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=tzimmermann@suse.de \
--cc=vitor.soares@toradex.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox