* Re: [PATCH] can: m_can: Use of_property_present() for wakeup-source
[not found] <20260504050702.34013-1-phucduc.bui@gmail.com>
@ 2026-05-11 7:59 ` Markus Schneider-Pargmann
2026-05-11 10:27 ` Bui Duc Phuc
0 siblings, 1 reply; 2+ messages in thread
From: Markus Schneider-Pargmann @ 2026-05-11 7:59 UTC (permalink / raw)
To: phucduc.bui, msp, mkl, mailhol; +Cc: linux-can, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1480 bytes --]
Hi,
On Mon May 4, 2026 at 7:07 AM CEST, phucduc.bui wrote:
> From: bui duc phuc <phucduc.bui@gmail.com>
>
> The 'wakeup-source' property is declared as a phandle-array in both YAML
> bindings and Device Tree source files. However, the driver currently
> uses of_property_read_bool() to check for its existence.
>
> According to the function's documentation, usage on non-boolean property
> types is deprecated. Switch to of_property_present() to comply with the
> recommended API for checking the presence of a property.
>
> Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
I think this is a fix for
04d5826b074e ("can: m_can: Map WoL to device_set_wakeup_enable")
Can you please add a Fixes:?
Otherwise:
Acked-by: Markus Schneider-Pargmann <msp@baylibre.com>
Thank you
Markus
> ---
> drivers/net/can/m_can/m_can.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c
> index eb856547ae7d..16f80607e150 100644
> --- a/drivers/net/can/m_can/m_can.c
> +++ b/drivers/net/can/m_can/m_can.c
> @@ -2464,7 +2464,7 @@ struct m_can_classdev *m_can_class_allocate_dev(struct device *dev,
> return ERR_PTR(ret);
> }
>
> - if (dev->of_node && of_property_read_bool(dev->of_node, "wakeup-source"))
> + if (dev->of_node && of_property_present(dev->of_node, "wakeup-source"))
> device_set_wakeup_capable(dev, true);
>
> /* Get TX FIFO size
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 289 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread