[PATCH] rust: io: fix example in `register!` macro

[PATCH] rust: io: fix example in `register!` macro

[Link Mauve]

In this example, an u32 register is split in two u8 in big-endian order,
but the high byte is actually defined as taking nine bits instead of
eight.

This is completely inconsequential, as I expect most users will just
copy the bit ranges from their datasheets, but it doesn’t hurt to fix
that typo.

Signed-off-by: Link Mauve <linkmauve@linkmauve.fr>
---
 rust/kernel/io/register.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/rust/kernel/io/register.rs b/rust/kernel/io/register.rs
index f924c7c7c1db..66449377a0b7 100644
--- a/rust/kernel/io/register.rs
+++ b/rust/kernel/io/register.rs
@@ -448,7 +448,7 @@ fn into_io_op(self) -> (FixedRegisterLoc<T>, T) {
 ///
 /// register! {
 ///     FIXED_REG(u32) @ 0x100 {
-///         16:8 high_byte;
+///         15:8 high_byte;
 ///         7:0  low_byte;
 ///     }
 /// }
-- 
2.55.0

Re: [PATCH] rust: io: fix example in `register!` macro

[Gary Guo]

On Wed Jul 1, 2026 at 5:03 PM BST, Link Mauve wrote:
> In this example, an u32 register is split in two u8 in big-endian order,
> but the high byte is actually defined as taking nine bits instead of
> eight.
> 
> This is completely inconsequential, as I expect most users will just
> copy the bit ranges from their datasheets, but it doesn’t hurt to fix
> that typo.
> 
> Signed-off-by: Link Mauve <linkmauve@linkmauve.fr>

Reviewed-by: Gary Guo <gary@garyguo.net>

> ---
>  rust/kernel/io/register.rs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH] rust: io: fix example in `register!` macro

[Alexandre Courbot]

On Thu Jul 2, 2026 at 1:03 AM JST, Link Mauve wrote:
> In this example, an u32 register is split in two u8 in big-endian order,
> but the high byte is actually defined as taking nine bits instead of
> eight.
>
> This is completely inconsequential, as I expect most users will just
> copy the bit ranges from their datasheets, but it doesn’t hurt to fix
> that typo.
>
> Signed-off-by: Link Mauve <linkmauve@linkmauve.fr>

Acked-by: Alexandre Courbot <acourbot@nvidia.com>

Re: [PATCH] rust: io: fix example in `register!` macro

[Danilo Krummrich]

On Wed,  1 Jul 2026 18:03:54 +0200, Link Mauve wrote:
> [PATCH] rust: io: fix example in `register!` macro

Applied, thanks!

  Branch: driver-core-testing
  Tree:   git://git.kernel.org/pub/scm/linux/kernel/git/driver-core/driver-core.git

[1/1] rust: io: fix example in `register!` macro
      commit: 5dcef303b29f

The patch will appear in the next linux-next integration (typically within 24
hours on weekdays).

The patch is in the driver-core-testing branch and will be promoted to
driver-core-next after validation.