[PATCH 1/2] iio: adc: ti-ads131m02: Drop redundant NULL check on devm_clk_get_enabled()

[PATCH 1/2] iio: adc: ti-ads131m02: Drop redundant NULL check on devm_clk_get_enabled()

[Krzysztof Kozlowski]

devm_clk_get_enabled() does not return NULL (only valid clock or ERR
pointer), so simplify the code to drop redundant IS_ERR_OR_NULL().

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
 drivers/iio/adc/ti-ads131m02.c | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/drivers/iio/adc/ti-ads131m02.c b/drivers/iio/adc/ti-ads131m02.c
index 2f8f75c8216b..27c8abff216b 100644
--- a/drivers/iio/adc/ti-ads131m02.c
+++ b/drivers/iio/adc/ti-ads131m02.c
@@ -848,14 +848,8 @@ static int ads131m_parse_clock(struct ads131m_priv *priv, bool *is_xtal)
 	int ret;
 
 	clk = devm_clk_get_enabled(dev, NULL);
-	if (IS_ERR_OR_NULL(clk)) {
-		if (IS_ERR(clk))
-			ret = PTR_ERR(clk);
-		else
-			ret = -ENODEV;
-
-		return dev_err_probe(dev, ret, "clk get enabled failed\n");
-	}
+	if (IS_ERR(clk))
+		return dev_err_probe(dev, PTR_ERR(clk), "clk get enabled failed\n");
 
 	ret = device_property_match_string(dev, "clock-names", "xtal");
 	if (ret > 0)
-- 
2.53.0

[PATCH 2/2] iio: adc: ade9000: Drop incorrect kerneldoc marker

[Krzysztof Kozlowski]

Top-level comment is not a kerneldoc, so drop marker to fix W=1 warning:

  drivers/iio/adc/ade9000.c:2 This comment starts with '/**', but isn't a kernel-doc comment. Refer to Documentation/doc-guide/kernel-doc.rst

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
 drivers/iio/adc/ade9000.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/adc/ade9000.c b/drivers/iio/adc/ade9000.c
index b80cdd8ad982..c6c3ea953fea 100644
--- a/drivers/iio/adc/ade9000.c
+++ b/drivers/iio/adc/ade9000.c
@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: GPL-2.0-only
-/**
+/*
  * ADE9000 driver
  *
  * Copyright 2025 Analog Devices Inc.
-- 
2.53.0

Re: [PATCH 2/2] iio: adc: ade9000: Drop incorrect kerneldoc marker

[Joshua Crofts]

On Sun, 5 Jul 2026 at 19:25, Krzysztof Kozlowski
<krzysztof.kozlowski@oss.qualcomm.com> wrote:
>
> Top-level comment is not a kerneldoc, so drop marker to fix W=1 warning:
>
>   drivers/iio/adc/ade9000.c:2 This comment starts with '/**', but isn't a kernel-doc comment. Refer to Documentation/doc-guide/kernel-doc.rst
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> ---

Reviewed-by: Joshua Crofts <joshua.crofts1@gmail.com>

-- 
Kind regards

CJD

Re: [PATCH 2/2] iio: adc: ade9000: Drop incorrect kerneldoc marker

[Maxwell Doose]

On Sun Jul 5, 2026 at 12:24 PM CDT
Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> wrote:

> Top-level comment is not a kerneldoc, so drop marker to fix W=1 warning:
>
>   drivers/iio/adc/ade9000.c:2 This comment starts with '/**', but isn't a kernel-doc comment. Refer to Documentation/doc-guide/kernel-doc.rst
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> ---
>  drivers/iio/adc/ade9000.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Maxwell Doose <m32285159@gmail.com>

-- 
best regards,
max

Re: [PATCH 2/2] iio: adc: ade9000: Drop incorrect kerneldoc marker

[Jonathan Cameron]

On Sun, 05 Jul 2026 12:50:28 -0500
"Maxwell Doose" <m32285159@gmail.com> wrote:

> On Sun Jul 5, 2026 at 12:24 PM CDT
> Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> wrote:
> 
> > Top-level comment is not a kerneldoc, so drop marker to fix W=1 warning:
> >
> >   drivers/iio/adc/ade9000.c:2 This comment starts with '/**', but isn't a kernel-doc comment. Refer to Documentation/doc-guide/kernel-doc.rst
> >
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> > ---
> >  drivers/iio/adc/ade9000.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >  
> 
> Reviewed-by: Maxwell Doose <m32285159@gmail.com>
> 

Applied.

Re: [PATCH 1/2] iio: adc: ti-ads131m02: Drop redundant NULL check on devm_clk_get_enabled()

[Joshua Crofts]

On Sun, 5 Jul 2026 at 19:26, Krzysztof Kozlowski
<krzysztof.kozlowski@oss.qualcomm.com> wrote:
>
> devm_clk_get_enabled() does not return NULL (only valid clock or ERR
> pointer), so simplify the code to drop redundant IS_ERR_OR_NULL().
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> ---

LGTM.

Reviewed-by: Joshua Crofts <joshua.crofts1@gmail.com>

-- 
Kind regards

CJD

Re: [PATCH 1/2] iio: adc: ti-ads131m02: Drop redundant NULL check on devm_clk_get_enabled()

[Jonathan Cameron]

On Sun,  5 Jul 2026 19:24:39 +0200
Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> wrote:

> devm_clk_get_enabled() does not return NULL (only valid clock or ERR
> pointer), so simplify the code to drop redundant IS_ERR_OR_NULL().
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
See the stub.

static inline struct clk *devm_clk_get_enabled(struct device *dev,
					       const char *id)
{
	return NULL;
}
Not sure what the reasoning behind that is.  Maybe that
clock could be already on?

We could I guess make this driver depend on one of the clk
related configs, but today it doesn't. So to me this NULL check smells
of protection we don't need so I think the change is fine, but the
patch description should reflect that stub and it being considered
reasonable to plough on regardless.

Jonathan


> ---
>  drivers/iio/adc/ti-ads131m02.c | 10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/iio/adc/ti-ads131m02.c b/drivers/iio/adc/ti-ads131m02.c
> index 2f8f75c8216b..27c8abff216b 100644
> --- a/drivers/iio/adc/ti-ads131m02.c
> +++ b/drivers/iio/adc/ti-ads131m02.c
> @@ -848,14 +848,8 @@ static int ads131m_parse_clock(struct ads131m_priv *priv, bool *is_xtal)
>  	int ret;
>  
>  	clk = devm_clk_get_enabled(dev, NULL);
> -	if (IS_ERR_OR_NULL(clk)) {
> -		if (IS_ERR(clk))
> -			ret = PTR_ERR(clk);
> -		else
> -			ret = -ENODEV;
> -
> -		return dev_err_probe(dev, ret, "clk get enabled failed\n");
> -	}
> +	if (IS_ERR(clk))
> +		return dev_err_probe(dev, PTR_ERR(clk), "clk get enabled failed\n");
>  
>  	ret = device_property_match_string(dev, "clock-names", "xtal");
>  	if (ret > 0)

Re: [PATCH 1/2] iio: adc: ti-ads131m02: Drop redundant NULL check on devm_clk_get_enabled()

[Krzysztof Kozlowski]

On 06/07/2026 01:37, Jonathan Cameron wrote:
> On Sun,  5 Jul 2026 19:24:39 +0200
> Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> wrote:
> 
>> devm_clk_get_enabled() does not return NULL (only valid clock or ERR
>> pointer), so simplify the code to drop redundant IS_ERR_OR_NULL().
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> See the stub.
> 
> static inline struct clk *devm_clk_get_enabled(struct device *dev,
> 					       const char *id)
> {
> 	return NULL;
> }
> Not sure what the reasoning behind that is.  Maybe that
> clock could be already on?
> 
> We could I guess make this driver depend on one of the clk
> related configs, but today it doesn't. So to me this NULL check smells
> of protection we don't need so I think the change is fine, but the
> patch description should reflect that stub and it being considered
> reasonable to plough on regardless.

Oh, I missed the stub. Stub is wrong and should be fixed (and then this
patch makes more sense).

Best regards,
Krzysztof

Re: [PATCH 1/2] iio: adc: ti-ads131m02: Drop redundant NULL check on devm_clk_get_enabled()

[Andy Shevchenko]

On Mon, Jul 06, 2026 at 12:37:12AM +0100, Jonathan Cameron wrote:
> On Sun,  5 Jul 2026 19:24:39 +0200
> Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> wrote:
> 
> > devm_clk_get_enabled() does not return NULL (only valid clock or ERR
> > pointer), so simplify the code to drop redundant IS_ERR_OR_NULL().
> > 
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> See the stub.
> 
> static inline struct clk *devm_clk_get_enabled(struct device *dev,
> 					       const char *id)
> {
> 	return NULL;
> }
> Not sure what the reasoning behind that is.  Maybe that
> clock could be already on?
> 
> We could I guess make this driver depend on one of the clk
> related configs, but today it doesn't. So to me this NULL check smells
> of protection we don't need so I think the change is fine, but the
> patch description should reflect that stub and it being considered
> reasonable to plough on regardless.

Ah, good catch! I have thought for a moment about this possibility, but I gave
tag anyway as the stub thingy should be addressed separately anyway as there
are many drivers (I think) that do not check for NULL.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH 1/2] iio: adc: ti-ads131m02: Drop redundant NULL check on devm_clk_get_enabled()

[Krzysztof Kozlowski]

On 06/07/2026 08:04, Andy Shevchenko wrote:
> On Mon, Jul 06, 2026 at 12:37:12AM +0100, Jonathan Cameron wrote:
>> On Sun,  5 Jul 2026 19:24:39 +0200
>> Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> wrote:
>>
>>> devm_clk_get_enabled() does not return NULL (only valid clock or ERR
>>> pointer), so simplify the code to drop redundant IS_ERR_OR_NULL().
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
>> See the stub.
>>
>> static inline struct clk *devm_clk_get_enabled(struct device *dev,
>> 					       const char *id)
>> {
>> 	return NULL;
>> }
>> Not sure what the reasoning behind that is.  Maybe that
>> clock could be already on?
>>
>> We could I guess make this driver depend on one of the clk
>> related configs, but today it doesn't. So to me this NULL check smells
>> of protection we don't need so I think the change is fine, but the
>> patch description should reflect that stub and it being considered
>> reasonable to plough on regardless.
> 
> Ah, good catch! I have thought for a moment about this possibility, but I gave
> tag anyway as the stub thingy should be addressed separately anyway as there
> are many drivers (I think) that do not check for NULL.

Except these ~8 cases I found (I sent a bunch of patches), no one checks
for NULL...

Best regards,
Krzysztof

Re: [PATCH 1/2] iio: adc: ti-ads131m02: Drop redundant NULL check on devm_clk_get_enabled()

[Andy Shevchenko]

On Mon, Jul 6, 2026 at 9:55 AM Krzysztof Kozlowski
<krzysztof.kozlowski@oss.qualcomm.com> wrote:
> On 06/07/2026 08:04, Andy Shevchenko wrote:
> > On Mon, Jul 06, 2026 at 12:37:12AM +0100, Jonathan Cameron wrote:
> >> On Sun,  5 Jul 2026 19:24:39 +0200
> >> Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> wrote:
> >>
> >>> devm_clk_get_enabled() does not return NULL (only valid clock or ERR
> >>> pointer), so simplify the code to drop redundant IS_ERR_OR_NULL().
> >>>
> >>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> >> See the stub.
> >>
> >> static inline struct clk *devm_clk_get_enabled(struct device *dev,
> >>                                             const char *id)
> >> {
> >>      return NULL;
> >> }
> >> Not sure what the reasoning behind that is.  Maybe that
> >> clock could be already on?
> >>
> >> We could I guess make this driver depend on one of the clk
> >> related configs, but today it doesn't. So to me this NULL check smells
> >> of protection we don't need so I think the change is fine, but the
> >> patch description should reflect that stub and it being considered
> >> reasonable to plough on regardless.
> >
> > Ah, good catch! I have thought for a moment about this possibility, but I gave
> > tag anyway as the stub thingy should be addressed separately anyway as there
> > are many drivers (I think) that do not check for NULL.
>
> Except these ~8 cases I found (I sent a bunch of patches), no one checks
> for NULL...

Thanks for confirming. So, I think this patch is good to go (maybe
with the updated commit message), but the stub perhaps should also be
addressed at some point somehow.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH 1/2] iio: adc: ti-ads131m02: Drop redundant NULL check on devm_clk_get_enabled()

[Andy Shevchenko]

On Sun, Jul 05, 2026 at 07:24:39PM +0200, Krzysztof Kozlowski wrote:
> devm_clk_get_enabled() does not return NULL (only valid clock or ERR
> pointer), so simplify the code to drop redundant IS_ERR_OR_NULL().

Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>

-- 
With Best Regards,
Andy Shevchenko