* [PATCH 00/10] drm/bridge: Remove redundant error messages on IRQ request failure
@ 2026-07-23 13:16 Pan Chuang
2026-07-23 13:16 ` [PATCH 01/10] drm/bridge: analogix_dp: Remove redundant dev_err() Pan Chuang
` (10 more replies)
0 siblings, 11 replies; 18+ messages in thread
From: Pan Chuang @ 2026-07-23 13:16 UTC (permalink / raw)
To: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, Luca Ceresoli, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Inki Dae, Jagan Teki, Marek Szyprowski, Andy Yan,
Douglas Anderson, Damon Ding, Dmitry Baryshkov, Heiko Stuebner,
Tomi Valkeinen, Harikrishna Shenoy, Jayesh Choudhary, Kees Cook,
open list:DRM DRIVERS, open list
Cc: Pan Chuang
Commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()") added automatic error logging to
devm_request_threaded_irq() and devm_request_any_context_irq()
via the new devm_request_result() helper, which prints device
name, IRQ number, handler functions, and error code on failure.
Since devm_request_irq() is a static inline wrapper around
devm_request_threaded_irq(), it also benefits from this
automatic logging.
Remove the now-redundant dev_err() and dev_err_probe() calls
in drm/bridge drivers that follow these devm_request_*_irq()
functions, as the core now provides more detailed diagnostic
information on failure.
Pan Chuang (10):
drm/bridge: analogix_dp: Remove redundant dev_err()
drm/bridge: cdns-mhdp8546: Remove redundant dev_err()
drm/bridge: lt9611: Remove redundant dev_err()
drm/bridge: samsung-dsim: Remove redundant dev_err()
drm/bridge: synopsys: dw-dp: Remove redundant dev_err_probe()
drm/bridge: tc358767: Remove redundant dev_err()
drm/bridge: it6505: Remove redundant dev_err()
drm/bridge/sii8620: Remove redundant dev_err_probe()
drm/bridge: ti-sn65dsi83: Remove redundant dev_err_probe()
drm/bridge: ti-sn65dsi86: Remove redundant dev_err_probe()
drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 4 +---
drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c | 1 -
drivers/gpu/drm/bridge/ite-it6505.c | 4 +---
drivers/gpu/drm/bridge/lontium-lt9611.c | 4 +---
drivers/gpu/drm/bridge/samsung-dsim.c | 4 +---
drivers/gpu/drm/bridge/sil-sii8620.c | 3 +--
drivers/gpu/drm/bridge/synopsys/dw-dp.c | 4 +---
drivers/gpu/drm/bridge/tc358767.c | 4 +---
drivers/gpu/drm/bridge/ti-sn65dsi83.c | 2 +-
drivers/gpu/drm/bridge/ti-sn65dsi86.c | 2 +-
10 files changed, 9 insertions(+), 23 deletions(-)
--
2.34.1
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH 01/10] drm/bridge: analogix_dp: Remove redundant dev_err()
2026-07-23 13:16 [PATCH 00/10] drm/bridge: Remove redundant error messages on IRQ request failure Pan Chuang
@ 2026-07-23 13:16 ` Pan Chuang
2026-07-24 1:14 ` Damon Ding
2026-07-23 13:16 ` [PATCH 02/10] drm/bridge: cdns-mhdp8546: " Pan Chuang
` (9 subsequent siblings)
10 siblings, 1 reply; 18+ messages in thread
From: Pan Chuang @ 2026-07-23 13:16 UTC (permalink / raw)
To: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, Luca Ceresoli, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Damon Ding, Dmitry Baryshkov, Heiko Stuebner,
open list:DRM DRIVERS, open list
Cc: Pan Chuang
Since commit
55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"),
devm_request_threaded_irq() automatically logs detailed error messages on
failure. Remove the now-redundant driver-specific dev_err() call.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
index 30c0c0b41d5a..566f1e5eb8cd 100644
--- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
+++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
@@ -1414,10 +1414,8 @@ analogix_dp_probe(struct device *dev, struct analogix_dp_plat_data *plat_data)
analogix_dp_hardirq,
analogix_dp_irq_thread,
irq_flags, "analogix-dp", dp);
- if (ret) {
- dev_err(&pdev->dev, "failed to request irq\n");
+ if (ret)
return ERR_PTR(ret);
- }
dp->aux.name = "DP-AUX";
dp->aux.transfer = analogix_dpaux_transfer;
--
2.34.1
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 02/10] drm/bridge: cdns-mhdp8546: Remove redundant dev_err()
2026-07-23 13:16 [PATCH 00/10] drm/bridge: Remove redundant error messages on IRQ request failure Pan Chuang
2026-07-23 13:16 ` [PATCH 01/10] drm/bridge: analogix_dp: Remove redundant dev_err() Pan Chuang
@ 2026-07-23 13:16 ` Pan Chuang
2026-07-23 13:16 ` [PATCH 03/10] drm/bridge: lt9611: " Pan Chuang
` (8 subsequent siblings)
10 siblings, 0 replies; 18+ messages in thread
From: Pan Chuang @ 2026-07-23 13:16 UTC (permalink / raw)
To: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, Luca Ceresoli, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Harikrishna Shenoy, Tomi Valkeinen, Jayesh Choudhary, Kees Cook,
Qi Xi, open list:DRM DRIVERS, open list
Cc: Pan Chuang
Since commit
55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"),
devm_request_threaded_irq() automatically logs detailed error messages on
failure. Remove the now-redundant driver-specific dev_err() call.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c
index 504a3186ebb3..f47717bd1079 100644
--- a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c
+++ b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c
@@ -2343,7 +2343,6 @@ static int cdns_mhdp_probe(struct platform_device *pdev)
cdns_mhdp_irq_handler, IRQF_ONESHOT,
"mhdp8546", mhdp);
if (ret) {
- dev_err(dev, "cannot install IRQ %d\n", irq);
ret = -EIO;
goto plat_fini;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 03/10] drm/bridge: lt9611: Remove redundant dev_err()
2026-07-23 13:16 [PATCH 00/10] drm/bridge: Remove redundant error messages on IRQ request failure Pan Chuang
2026-07-23 13:16 ` [PATCH 01/10] drm/bridge: analogix_dp: Remove redundant dev_err() Pan Chuang
2026-07-23 13:16 ` [PATCH 02/10] drm/bridge: cdns-mhdp8546: " Pan Chuang
@ 2026-07-23 13:16 ` Pan Chuang
2026-07-23 13:16 ` [PATCH 04/10] drm/bridge: samsung-dsim: " Pan Chuang
` (7 subsequent siblings)
10 siblings, 0 replies; 18+ messages in thread
From: Pan Chuang @ 2026-07-23 13:16 UTC (permalink / raw)
To: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, Luca Ceresoli, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
open list:DRM DRIVERS, open list
Cc: Pan Chuang
Since commit
55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"),
devm_request_threaded_irq() automatically logs detailed error messages on
failure. Remove the now-redundant driver-specific dev_err() call.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/gpu/drm/bridge/lontium-lt9611.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c b/drivers/gpu/drm/bridge/lontium-lt9611.c
index b6a368f71285..05950cbc0a90 100644
--- a/drivers/gpu/drm/bridge/lontium-lt9611.c
+++ b/drivers/gpu/drm/bridge/lontium-lt9611.c
@@ -1156,10 +1156,8 @@ static int lt9611_probe(struct i2c_client *client)
ret = devm_request_threaded_irq(dev, client->irq, NULL,
lt9611_irq_thread_handler,
IRQF_ONESHOT, "lt9611", lt9611);
- if (ret) {
- dev_err(dev, "failed to request irq\n");
+ if (ret)
goto err_disable_regulators;
- }
i2c_set_clientdata(client, lt9611);
--
2.34.1
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 04/10] drm/bridge: samsung-dsim: Remove redundant dev_err()
2026-07-23 13:16 [PATCH 00/10] drm/bridge: Remove redundant error messages on IRQ request failure Pan Chuang
` (2 preceding siblings ...)
2026-07-23 13:16 ` [PATCH 03/10] drm/bridge: lt9611: " Pan Chuang
@ 2026-07-23 13:16 ` Pan Chuang
2026-07-23 13:16 ` [PATCH 05/10] drm/bridge: synopsys: dw-dp: Remove redundant dev_err_probe() Pan Chuang
` (6 subsequent siblings)
10 siblings, 0 replies; 18+ messages in thread
From: Pan Chuang @ 2026-07-23 13:16 UTC (permalink / raw)
To: Inki Dae, Jagan Teki, Marek Szyprowski, Andrzej Hajda,
Neil Armstrong, Robert Foss, Laurent Pinchart, Jonas Karlman,
Jernej Skrabec, Luca Ceresoli, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter,
open list:DRM DRIVERS, open list
Cc: Pan Chuang
Since commit
55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"),
devm_request_threaded_irq() automatically logs detailed error messages on
failure. Remove the now-redundant driver-specific dev_err() call.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/gpu/drm/bridge/samsung-dsim.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c
index 25ab475309e8..991d370daea1 100644
--- a/drivers/gpu/drm/bridge/samsung-dsim.c
+++ b/drivers/gpu/drm/bridge/samsung-dsim.c
@@ -2183,10 +2183,8 @@ int samsung_dsim_probe(struct platform_device *pdev)
samsung_dsim_irq,
IRQF_ONESHOT | IRQF_NO_AUTOEN,
dev_name(dev), dsi);
- if (ret) {
- dev_err(dev, "failed to request dsi irq\n");
+ if (ret)
return ret;
- }
ret = samsung_dsim_parse_dt(dsi);
if (ret)
--
2.34.1
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 05/10] drm/bridge: synopsys: dw-dp: Remove redundant dev_err_probe()
2026-07-23 13:16 [PATCH 00/10] drm/bridge: Remove redundant error messages on IRQ request failure Pan Chuang
` (3 preceding siblings ...)
2026-07-23 13:16 ` [PATCH 04/10] drm/bridge: samsung-dsim: " Pan Chuang
@ 2026-07-23 13:16 ` Pan Chuang
2026-07-23 13:16 ` [PATCH 06/10] drm/bridge: tc358767: Remove redundant dev_err() Pan Chuang
` (5 subsequent siblings)
10 siblings, 0 replies; 18+ messages in thread
From: Pan Chuang @ 2026-07-23 13:16 UTC (permalink / raw)
To: Andy Yan, Andrzej Hajda, Neil Armstrong, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec, Luca Ceresoli,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter, open list:DRM DRIVERS, open list
Cc: Pan Chuang
Since commit
55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"),
devm_request_threaded_irq() automatically logs detailed error messages on
failure. Remove the now-redundant driver-specific dev_err_probe() call.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/gpu/drm/bridge/synopsys/dw-dp.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/bridge/synopsys/dw-dp.c b/drivers/gpu/drm/bridge/synopsys/dw-dp.c
index 3445c82e6f50..aea8973fb825 100644
--- a/drivers/gpu/drm/bridge/synopsys/dw-dp.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-dp.c
@@ -2080,10 +2080,8 @@ struct dw_dp *dw_dp_bind(struct device *dev, struct drm_encoder *encoder,
ret = devm_request_threaded_irq(dev, dp->irq, NULL, dw_dp_irq,
IRQF_ONESHOT, dev_name(dev), dp);
- if (ret) {
- dev_err_probe(dev, ret, "failed to request irq\n");
+ if (ret)
goto unregister_aux;
- }
return dp;
--
2.34.1
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 06/10] drm/bridge: tc358767: Remove redundant dev_err()
2026-07-23 13:16 [PATCH 00/10] drm/bridge: Remove redundant error messages on IRQ request failure Pan Chuang
` (4 preceding siblings ...)
2026-07-23 13:16 ` [PATCH 05/10] drm/bridge: synopsys: dw-dp: Remove redundant dev_err_probe() Pan Chuang
@ 2026-07-23 13:16 ` Pan Chuang
2026-07-23 13:16 ` [PATCH 07/10] drm/bridge: it6505: " Pan Chuang
` (4 subsequent siblings)
10 siblings, 0 replies; 18+ messages in thread
From: Pan Chuang @ 2026-07-23 13:16 UTC (permalink / raw)
To: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, Luca Ceresoli, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
open list:DRM DRIVERS, open list
Cc: Pan Chuang
Since commit
55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"),
devm_request_threaded_irq() automatically logs detailed error messages on
failure. Remove the now-redundant driver-specific dev_err() call.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/gpu/drm/bridge/tc358767.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c
index ce1b73214f26..ab644e4f3a95 100644
--- a/drivers/gpu/drm/bridge/tc358767.c
+++ b/drivers/gpu/drm/bridge/tc358767.c
@@ -2528,10 +2528,8 @@ static int tc_probe(struct i2c_client *client)
NULL, tc_irq_handler,
IRQF_ONESHOT,
"tc358767-irq", tc);
- if (ret) {
- dev_err(dev, "failed to register dp interrupt\n");
+ if (ret)
return ret;
- }
tc->have_irq = true;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 07/10] drm/bridge: it6505: Remove redundant dev_err()
2026-07-23 13:16 [PATCH 00/10] drm/bridge: Remove redundant error messages on IRQ request failure Pan Chuang
` (5 preceding siblings ...)
2026-07-23 13:16 ` [PATCH 06/10] drm/bridge: tc358767: Remove redundant dev_err() Pan Chuang
@ 2026-07-23 13:16 ` Pan Chuang
2026-07-23 13:16 ` [PATCH 08/10] drm/bridge/sii8620: Remove redundant dev_err_probe() Pan Chuang
` (3 subsequent siblings)
10 siblings, 0 replies; 18+ messages in thread
From: Pan Chuang @ 2026-07-23 13:16 UTC (permalink / raw)
To: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, Luca Ceresoli, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
open list:DRM DRIVERS, open list
Cc: Pan Chuang
Since commit
55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"),
devm_request_threaded_irq() automatically logs detailed error messages on
failure. Remove the now-redundant driver-specific dev_err() call.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/gpu/drm/bridge/ite-it6505.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm/bridge/ite-it6505.c
index 8ecb43611dba..fe0f4ab16216 100644
--- a/drivers/gpu/drm/bridge/ite-it6505.c
+++ b/drivers/gpu/drm/bridge/ite-it6505.c
@@ -3607,10 +3607,8 @@ static int it6505_i2c_probe(struct i2c_client *client)
IRQF_TRIGGER_LOW | IRQF_ONESHOT |
IRQF_NO_AUTOEN,
"it6505-intp", it6505);
- if (err) {
- dev_err(dev, "Failed to request INTP threaded IRQ: %d", err);
+ if (err)
return err;
- }
INIT_WORK(&it6505->link_works, it6505_link_training_work);
INIT_WORK(&it6505->hdcp_wait_ksv_list, it6505_hdcp_wait_ksv_list);
--
2.34.1
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 08/10] drm/bridge/sii8620: Remove redundant dev_err_probe()
2026-07-23 13:16 [PATCH 00/10] drm/bridge: Remove redundant error messages on IRQ request failure Pan Chuang
` (6 preceding siblings ...)
2026-07-23 13:16 ` [PATCH 07/10] drm/bridge: it6505: " Pan Chuang
@ 2026-07-23 13:16 ` Pan Chuang
2026-07-23 13:16 ` [PATCH 09/10] drm/bridge: ti-sn65dsi83: " Pan Chuang
` (2 subsequent siblings)
10 siblings, 0 replies; 18+ messages in thread
From: Pan Chuang @ 2026-07-23 13:16 UTC (permalink / raw)
To: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, Luca Ceresoli, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
open list:DRM DRIVERS, open list
Cc: Pan Chuang
Since commit
55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"),
devm_request_threaded_irq() automatically logs detailed error messages on
failure. Remove the now-redundant driver-specific dev_err_probe() call.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/gpu/drm/bridge/sil-sii8620.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/sil-sii8620.c b/drivers/gpu/drm/bridge/sil-sii8620.c
index 22c81b38b41e..0b03142faa37 100644
--- a/drivers/gpu/drm/bridge/sil-sii8620.c
+++ b/drivers/gpu/drm/bridge/sil-sii8620.c
@@ -2320,8 +2320,7 @@ static int sii8620_probe(struct i2c_client *client)
IRQF_TRIGGER_HIGH | IRQF_ONESHOT,
"sii8620", ctx);
if (ret < 0)
- return dev_err_probe(dev, ret,
- "failed to install IRQ handler\n");
+ return ret;
ctx->gpio_reset = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH);
if (IS_ERR(ctx->gpio_reset))
--
2.34.1
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 09/10] drm/bridge: ti-sn65dsi83: Remove redundant dev_err_probe()
2026-07-23 13:16 [PATCH 00/10] drm/bridge: Remove redundant error messages on IRQ request failure Pan Chuang
` (7 preceding siblings ...)
2026-07-23 13:16 ` [PATCH 08/10] drm/bridge/sii8620: Remove redundant dev_err_probe() Pan Chuang
@ 2026-07-23 13:16 ` Pan Chuang
2026-07-23 13:16 ` [PATCH 10/10] drm/bridge: ti-sn65dsi86: " Pan Chuang
2026-07-23 14:30 ` [PATCH 00/10] drm/bridge: Remove redundant error messages on IRQ request failure Luca Ceresoli
10 siblings, 0 replies; 18+ messages in thread
From: Pan Chuang @ 2026-07-23 13:16 UTC (permalink / raw)
To: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, Luca Ceresoli, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
open list:DRM DRIVERS, open list
Cc: Pan Chuang
Since commit
55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"),
devm_request_threaded_irq() automatically logs detailed error messages on
failure. Remove the now-redundant driver-specific dev_err_probe() call.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/gpu/drm/bridge/ti-sn65dsi83.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi83.c b/drivers/gpu/drm/bridge/ti-sn65dsi83.c
index e6dbe51d0dba..3bc422c9d77a 100644
--- a/drivers/gpu/drm/bridge/ti-sn65dsi83.c
+++ b/drivers/gpu/drm/bridge/ti-sn65dsi83.c
@@ -1040,7 +1040,7 @@ static int sn65dsi83_probe(struct i2c_client *client)
ret = devm_request_threaded_irq(ctx->dev, ctx->irq, NULL, sn65dsi83_irq,
IRQF_ONESHOT, dev_name(ctx->dev), ctx);
if (ret)
- return dev_err_probe(dev, ret, "failed to request irq\n");
+ return ret;
}
dev_set_drvdata(dev, ctx);
--
2.34.1
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 10/10] drm/bridge: ti-sn65dsi86: Remove redundant dev_err_probe()
2026-07-23 13:16 [PATCH 00/10] drm/bridge: Remove redundant error messages on IRQ request failure Pan Chuang
` (8 preceding siblings ...)
2026-07-23 13:16 ` [PATCH 09/10] drm/bridge: ti-sn65dsi83: " Pan Chuang
@ 2026-07-23 13:16 ` Pan Chuang
2026-07-25 2:11 ` Doug Anderson
2026-07-23 14:30 ` [PATCH 00/10] drm/bridge: Remove redundant error messages on IRQ request failure Luca Ceresoli
10 siblings, 1 reply; 18+ messages in thread
From: Pan Chuang @ 2026-07-23 13:16 UTC (permalink / raw)
To: Douglas Anderson, Andrzej Hajda, Neil Armstrong, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec, Luca Ceresoli,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter, open list:DRM DRIVERS, open list
Cc: Pan Chuang
Since commit
55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"),
devm_request_threaded_irq() automatically logs detailed error messages on
failure. Remove the now-redundant driver-specific dev_err_probe() call.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/gpu/drm/bridge/ti-sn65dsi86.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
index 1da242f17413..2fcb4039fd61 100644
--- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
+++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
@@ -2080,7 +2080,7 @@ static int ti_sn65dsi86_probe(struct i2c_client *client)
dev_name(pdata->dev), pdata);
if (ret)
- return dev_err_probe(dev, ret, "failed to request interrupt\n");
+ return ret;
}
/*
--
2.34.1
^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [PATCH 00/10] drm/bridge: Remove redundant error messages on IRQ request failure
2026-07-23 13:16 [PATCH 00/10] drm/bridge: Remove redundant error messages on IRQ request failure Pan Chuang
` (9 preceding siblings ...)
2026-07-23 13:16 ` [PATCH 10/10] drm/bridge: ti-sn65dsi86: " Pan Chuang
@ 2026-07-23 14:30 ` Luca Ceresoli
2026-07-31 7:12 ` Luca Ceresoli
10 siblings, 1 reply; 18+ messages in thread
From: Luca Ceresoli @ 2026-07-23 14:30 UTC (permalink / raw)
To: Pan Chuang
Cc: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, Luca Ceresoli, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Inki Dae, Jagan Teki, Marek Szyprowski, Andy Yan,
Douglas Anderson, Damon Ding, Dmitry Baryshkov, Heiko Stuebner,
Tomi Valkeinen, Harikrishna Shenoy, Jayesh Choudhary, Kees Cook,
dri-devel, linux-kernel
On Thu, 23 Jul 2026 21:16:32 +0800, Pan Chuang <panchuang@vivo.com> wrote:
> drm/bridge: Remove redundant error messages on IRQ request failure
>
> Commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()") added automatic error logging to
> devm_request_threaded_irq() and devm_request_any_context_irq()
> via the new devm_request_result() helper, which prints device
> name, IRQ number, handler functions, and error code on failure.
>
> [...]
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 01/10] drm/bridge: analogix_dp: Remove redundant dev_err()
2026-07-23 13:16 ` [PATCH 01/10] drm/bridge: analogix_dp: Remove redundant dev_err() Pan Chuang
@ 2026-07-24 1:14 ` Damon Ding
0 siblings, 0 replies; 18+ messages in thread
From: Damon Ding @ 2026-07-24 1:14 UTC (permalink / raw)
To: Pan Chuang, Andrzej Hajda, Neil Armstrong, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec, Luca Ceresoli,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter, Dmitry Baryshkov, Heiko Stuebner,
open list:DRM DRIVERS, open list
Hi Pan,
On 7/23/2026 9:16 PM, Pan Chuang wrote:
> Since commit
> 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"),
> devm_request_threaded_irq() automatically logs detailed error messages on
> failure. Remove the now-redundant driver-specific dev_err() call.
>
> Signed-off-by: Pan Chuang <panchuang@vivo.com>
> ---
> drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> index 30c0c0b41d5a..566f1e5eb8cd 100644
> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> @@ -1414,10 +1414,8 @@ analogix_dp_probe(struct device *dev, struct analogix_dp_plat_data *plat_data)
> analogix_dp_hardirq,
> analogix_dp_irq_thread,
> irq_flags, "analogix-dp", dp);
> - if (ret) {
> - dev_err(&pdev->dev, "failed to request irq\n");
> + if (ret)
> return ERR_PTR(ret);
> - }
>
> dp->aux.name = "DP-AUX";
> dp->aux.transfer = analogix_dpaux_transfer;
Reviewed-by: Damon Ding <damon.ding@rock-chips.com>
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 10/10] drm/bridge: ti-sn65dsi86: Remove redundant dev_err_probe()
2026-07-23 13:16 ` [PATCH 10/10] drm/bridge: ti-sn65dsi86: " Pan Chuang
@ 2026-07-25 2:11 ` Doug Anderson
2026-07-30 21:17 ` Doug Anderson
0 siblings, 1 reply; 18+ messages in thread
From: Doug Anderson @ 2026-07-25 2:11 UTC (permalink / raw)
To: Pan Chuang
Cc: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, Luca Ceresoli, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
open list:DRM DRIVERS, open list
Hi,
On Thu, Jul 23, 2026 at 6:17 AM Pan Chuang <panchuang@vivo.com> wrote:
>
> Since commit
> 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"),
> devm_request_threaded_irq() automatically logs detailed error messages on
> failure. Remove the now-redundant driver-specific dev_err_probe() call.
>
> Signed-off-by: Pan Chuang <panchuang@vivo.com>
> ---
> drivers/gpu/drm/bridge/ti-sn65dsi86.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Douglas Anderson <dianders@chromium.org>
I'll plan to apply this to drm-misc-next in ~1 week unless anything comes up.
-Doug
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 10/10] drm/bridge: ti-sn65dsi86: Remove redundant dev_err_probe()
2026-07-25 2:11 ` Doug Anderson
@ 2026-07-30 21:17 ` Doug Anderson
2026-07-31 7:15 ` Luca Ceresoli
0 siblings, 1 reply; 18+ messages in thread
From: Doug Anderson @ 2026-07-30 21:17 UTC (permalink / raw)
To: Pan Chuang
Cc: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, Luca Ceresoli, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
open list:DRM DRIVERS, open list
Hi,
On Fri, Jul 24, 2026 at 7:11 PM Doug Anderson <dianders@chromium.org> wrote:
>
> Hi,
>
> On Thu, Jul 23, 2026 at 6:17 AM Pan Chuang <panchuang@vivo.com> wrote:
> >
> > Since commit
> > 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"),
> > devm_request_threaded_irq() automatically logs detailed error messages on
> > failure. Remove the now-redundant driver-specific dev_err_probe() call.
> >
> > Signed-off-by: Pan Chuang <panchuang@vivo.com>
> > ---
> > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
>
> I'll plan to apply this to drm-misc-next in ~1 week unless anything comes up.
Pushed to drm-misc-next:
[10/10] drm/bridge: ti-sn65dsi86: Remove redundant dev_err_probe()
commit: 9c950822f0fa923ccd344d7a143872d25efe89a3
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 00/10] drm/bridge: Remove redundant error messages on IRQ request failure
2026-07-23 14:30 ` [PATCH 00/10] drm/bridge: Remove redundant error messages on IRQ request failure Luca Ceresoli
@ 2026-07-31 7:12 ` Luca Ceresoli
0 siblings, 0 replies; 18+ messages in thread
From: Luca Ceresoli @ 2026-07-31 7:12 UTC (permalink / raw)
To: Luca Ceresoli, Pan Chuang
Cc: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Inki Dae,
Jagan Teki, Marek Szyprowski, Andy Yan, Douglas Anderson,
Damon Ding, Dmitry Baryshkov, Heiko Stuebner, Tomi Valkeinen,
Harikrishna Shenoy, Jayesh Choudhary, Kees Cook, dri-devel,
linux-kernel
Hello Pan,
On Thu Jul 23, 2026 at 4:30 PM CEST, Luca Ceresoli wrote:
> On Thu, 23 Jul 2026 21:16:32 +0800, Pan Chuang <panchuang@vivo.com> wrote:
>> drm/bridge: Remove redundant error messages on IRQ request failure
>>
>> Commit 55b48e23f5c4 ("genirq/devres: Add error handling in
>> devm_request_*_irq()") added automatic error logging to
>> devm_request_threaded_irq() and devm_request_any_context_irq()
>> via the new devm_request_result() helper, which prints device
>> name, IRQ number, handler functions, and error code on failure.
>>
>> [...]
>
> Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
And:
Tested-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
I plan to apply the series (except patch 10, already applied) next week if
there are no objections.
Luca
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 10/10] drm/bridge: ti-sn65dsi86: Remove redundant dev_err_probe()
2026-07-30 21:17 ` Doug Anderson
@ 2026-07-31 7:15 ` Luca Ceresoli
2026-07-31 14:43 ` Doug Anderson
0 siblings, 1 reply; 18+ messages in thread
From: Luca Ceresoli @ 2026-07-31 7:15 UTC (permalink / raw)
To: Doug Anderson, Pan Chuang
Cc: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, Luca Ceresoli, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
open list:DRM DRIVERS, open list
Hi Doug,
On Thu Jul 30, 2026 at 11:17 PM CEST, Doug Anderson wrote:
> Hi,
>
> On Fri, Jul 24, 2026 at 7:11 PM Doug Anderson <dianders@chromium.org> wrote:
>>
>> Hi,
>>
>> On Thu, Jul 23, 2026 at 6:17 AM Pan Chuang <panchuang@vivo.com> wrote:
>> >
>> > Since commit
>> > 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"),
>> > devm_request_threaded_irq() automatically logs detailed error messages on
>> > failure. Remove the now-redundant driver-specific dev_err_probe() call.
>> >
>> > Signed-off-by: Pan Chuang <panchuang@vivo.com>
>> > ---
>> > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 2 +-
>> > 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> Reviewed-by: Douglas Anderson <dianders@chromium.org>
>>
>> I'll plan to apply this to drm-misc-next in ~1 week unless anything comes up.
>
> Pushed to drm-misc-next:
>
> [10/10] drm/bridge: ti-sn65dsi86: Remove redundant dev_err_probe()
> commit: 9c950822f0fa923ccd344d7a143872d25efe89a3
Out of curiosity, did you apply using b4?
I see the commit does not have the R-by I gave to the cover letter a few
days ago, and assumed b4 would pick it up as it does when applying the full
series. If my assumption was wrong, maybe it's an issue to report to the b4
project?
Luca
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 10/10] drm/bridge: ti-sn65dsi86: Remove redundant dev_err_probe()
2026-07-31 7:15 ` Luca Ceresoli
@ 2026-07-31 14:43 ` Doug Anderson
0 siblings, 0 replies; 18+ messages in thread
From: Doug Anderson @ 2026-07-31 14:43 UTC (permalink / raw)
To: Luca Ceresoli
Cc: Pan Chuang, Andrzej Hajda, Neil Armstrong, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter, open list:DRM DRIVERS, open list
Hi,
On Fri, Jul 31, 2026 at 12:16 AM Luca Ceresoli
<luca.ceresoli@bootlin.com> wrote:
>
> Hi Doug,
>
> On Thu Jul 30, 2026 at 11:17 PM CEST, Doug Anderson wrote:
> > Hi,
> >
> > On Fri, Jul 24, 2026 at 7:11 PM Doug Anderson <dianders@chromium.org> wrote:
> >>
> >> Hi,
> >>
> >> On Thu, Jul 23, 2026 at 6:17 AM Pan Chuang <panchuang@vivo.com> wrote:
> >> >
> >> > Since commit
> >> > 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"),
> >> > devm_request_threaded_irq() automatically logs detailed error messages on
> >> > failure. Remove the now-redundant driver-specific dev_err_probe() call.
> >> >
> >> > Signed-off-by: Pan Chuang <panchuang@vivo.com>
> >> > ---
> >> > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 2 +-
> >> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> Reviewed-by: Douglas Anderson <dianders@chromium.org>
> >>
> >> I'll plan to apply this to drm-misc-next in ~1 week unless anything comes up.
> >
> > Pushed to drm-misc-next:
> >
> > [10/10] drm/bridge: ti-sn65dsi86: Remove redundant dev_err_probe()
> > commit: 9c950822f0fa923ccd344d7a143872d25efe89a3
>
> Out of curiosity, did you apply using b4?
>
> I see the commit does not have the R-by I gave to the cover letter a few
> days ago, and assumed b4 would pick it up as it does when applying the full
> series. If my assumption was wrong, maybe it's an issue to report to the b4
> project?
Oops, sorry about that. I actually found your response to the cover
later as I continued to work through my inbox backlog, but I had
already pushed the patch. :( I was also surprised that b4 hadn't
picked it up...
I applied w/
b4 am -P_ 20260723131649.134127-11-panchuang@vivo.com
Running it again still doesn't find your review:
$ b4 am -P_ 20260723131649.134127-11-panchuang@vivo.com
Grabbing thread from
lore.kernel.org/all/20260723131649.134127-11-panchuang@vivo.com/t.mbox.gz
Analyzing 4 messages in the thread
Looking for additional code-review trailers on lore.kernel.org
Analyzing 16 code-review messages
Checking attestation on all messages, may take a moment...
---
✓ [PATCH 10/10] drm/bridge: ti-sn65dsi86: Remove redundant dev_err_probe()
✓ Signed: DKIM/vivo.com
+ Reviewed-by: Douglas Anderson <dianders@chromium.org> (✓
DKIM/chromium.org)
---
NOTE: install patatt for end-to-end signature verification
---
Total patches: 1 (cherrypicked: <20260723131649.134127-11-panchuang@vivo.com>)
---
Link: https://lore.kernel.org/r/20260723131649.134127-11-panchuang@vivo.com
Ah, if I don't do the "-P_" then it finds your tags, but I don't know
of a way to pick up just one patch other than that... Even "b4 am -t
-P_" doesn't find your tags... I guess that's by design?
-Doug
^ permalink raw reply [flat|nested] 18+ messages in thread
end of thread, other threads:[~2026-07-31 14:50 UTC | newest]
Thread overview: 18+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-23 13:16 [PATCH 00/10] drm/bridge: Remove redundant error messages on IRQ request failure Pan Chuang
2026-07-23 13:16 ` [PATCH 01/10] drm/bridge: analogix_dp: Remove redundant dev_err() Pan Chuang
2026-07-24 1:14 ` Damon Ding
2026-07-23 13:16 ` [PATCH 02/10] drm/bridge: cdns-mhdp8546: " Pan Chuang
2026-07-23 13:16 ` [PATCH 03/10] drm/bridge: lt9611: " Pan Chuang
2026-07-23 13:16 ` [PATCH 04/10] drm/bridge: samsung-dsim: " Pan Chuang
2026-07-23 13:16 ` [PATCH 05/10] drm/bridge: synopsys: dw-dp: Remove redundant dev_err_probe() Pan Chuang
2026-07-23 13:16 ` [PATCH 06/10] drm/bridge: tc358767: Remove redundant dev_err() Pan Chuang
2026-07-23 13:16 ` [PATCH 07/10] drm/bridge: it6505: " Pan Chuang
2026-07-23 13:16 ` [PATCH 08/10] drm/bridge/sii8620: Remove redundant dev_err_probe() Pan Chuang
2026-07-23 13:16 ` [PATCH 09/10] drm/bridge: ti-sn65dsi83: " Pan Chuang
2026-07-23 13:16 ` [PATCH 10/10] drm/bridge: ti-sn65dsi86: " Pan Chuang
2026-07-25 2:11 ` Doug Anderson
2026-07-30 21:17 ` Doug Anderson
2026-07-31 7:15 ` Luca Ceresoli
2026-07-31 14:43 ` Doug Anderson
2026-07-23 14:30 ` [PATCH 00/10] drm/bridge: Remove redundant error messages on IRQ request failure Luca Ceresoli
2026-07-31 7:12 ` Luca Ceresoli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox