[PATCH RESEND] powerpc/configs: enable CONFIG_RAS to fix EDAC support

[PATCH RESEND] powerpc/configs: enable CONFIG_RAS to fix EDAC support

[Michael Walle]

Before commit e3c4ff6d8c94 ("EDAC: Remove EDAC_MM_EDAC") EDAC_MM_EDAC
selected RAS, after that commit, EDAC depends on RAS, but nobody enables
it. Enable it in the config again.

Fixes: e3c4ff6d8c94 ("EDAC: Remove EDAC_MM_EDAC")
Signed-off-by: Michael Walle <mwalle@kernel.org>
---
I've missed the EDAC-CORE maintainers before. I addressed Borislav,
but it (apparently) had a stale mail address and there is no mailmap
entry. Hopefully, the patch will reach the right people now.

 arch/powerpc/configs/85xx-hw.config | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/powerpc/configs/85xx-hw.config b/arch/powerpc/configs/85xx-hw.config
index 2b19c20a9a2c..6b8471810143 100644
--- a/arch/powerpc/configs/85xx-hw.config
+++ b/arch/powerpc/configs/85xx-hw.config
@@ -90,6 +90,7 @@ CONFIG_PPC_EPAPR_HV_BYTECHAN=y
 CONFIG_QE_GPIO=y
 CONFIG_QUICC_ENGINE=y
 CONFIG_RAPIDIO=y
+CONFIG_RAS=y
 CONFIG_RTC_CLASS=y
 CONFIG_RTC_DRV_CMOS=y
 CONFIG_RTC_DRV_DS1307=y
-- 
2.47.3

Re: [PATCH RESEND] powerpc/configs: enable CONFIG_RAS to fix EDAC support

[Borislav Petkov]

On Thu, Jul 30, 2026 at 12:52:18PM +0200, Michael Walle wrote:
> Before commit e3c4ff6d8c94 ("EDAC: Remove EDAC_MM_EDAC") EDAC_MM_EDAC
> selected RAS, after that commit, EDAC depends on RAS, but nobody enables
> it. Enable it in the config again.

I have no clue what you're trying to do but forcing RAS=y in that config
better have a real good reason why.

Oh and we cannot support CONFIG_EDAC_MPC85XX anymore due to lack of hw:

https://git.kernel.org/pub/scm/linux/kernel/git/ras/ras.git/commit/?h=edac-misc&id=749c5102487b558cc7d73961a6d0da2fceaa022d

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

Re: [PATCH RESEND] powerpc/configs: enable CONFIG_RAS to fix EDAC support

[Michael Walle]

On Thu Jul 30, 2026 at 8:56 PM CEST, Borislav Petkov wrote:
> On Thu, Jul 30, 2026 at 12:52:18PM +0200, Michael Walle wrote:
>> Before commit e3c4ff6d8c94 ("EDAC: Remove EDAC_MM_EDAC") EDAC_MM_EDAC
>> selected RAS, after that commit, EDAC depends on RAS, but nobody enables
>> it. Enable it in the config again.
>
> I have no clue what you're trying to do but forcing RAS=y in that config
> better have a real good reason why.

I don't get what you are trying to say. CONFIG_EDAC_MPC85XX is
enabled in the that config already. It's just that the mentioned
commit broke it because it removed the "select RAS", while
EDAC depends on it. So yeah, up to that commit it was always
enabled in that particular config.

> Oh and we cannot support CONFIG_EDAC_MPC85XX anymore due to lack of hw:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/ras/ras.git/commit/?h=edac-misc&id=749c5102487b558cc7d73961a6d0da2fceaa022d

Still, it's already enabled in that config and it somewhat recently
got IMX9 support, so I guess NXP is interested in keeping it.

That being said, I have the hardware, but right now I don't have
much time personally. The best I could do is "Odd Fixes". (I also
have two pending patches for that edac driver, yet to be posted to
the ML).

-michael

Re: [PATCH RESEND] powerpc/configs: enable CONFIG_RAS to fix EDAC support

[Borislav Petkov]

On Thu, Jul 30, 2026 at 10:35:20PM +0200, Michael Walle wrote:
> I don't get what you are trying to say. CONFIG_EDAC_MPC85XX is
> enabled in the that config already.

You mean, *because* CONFIG_EDAC_MPC85XX is =y, then RAS=y? I guess that is
true for this particular config.

> It's just that the mentioned commit broke it because it removed the "select
> RAS", while EDAC depends on it.

No, that commit dropped a select statement which is good in its own right.

> Still, it's already enabled in that config and it somewhat recently
> got IMX9 support,

Who got IMX9 support?

> so I guess NXP is interested in keeping it.

I have not heard anything.

> That being said, I have the hardware, but right now I don't have
> much time personally. 

Welcome to the club. :-)

> The best I could do is "Odd Fixes". (I also have two pending patches for
> that edac driver, yet to be posted to the ML).

That driver is orphaned and no one maintains it now. You would be the only one
who is using it.

I can pick up well tested patches tho.

:-)


-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

Re: [PATCH RESEND] powerpc/configs: enable CONFIG_RAS to fix EDAC support

[Madhavan Srinivasan]

On 7/31/26 2:05 AM, Michael Walle wrote:
> On Thu Jul 30, 2026 at 8:56 PM CEST, Borislav Petkov wrote:
>> On Thu, Jul 30, 2026 at 12:52:18PM +0200, Michael Walle wrote:
>>> Before commit e3c4ff6d8c94 ("EDAC: Remove EDAC_MM_EDAC") EDAC_MM_EDAC
>>> selected RAS, after that commit, EDAC depends on RAS, but nobody enables
>>> it. Enable it in the config again.
>> I have no clue what you're trying to do but forcing RAS=y in that config
>> better have a real good reason why.
> I don't get what you are trying to say. CONFIG_EDAC_MPC85XX is
> enabled in the that config already. It's just that the mentioned
> commit broke it because it removed the "select RAS", while
> EDAC depends on it. So yeah, up to that commit it was always
> enabled in that particular config.
>
>> Oh and we cannot support CONFIG_EDAC_MPC85XX anymore due to lack of hw:
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/ras/ras.git/commit/?h=edac-misc&id=749c5102487b558cc7d73961a6d0da2fceaa022d
> Still, it's already enabled in that config and it somewhat recently
> got IMX9 support, so I guess NXP is interested in keeping it.
>
> That being said, I have the hardware, but right now I don't have
> much time personally. The best I could do is "Odd Fixes". (I also
> have two pending patches for that edac driver, yet to be posted to
> the ML).
I dont have hardware to test this config change and currently platform is
in odd fixes anyway. I can take it via ppc tree but definitely need 
community
help for testing fixes in future.
Maddy
> -michael

Re: [PATCH RESEND] powerpc/configs: enable CONFIG_RAS to fix EDAC support

[Michael Walle]

[-- Attachment #1: Type: text/plain, Size: 1926 bytes --]

On Fri Jul 31, 2026 at 4:28 AM CEST, Borislav Petkov wrote:
> On Thu, Jul 30, 2026 at 10:35:20PM +0200, Michael Walle wrote:
>> I don't get what you are trying to say. CONFIG_EDAC_MPC85XX is
>> enabled in the that config already.
>
> You mean, *because* CONFIG_EDAC_MPC85XX is =y, then RAS=y? I guess that is
> true for this particular config.

No. CONFIG_RAS is not set although CONFIG_EDAC_MPC85XX is set.
Because CONFIG_RAS was *automatically* selected before the mentioned
commit.

>> It's just that the mentioned commit broke it because it removed the "select
>> RAS", while EDAC depends on it.
>
> No, that commit dropped a select statement which is good in its own right.

And while doing that it will break (at least) the corenet32_smp_defconfig,
because it removes the "select RAS" (which was on the EDAC_MM_EDAC symbol).

How would that work without adding CONFIG_RAS=y to the defconfigs
where EDAC (or rather EDAC_MM_EDAC) is enabled?

Here's a quick test:

git checkout e3c4ff6d8c94

# remove "default y" from PCIEAER, because that is also selecting
# RAS. But it was removed in 8c8ff55b4da7 ("PCI/AER: Don't select
# CONFIG_PCIEAER by default").
sed -i "/default y/d" drivers/pci/pcie/aer/Kconfig

ARCH=powerpc make corenet32_smp_defconfig
grep CONFIG_EDAC .config # no CONFIG_EDAC, nor CONFIG_EDAC_MPC85XX

git revert e3c4ff6d8c94
grep CONFIG_EDAC .config

You see, before that commit, the driver was actually enabled, and
after that commit it is not.

I'm really not sure what I still have to show you that you agree,
that it's a regression.

>> Still, it's already enabled in that config and it somewhat recently
>> got IMX9 support,
>
> Who got IMX9 support?

Disregard that, I was confused, it's in the fsl_ddr_edac.c (which is
shared between EDAC_LAYERSCAPE and EDAC_MPC85XX).

..

> I can pick up well tested patches tho.

Good to hear.

-michael

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 297 bytes --]

Re: [PATCH RESEND] powerpc/configs: enable CONFIG_RAS to fix EDAC support

[Borislav Petkov]

On Mon, Aug 10, 2026 at 10:10:43AM +0200, Michael Walle wrote:
> No. CONFIG_RAS is not set although CONFIG_EDAC_MPC85XX is set.
> Because CONFIG_RAS was *automatically* selected before the mentioned
> commit.

Dude, I'm agreeing with you!

> And while doing that it will break (at least) the corenet32_smp_defconfig,
> because it removes the "select RAS" (which was on the EDAC_MM_EDAC symbol).

And things like that are fixed by adjusting the config. Basically your patch.

So whoever picks it up, can add:

Acked-by: Borislav Petkov (AMD) <bp@alien8.de>

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

Re: [PATCH RESEND] powerpc/configs: enable CONFIG_RAS to fix EDAC support

[Michael Walle]

[-- Attachment #1: Type: text/plain, Size: 619 bytes --]

On Mon Aug 10, 2026 at 3:50 PM CEST, Borislav Petkov wrote:
>> And while doing that it will break (at least) the corenet32_smp_defconfig,
>> because it removes the "select RAS" (which was on the EDAC_MM_EDAC symbol).
>
> And things like that are fixed by adjusting the config. Basically your patch.
>
> So whoever picks it up, can add:
>
> Acked-by: Borislav Petkov (AMD) <bp@alien8.de>

Thanks! Christophe already pointed out [1] that it should go via the
same tree as the commit it fixed, i.e. the EDAC tree.

-michael

[1] https://lore.kernel.org/all/1500e19d-9bd3-4050-8568-31b546f0b22e@kernel.org/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 297 bytes --]

Re: [PATCH RESEND] powerpc/configs: enable CONFIG_RAS to fix EDAC support

[Borislav Petkov]

On Mon, Aug 10, 2026 at 04:03:17PM +0200, Michael Walle wrote:
> Thanks! Christophe already pointed out [1] that it should go via the
> same tree as the commit it fixed, i.e. the EDAC tree.

./scripts/get_maintainer.pl -f arch/powerpc/configs/85xx-hw.config
Madhavan Srinivasan <maddy@linux.ibm.com> (maintainer:LINUX FOR POWERPC (32-BIT AND 64-BIT))

and he said on that thread he'd pick it up.

But I can take it too if PPC people agree on who takes it.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette