* [patch 07/10] mtd/amd_flash: replace schedule_timeout() with msleep()
@ 2004-11-20 2:34 janitor
2004-11-20 12:59 ` David Woodhouse
0 siblings, 1 reply; 2+ messages in thread
From: janitor @ 2004-11-20 2:34 UTC (permalink / raw)
To: akpm; +Cc: linux-kernel, janitor, nacc
Any comments would be appreciated.
Description: Use msleep() instead of schedule_timeout()
to guarantee the task delays as expected.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
Signed-off-by: Maximilian Attems <janitor@sternwelten.at>
---
linux-2.6.10-rc2-bk4-max/drivers/mtd/chips/amd_flash.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
diff -puN drivers/mtd/chips/amd_flash.c~msleep-drivers_mtd_chips_amd_flash drivers/mtd/chips/amd_flash.c
--- linux-2.6.10-rc2-bk4/drivers/mtd/chips/amd_flash.c~msleep-drivers_mtd_chips_amd_flash 2004-11-19 17:15:31.000000000 +0100
+++ linux-2.6.10-rc2-bk4-max/drivers/mtd/chips/amd_flash.c 2004-11-19 17:15:31.000000000 +0100
@@ -1122,7 +1122,7 @@ retry:
timeo = jiffies + (HZ * 20);
spin_unlock_bh(chip->mutex);
- schedule_timeout(HZ);
+ msleep(1000);
spin_lock_bh(chip->mutex);
while (flash_is_busy(map, adr, private->interleave)) {
_
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch 07/10] mtd/amd_flash: replace schedule_timeout() with msleep()
2004-11-20 2:34 [patch 07/10] mtd/amd_flash: replace schedule_timeout() with msleep() janitor
@ 2004-11-20 12:59 ` David Woodhouse
0 siblings, 0 replies; 2+ messages in thread
From: David Woodhouse @ 2004-11-20 12:59 UTC (permalink / raw)
To: janitor; +Cc: akpm, linux-kernel, nacc
On Sat, 2004-11-20 at 03:34 +0100, janitor@sternwelten.at wrote:
>
>
> Any comments would be appreciated.
>
> Description: Use msleep() instead of schedule_timeout()
> to guarantee the task delays as expected.
Applied; thanks. Likewise the ones for cfi_cmdset_0002.c and
cfi_cmdset_0020.c. The one for cfi_cmdset_0001.c doesn't apply any more
-- that just uses the cfi_udelay() helper function. So I fixed that too.
All in bk://linux-mtd.bkbits.net/mtd-2.6 and hence should be -mm$NEXT.
--
dwmw2
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-11-20 13:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-11-20 2:34 [patch 07/10] mtd/amd_flash: replace schedule_timeout() with msleep() janitor
2004-11-20 12:59 ` David Woodhouse
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox