Re: [usb-storage] Re: [PATCH] usb-storage: Add support for Rio Karma

Re: [usb-storage] Re: [PATCH] usb-storage: Add support for Rio Karma

[Alan Stern]

On Wed, 23 Nov 2005, Bob Copeland wrote:

> --- a/drivers/usb/storage/unusual_devs.h
> +++ b/drivers/usb/storage/unusual_devs.h
> @@ -145,6 +145,13 @@ UNUSUAL_DEV(  0x0451, 0x5416, 0x0100, 0x
>  		US_SC_DEVICE, US_PR_BULK, NULL,
>  		US_FL_NEED_OVERRIDE ),
>  
> +#ifdef CONFIG_USB_STORAGE_KARMA
> +UNUSUAL_DEV(  0x045a, 0x5210, 0x0101, 0x0101,
> +		"Rio",
> +		"Rio Karma",
> +		US_SC_SCSI, US_PR_BULK, rio_karma_init, US_FL_FIX_INQUIRY),

Are you sure you need US_SC_SCSI and US_PR_BULK?  Wouldn't US_SC_DEVICE 
and US_PR_DEVICE be sufficient?

And do you really need US_FL_FIX_INQUIRY?  Hardly any devices do (maybe 
none).

Alan Stern

Re: [usb-storage] Re: [PATCH] usb-storage: Add support for Rio Karma

[Andries Brouwer]

On Wed, Nov 23, 2005 at 01:18:30PM -0500, Alan Stern wrote:

> And do you really need US_FL_FIX_INQUIRY?  Hardly any devices do (maybe 
> none).

This one does:

/* aeb */
UNUSUAL_DEV( 0x090c, 0x1132, 0x0000, 0xffff,
                "Feiya",
                "5-in-1 Card Reader",
                US_SC_DEVICE, US_PR_DEVICE, NULL,
                US_FL_FIX_CAPACITY ),

Andries

Re: [usb-storage] Re: [PATCH] usb-storage: Add support for Rio Karma

[Phil Dibowitz]

[-- Attachment #1: Type: text/plain, Size: 1006 bytes --]

Andries Brouwer wrote:
> On Wed, Nov 23, 2005 at 01:18:30PM -0500, Alan Stern wrote:
> 
> 
>>And do you really need US_FL_FIX_INQUIRY?  Hardly any devices do (maybe 
>>none).
> 
> 
> This one does:
> 
> /* aeb */
> UNUSUAL_DEV( 0x090c, 0x1132, 0x0000, 0xffff,
>                 "Feiya",
>                 "5-in-1 Card Reader",
>                 US_SC_DEVICE, US_PR_DEVICE, NULL,
>                 US_FL_FIX_CAPACITY ),

Can you be more specific? Matthew added some code (specifically a delay)
which should have taken care of most if not all of these a few kernel
versions ago (.12-ish?)...

Are you saying this device still doesn't work for you using the above
entry in a recent kernel?

-- 
Phil Dibowitz                             phil@ipom.com
Freeware and Technical Pages              Insanity Palace of Metallica
http://www.phildev.net/                   http://www.ipom.com/

"Be who you are and say what you feel, because those who mind don't
matter and those who matter don't mind."
 - Dr. Suess


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 256 bytes --]

Re: [usb-storage] Re: [PATCH] usb-storage: Add support for Rio Karma

[Andries Brouwer]

On Wed, Nov 23, 2005 at 08:08:32PM -0800, Phil Dibowitz wrote:

> > UNUSUAL_DEV( 0x090c, 0x1132, 0x0000, 0xffff,
> >                 "Feiya",
> >                 "5-in-1 Card Reader",
> >                 US_SC_DEVICE, US_PR_DEVICE, NULL,
> >                 US_FL_FIX_CAPACITY ),
> 
> Can you be more specific? Matthew added some code (specifically a delay)
> which should have taken care of most if not all of these a few kernel
> versions ago (.12-ish?)...

I don't understand how adding a delay can influence the fact that
it returns the wrong capacity.

Re: [usb-storage] Re: [PATCH] usb-storage: Add support for Rio Karma

[Bob Copeland]

> On Wed, 23 Nov 2005, Bob Copeland wrote:
> > +#ifdef CONFIG_USB_STORAGE_KARMA
> > +UNUSUAL_DEV(  0x045a, 0x5210, 0x0101, 0x0101,
> > +		"Rio",
> > +		"Rio Karma",
> > +		US_SC_SCSI, US_PR_BULK, rio_karma_init, US_FL_FIX_INQUIRY),
> 
> Are you sure you need US_SC_SCSI and US_PR_BULK?  Wouldn't US_SC_DEVICE 
> and US_PR_DEVICE be sufficient?
> 
> And do you really need US_FL_FIX_INQUIRY?  Hardly any devices do (maybe 
> none).

Alan, 

Thanks again for your comments.

The Karma does some rather broken things.  If you look at the dump below you'll
see that a lot of fields are just zeroed out, such as the serial number.  There
are obviously wrong things, e.g. the device class and protocols are zero,  but
the interface class is also zero, which is reserved according to the spec.  The
protocol is interpreted as CBI but there are actually no control or interrupt
endpoints.  Thus US_PR_BULK... and maybe US_SC_SCSI, I'll check that.

I set US_FL_FIX_INQUIRY because I have noticed that, on occasion, the unit
would report itself as being either the USB controller or the disk drive
contained within, so instead of "Rio" it says "HitachiXYZ" or "Cypress," and
the device acts funny.  I can only reproduce this rarely on the device, but I
assumed that this flag would help.

T:  Bus=04 Lev=01 Prnt=01 Port=01 Cnt=01 Dev#=  8 Spd=480 MxCh= 0
D:  Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs=  1
P:  Vendor=045a ProdID=5210 Rev= 1.01
S:  Manufacturer=Rio
S:  Product=Rio Karma
S:  SerialNumber=0000000000000000
C:* #Ifs= 1 Cfg#= 1 Atr=c0 MxPwr=  0mA
I:  If#= 0 Alt= 0 #EPs= 2 Cls=00(>ifc ) Sub=00 Prot=00 Driver=usb-storage
E:  Ad=88(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
E:  Ad=02(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms

I freely admit ignorance on many of the fine points on scsi/usb so please
enlighten me as necessary.

-- 
Bob Copeland %% www.bobcopeland.com