public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* arcmsr: endianness bug
@ 2007-10-29  5:08 Al Viro
  0 siblings, 0 replies; only message in thread
From: Al Viro @ 2007-10-29  5:08 UTC (permalink / raw)
  To: torvalds; +Cc: nick.cheng, linux-kernel, linux-scsi


initializing a field in data shared with the card with
cpu_to_le32(something) | 0x100000 is broken - the field
is, indeed, little-endian and we need cpu_to_le32() on
both parts.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---
 drivers/scsi/arcmsr/arcmsr_hba.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c
index 152af46..acbc50f 100644
--- a/drivers/scsi/arcmsr/arcmsr_hba.c
+++ b/drivers/scsi/arcmsr/arcmsr_hba.c
@@ -932,7 +932,7 @@ static void arcmsr_build_ccb(struct AdapterControlBlock *acb,
 
 				pdma_sg->addresshigh = address_hi;
 				pdma_sg->address = address_lo;
-				pdma_sg->length = length|IS_SG64_ADDR;
+				pdma_sg->length = length|cpu_to_le32(IS_SG64_ADDR);
 				psge += sizeof (struct SG64ENTRY);
 				arccdbsize += sizeof (struct SG64ENTRY);
 			}
-- 
1.5.3.GIT



^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2007-10-29  5:09 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-29  5:08 arcmsr: endianness bug Al Viro

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox