From: Paul Cercueil <paul@crapouillou.net>
To: Qiujun Huang <hqjagain@gmail.com>
Cc: kishon@ti.com, vkoul@kernel.org, zhouyanjie@wanyeetech.com,
aric.pzqi@ingenic.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PHY: Ingenic: compile phy-ingenic-usb only if it was enabled
Date: Sun, 24 Jan 2021 08:36:29 +0000 [thread overview]
Message-ID: <TWJFNQ.UE3BBA1DX3OL@crapouillou.net> (raw)
In-Reply-To: <20210123150146.11208-1-hqjagain@gmail.com>
Hi, thank you for your patch.
Le sam. 23 janv. 2021 à 23:01, Qiujun Huang <hqjagain@gmail.com> a
écrit :
> We should compile this driver only if we opened PHY_INGENIC_USB.
'opened' -> 'enable'.
> Signed-off-by: Qiujun Huang <hqjagain@gmail.com>
You will need to add a Fixes: tag and Cc linux-stable, since the
problem is already in 5.10.
Cheers,
-Paul
> ---
> drivers/phy/ingenic/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/phy/ingenic/Makefile
> b/drivers/phy/ingenic/Makefile
> index 65d5ea00fc9d..a00306651423 100644
> --- a/drivers/phy/ingenic/Makefile
> +++ b/drivers/phy/ingenic/Makefile
> @@ -1,2 +1,2 @@
> # SPDX-License-Identifier: GPL-2.0
> -obj-y += phy-ingenic-usb.o
> +obj-$(PHY_INGENIC_USB) += phy-ingenic-usb.o
> --
> 2.25.1
>
prev parent reply other threads:[~2021-01-24 8:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-23 15:01 [PATCH] PHY: Ingenic: compile phy-ingenic-usb only if it was enabled Qiujun Huang
2021-01-24 8:36 ` Paul Cercueil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=TWJFNQ.UE3BBA1DX3OL@crapouillou.net \
--to=paul@crapouillou.net \
--cc=aric.pzqi@ingenic.com \
--cc=hqjagain@gmail.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vkoul@kernel.org \
--cc=zhouyanjie@wanyeetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox