* [PATCH v1] arm64: dts: qcom: sdm845-db845c: Fix reset-pin of ov8856 node
@ 2020-12-17 15:12 Robert Foss
2020-12-21 3:54 ` Bjorn Andersson
0 siblings, 1 reply; 2+ messages in thread
From: Robert Foss @ 2020-12-17 15:12 UTC (permalink / raw)
To: agross, bjorn.andersson, robh+dt, robert.foss, linux-arm-msm,
devicetree, linux-kernel
Switch reset pin of ov8856 node from GPIO_ACTIVE_HIGH to GPIO_ACTIVE_LOW,
this issue prevented the ov8856 from probing properly as it does not respond
to I2C messages.
Fixes: d4919a44564b ("arm64: dts: qcom: sdm845-db845c: Add ov8856 & ov7251
camera nodes")
Signed-off-by: Robert Foss <robert.foss@linaro.org>
---
arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
index 7cc236575ee2..a943b3f353ce 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
@@ -1112,11 +1112,11 @@ camera@10 {
reg = <0x10>;
// CAM0_RST_N
- reset-gpios = <&tlmm 9 0>;
+ reset-gpios = <&tlmm 9 1>;
pinctrl-names = "default";
pinctrl-0 = <&cam0_default>;
gpios = <&tlmm 13 0>,
- <&tlmm 9 0>;
+ <&tlmm 9 1>;
clocks = <&clock_camcc CAM_CC_MCLK0_CLK>;
clock-names = "xvclk";
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v1] arm64: dts: qcom: sdm845-db845c: Fix reset-pin of ov8856 node
2020-12-17 15:12 [PATCH v1] arm64: dts: qcom: sdm845-db845c: Fix reset-pin of ov8856 node Robert Foss
@ 2020-12-21 3:54 ` Bjorn Andersson
0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Andersson @ 2020-12-21 3:54 UTC (permalink / raw)
To: Robert Foss; +Cc: agross, robh+dt, linux-arm-msm, devicetree, linux-kernel
On Thu 17 Dec 07:12 PST 2020, Robert Foss wrote:
> Switch reset pin of ov8856 node from GPIO_ACTIVE_HIGH to GPIO_ACTIVE_LOW,
> this issue prevented the ov8856 from probing properly as it does not respond
> to I2C messages.
>
> Fixes: d4919a44564b ("arm64: dts: qcom: sdm845-db845c: Add ov8856 & ov7251
> camera nodes")
>
> Signed-off-by: Robert Foss <robert.foss@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
> index 7cc236575ee2..a943b3f353ce 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
> @@ -1112,11 +1112,11 @@ camera@10 {
> reg = <0x10>;
>
> // CAM0_RST_N
> - reset-gpios = <&tlmm 9 0>;
> + reset-gpios = <&tlmm 9 1>;
Please do use GPIO_ACTIVE_LOW as the argument...
Regards,
Bjorn
> pinctrl-names = "default";
> pinctrl-0 = <&cam0_default>;
> gpios = <&tlmm 13 0>,
> - <&tlmm 9 0>;
> + <&tlmm 9 1>;
>
> clocks = <&clock_camcc CAM_CC_MCLK0_CLK>;
> clock-names = "xvclk";
> --
> 2.27.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-12-21 4:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-17 15:12 [PATCH v1] arm64: dts: qcom: sdm845-db845c: Fix reset-pin of ov8856 node Robert Foss
2020-12-21 3:54 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox