From: Andrew Lunn <andrew@lunn.ch>
To: "A. Sverdlin" <alexander.sverdlin@siemens.com>
Cc: Wei Fang <wei.fang@nxp.com>, Shenwei Wang <shenwei.wang@nxp.com>,
Clark Wang <xiaoning.wang@nxp.com>,
NXP Linux Team <linux-imx@nxp.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: fec: Defer probe if other FEC has deferred MDIO
Date: Thu, 9 Feb 2023 01:55:40 +0100 [thread overview]
Message-ID: <Y+REjDdjHkv4g45o@lunn.ch> (raw)
In-Reply-To: <20230208101821.871269-1-alexander.sverdlin@siemens.com>
> - if ((fep->quirks & FEC_QUIRK_SINGLE_MDIO) && fep->dev_id > 0) {
> + if (fep->quirks & FEC_QUIRK_SINGLE_MDIO) {
> /* fec1 uses fec0 mii_bus */
> if (mii_cnt && fec0_mii_bus) {
> fep->mii_bus = fec0_mii_bus;
> mii_cnt++;
> return 0;
> }
> - return -ENOENT;
Could you not add an else clause here? return -EPROBE_DEFFER?
Basically, if fec0 has not probed, deffer the probing of fec1?
Andrew
next prev parent reply other threads:[~2023-02-09 0:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 10:18 [PATCH] net: fec: Defer probe if other FEC has deferred MDIO A. Sverdlin
2023-02-09 0:55 ` Andrew Lunn [this message]
2023-02-09 7:27 ` Sverdlin, Alexander
2023-02-09 9:17 ` Wei Fang
2023-02-09 10:10 ` Sverdlin, Alexander
2023-02-09 13:35 ` Andrew Lunn
2023-02-09 14:14 ` Sverdlin, Alexander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+REjDdjHkv4g45o@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexander.sverdlin@siemens.com \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shenwei.wang@nxp.com \
--cc=wei.fang@nxp.com \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox