The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: "Sverdlin, Alexander" <alexander.sverdlin@siemens.com>
To: "andrew@lunn.ch" <andrew@lunn.ch>
Cc: "wei.fang@nxp.com" <wei.fang@nxp.com>,
	"xiaoning.wang@nxp.com" <xiaoning.wang@nxp.com>,
	"shenwei.wang@nxp.com" <shenwei.wang@nxp.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-imx@nxp.com" <linux-imx@nxp.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: fec: Defer probe if other FEC has deferred MDIO
Date: Thu, 9 Feb 2023 14:14:33 +0000	[thread overview]
Message-ID: <e3497a4b2b690d0b946601f2eae7779bac772555.camel@siemens.com> (raw)
In-Reply-To: <Y+T2oku3ocAuafe0@lunn.ch>

Hello Andrew,

On Thu, 2023-02-09 at 14:35 +0100, Andrew Lunn wrote:
> > You are right, there is unfortunately no i.MX8 support in the
> > upstream
> > tree, so it's not possible to reproduce anything.
> 
> commit 947240ebcc635ab063f17ba027352c3a474d2438
> Author: Fugang Duan <fugang.duan@nxp.com>
> Date:   Wed Jul 28 19:51:59 2021 +0800
> 
>     net: fec: add imx8mq and imx8qm new versions support
>     
>     The ENET of imx8mq and imx8qm are basically the same as imx6sx,
>     but they have new features support based on imx6sx, like:
>     - imx8mq: supports IEEE 802.3az EEE standard.
>     - imx8qm: supports RGMII mode delayed clock.
> 
> Are you using some other imx8 SoC?

I'm referring to imx8qxp/imx8dxp and my "git diff --stat" shows
that upstream has only 9% of LoCs used to boot this SoC.
There is a bit more than just Ethernet in it...

I however believe that my patch preserved the legacy behavior, in
DT-less cases and cases with only one of the two FEC ports enabled
in DT. But I can maintain the patch locally as well if there
is no interest to this fix.

-- 
Alexander Sverdlin
Siemens AG
www.siemens.com

      reply	other threads:[~2023-02-09 14:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-08 10:18 [PATCH] net: fec: Defer probe if other FEC has deferred MDIO A. Sverdlin
2023-02-09  0:55 ` Andrew Lunn
2023-02-09  7:27   ` Sverdlin, Alexander
2023-02-09  9:17     ` Wei Fang
2023-02-09 10:10       ` Sverdlin, Alexander
2023-02-09 13:35         ` Andrew Lunn
2023-02-09 14:14           ` Sverdlin, Alexander [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e3497a4b2b690d0b946601f2eae7779bac772555.camel@siemens.com \
    --to=alexander.sverdlin@siemens.com \
    --cc=andrew@lunn.ch \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=shenwei.wang@nxp.com \
    --cc=wei.fang@nxp.com \
    --cc=xiaoning.wang@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox