From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Bartosz Golaszewski <brgl@bgdev.pl>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v1 1/2] gpiolib: of: Prepare of_mm_gpiochip_add_data() for fwnode
Date: Thu, 10 Nov 2022 15:56:44 +0200 [thread overview]
Message-ID: <Y20DHLQiRU3i7UTC@smile.fi.intel.com> (raw)
In-Reply-To: <Y2wZYuadSwbqxpge@google.com>
On Wed, Nov 09, 2022 at 01:19:30PM -0800, Dmitry Torokhov wrote:
> On Wed, Nov 09, 2022 at 05:07:33PM +0200, Andy Shevchenko wrote:
...
> > - of_node_put(mm_gc->gc.of_node);
> > - mm_gc->gc.of_node = of_node_get(np);
> > + fwnode_handle_put(mm_gc->gc.fwnode);
> > + mm_gc->gc.fwnode = fwnode_handle_get(fwnode);
>
> Can we reduce the patch to
>
> fwnode_handle_put(mm_gc->gc.fwnode);
> mm_gc->gc.fwnode = fwnode_handle_get(of_fwnode_handle(np));
>
> ?
Sure. As Linus pointed out, it's anyway temporary.
> I do not see a reason for converting the rest of invocations to fwnode
> given that this is clearly an OF API.
...which should go away.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-11-10 13:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-09 15:07 [PATCH v1 1/2] gpiolib: of: Prepare of_mm_gpiochip_add_data() for fwnode Andy Shevchenko
2022-11-09 15:07 ` [PATCH v1 2/2] gpiolib: of: Drop redundant check in of_mm_gpiochip_remove() Andy Shevchenko
2022-11-09 21:13 ` Dmitry Torokhov
2022-11-09 15:16 ` [PATCH v1 1/2] gpiolib: of: Prepare of_mm_gpiochip_add_data() for fwnode Andy Shevchenko
2022-11-09 21:19 ` Dmitry Torokhov
2022-11-10 13:56 ` Andy Shevchenko [this message]
2022-11-10 10:11 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y20DHLQiRU3i7UTC@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=brgl@bgdev.pl \
--cc=dmitry.torokhov@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox