* [PATCH -next] firmware: google: fix a NULL vs IS_ERR() check in cbmem_entry_probe()
@ 2022-11-15 9:11 Peng Wu
2022-11-15 13:52 ` Guenter Roeck
2022-11-15 17:01 ` Jack Rosenthal
0 siblings, 2 replies; 3+ messages in thread
From: Peng Wu @ 2022-11-15 9:11 UTC (permalink / raw)
To: jwerner, jrosenth, gregkh, groeck; +Cc: linux-kernel, liwei391, Peng Wu
The devm_memremap() function returns error pointers on error,
it doesn't return NULL.
Fixes: 19d54020883c ("firmware: google: Implement cbmem in sysfs driver")
Signed-off-by: Peng Wu <wupeng58@huawei.com>
---
drivers/firmware/google/cbmem.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/firmware/google/cbmem.c b/drivers/firmware/google/cbmem.c
index 685f3070ce9d..88e587ba1e0d 100644
--- a/drivers/firmware/google/cbmem.c
+++ b/drivers/firmware/google/cbmem.c
@@ -106,8 +106,8 @@ static int cbmem_entry_probe(struct coreboot_device *dev)
entry->mem_file_buf = devm_memremap(&dev->dev, dev->cbmem_entry.address,
dev->cbmem_entry.entry_size,
MEMREMAP_WB);
- if (!entry->mem_file_buf)
- return -ENOMEM;
+ if (IS_ERR(entry->mem_file_buf))
+ return PTR_ERR(entry->mem_file_buf);
entry->size = dev->cbmem_entry.entry_size;
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH -next] firmware: google: fix a NULL vs IS_ERR() check in cbmem_entry_probe()
2022-11-15 9:11 [PATCH -next] firmware: google: fix a NULL vs IS_ERR() check in cbmem_entry_probe() Peng Wu
@ 2022-11-15 13:52 ` Guenter Roeck
2022-11-15 17:01 ` Jack Rosenthal
1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2022-11-15 13:52 UTC (permalink / raw)
To: Peng Wu; +Cc: jwerner, jrosenth, gregkh, groeck, linux-kernel, liwei391
On Tue, Nov 15, 2022 at 1:14 AM Peng Wu <wupeng58@huawei.com> wrote:
>
> The devm_memremap() function returns error pointers on error,
> it doesn't return NULL.
>
> Fixes: 19d54020883c ("firmware: google: Implement cbmem in sysfs driver")
> Signed-off-by: Peng Wu <wupeng58@huawei.com>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
> ---
> drivers/firmware/google/cbmem.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/firmware/google/cbmem.c b/drivers/firmware/google/cbmem.c
> index 685f3070ce9d..88e587ba1e0d 100644
> --- a/drivers/firmware/google/cbmem.c
> +++ b/drivers/firmware/google/cbmem.c
> @@ -106,8 +106,8 @@ static int cbmem_entry_probe(struct coreboot_device *dev)
> entry->mem_file_buf = devm_memremap(&dev->dev, dev->cbmem_entry.address,
> dev->cbmem_entry.entry_size,
> MEMREMAP_WB);
> - if (!entry->mem_file_buf)
> - return -ENOMEM;
> + if (IS_ERR(entry->mem_file_buf))
> + return PTR_ERR(entry->mem_file_buf);
>
> entry->size = dev->cbmem_entry.entry_size;
>
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] firmware: google: fix a NULL vs IS_ERR() check in cbmem_entry_probe()
2022-11-15 9:11 [PATCH -next] firmware: google: fix a NULL vs IS_ERR() check in cbmem_entry_probe() Peng Wu
2022-11-15 13:52 ` Guenter Roeck
@ 2022-11-15 17:01 ` Jack Rosenthal
1 sibling, 0 replies; 3+ messages in thread
From: Jack Rosenthal @ 2022-11-15 17:01 UTC (permalink / raw)
To: Peng Wu; +Cc: jwerner, gregkh, groeck, linux-kernel, liwei391
On 2022-11-15 at 09:11 +0000, Peng Wu wrote:
> The devm_memremap() function returns error pointers on error,
> it doesn't return NULL.
>
> Fixes: 19d54020883c ("firmware: google: Implement cbmem in sysfs driver")
> Signed-off-by: Peng Wu <wupeng58@huawei.com>
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
> ---
> drivers/firmware/google/cbmem.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/firmware/google/cbmem.c b/drivers/firmware/google/cbmem.c
> index 685f3070ce9d..88e587ba1e0d 100644
> --- a/drivers/firmware/google/cbmem.c
> +++ b/drivers/firmware/google/cbmem.c
> @@ -106,8 +106,8 @@ static int cbmem_entry_probe(struct coreboot_device *dev)
> entry->mem_file_buf = devm_memremap(&dev->dev, dev->cbmem_entry.address,
> dev->cbmem_entry.entry_size,
> MEMREMAP_WB);
> - if (!entry->mem_file_buf)
> - return -ENOMEM;
> + if (IS_ERR(entry->mem_file_buf))
> + return PTR_ERR(entry->mem_file_buf);
>
> entry->size = dev->cbmem_entry.entry_size;
>
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-15 17:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-15 9:11 [PATCH -next] firmware: google: fix a NULL vs IS_ERR() check in cbmem_entry_probe() Peng Wu
2022-11-15 13:52 ` Guenter Roeck
2022-11-15 17:01 ` Jack Rosenthal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox