From: Lee Jones <lee@kernel.org>
To: Martin Botka <martin.botka@somainline.org>
Cc: martin.botka1@gmail.com, ~postmarketos/upstreaming@lists.sr.ht,
Konrad Dybcio <konrad.dybcio@somainline.org>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@somainline.org>,
Marijn Suijten <marijn.suijten@somainline.org>,
Jami Kettunen <jamipkettunen@somainline.org>,
Paul Bouchara <paul.bouchara@somainline.org>,
Yenda <jtrmal@gmail.com>, Chen-Yu Tsai <wens@csie.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] mfd: ax20x: Add suppport for AXP1530 PMIC
Date: Wed, 16 Nov 2022 15:49:07 +0000 [thread overview]
Message-ID: <Y3UGc//UuuinJcbE@google.com> (raw)
In-Reply-To: <20221114162334.1801137-1-martin.botka@somainline.org>
On Mon, 14 Nov 2022, Martin Botka wrote:
> AXP1530 is a PMIC chip produced by X-Powers and an be connected via
> I2C or RSB bus.
> Where AXP313A seems to be closely related so the same driver can be used and
> seen it only paired with H616 SoC.
>
> Signed-off-by: Martin Botka <martin.botka@somainline.org>
> ---
> drivers/mfd/axp20x-i2c.c | 2 ++
> drivers/mfd/axp20x-rsb.c | 1 +
> drivers/mfd/axp20x.c | 63 ++++++++++++++++++++++++++++++++++++++
> include/linux/mfd/axp20x.h | 34 ++++++++++++++++++++
> 4 files changed, 100 insertions(+)
No major concerns.
> +static struct mfd_cell axp1530_cells[] = {
> + {
> + .id = 0,
> + .name = "axp20x-regulator",
> + },
> +};
Why .id = 0?
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2022-11-16 15:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-14 16:23 [PATCH 1/2] mfd: ax20x: Add suppport for AXP1530 PMIC Martin Botka
2022-11-14 16:27 ` Martin Botka
2022-11-16 15:49 ` Lee Jones [this message]
2022-11-16 21:07 ` Martin Botka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3UGc//UuuinJcbE@google.com \
--to=lee@kernel.org \
--cc=angelogioacchino.delregno@somainline.org \
--cc=jamipkettunen@somainline.org \
--cc=jtrmal@gmail.com \
--cc=konrad.dybcio@somainline.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=martin.botka1@gmail.com \
--cc=martin.botka@somainline.org \
--cc=paul.bouchara@somainline.org \
--cc=wens@csie.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox