* [PATCH] drm/i915: Fix documentation for intel_uncore_forcewake_put__locked
@ 2022-12-07 11:29 Miaoqian Lin
2022-12-07 16:00 ` Rodrigo Vivi
0 siblings, 1 reply; 2+ messages in thread
From: Miaoqian Lin @ 2022-12-07 11:29 UTC (permalink / raw)
To: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, Tvrtko Ursulin,
David Airlie, Daniel Vetter, Chris Wilson, intel-gfx, dri-devel,
linux-kernel
Cc: linmq006
intel_uncore_forcewake_put__locked() is used to release a reference.
Fixes: a6111f7b6604 ("drm/i915: Reduce locking in execlist command submission")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
drivers/gpu/drm/i915/intel_uncore.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c
index 5cd423c7b646..acb40543eb32 100644
--- a/drivers/gpu/drm/i915/intel_uncore.c
+++ b/drivers/gpu/drm/i915/intel_uncore.c
@@ -819,9 +819,9 @@ void intel_uncore_forcewake_flush(struct intel_uncore *uncore,
}
/**
- * intel_uncore_forcewake_put__locked - grab forcewake domain references
+ * intel_uncore_forcewake_put__locked - release forcewake domain references
* @uncore: the intel_uncore structure
- * @fw_domains: forcewake domains to get reference on
+ * @fw_domains: forcewake domains to put references
*
* See intel_uncore_forcewake_put(). This variant places the onus
* on the caller to explicitly handle the dev_priv->uncore.lock spinlock.
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/i915: Fix documentation for intel_uncore_forcewake_put__locked
2022-12-07 11:29 [PATCH] drm/i915: Fix documentation for intel_uncore_forcewake_put__locked Miaoqian Lin
@ 2022-12-07 16:00 ` Rodrigo Vivi
0 siblings, 0 replies; 2+ messages in thread
From: Rodrigo Vivi @ 2022-12-07 16:00 UTC (permalink / raw)
To: Miaoqian Lin
Cc: Jani Nikula, Joonas Lahtinen, Tvrtko Ursulin, David Airlie,
Daniel Vetter, Chris Wilson, intel-gfx, dri-devel, linux-kernel
On Wed, Dec 07, 2022 at 03:29:09PM +0400, Miaoqian Lin wrote:
> intel_uncore_forcewake_put__locked() is used to release a reference.
>
> Fixes: a6111f7b6604 ("drm/i915: Reduce locking in execlist command submission")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
and will push this right now...
> ---
> drivers/gpu/drm/i915/intel_uncore.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c
> index 5cd423c7b646..acb40543eb32 100644
> --- a/drivers/gpu/drm/i915/intel_uncore.c
> +++ b/drivers/gpu/drm/i915/intel_uncore.c
> @@ -819,9 +819,9 @@ void intel_uncore_forcewake_flush(struct intel_uncore *uncore,
> }
>
> /**
> - * intel_uncore_forcewake_put__locked - grab forcewake domain references
> + * intel_uncore_forcewake_put__locked - release forcewake domain references
> * @uncore: the intel_uncore structure
> - * @fw_domains: forcewake domains to get reference on
> + * @fw_domains: forcewake domains to put references
> *
> * See intel_uncore_forcewake_put(). This variant places the onus
> * on the caller to explicitly handle the dev_priv->uncore.lock spinlock.
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-12-07 16:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-07 11:29 [PATCH] drm/i915: Fix documentation for intel_uncore_forcewake_put__locked Miaoqian Lin
2022-12-07 16:00 ` Rodrigo Vivi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox