* [PATCH] mfd: rohm-bd9576: convert to i2c's .probe_new()
@ 2022-11-21 10:24 Uwe Kleine-König
2022-11-21 11:33 ` Matti Vaittinen
2022-12-08 12:37 ` Lee Jones
0 siblings, 2 replies; 3+ messages in thread
From: Uwe Kleine-König @ 2022-11-21 10:24 UTC (permalink / raw)
To: Matti Vaittinen, Lee Jones; +Cc: linux-kernel, kernel
The probe function doesn't make use of the i2c_device_id * parameter so
it can be trivially converted.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/mfd/rohm-bd9576.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/mfd/rohm-bd9576.c b/drivers/mfd/rohm-bd9576.c
index f37cd4f27aeb..c854ab5bcd80 100644
--- a/drivers/mfd/rohm-bd9576.c
+++ b/drivers/mfd/rohm-bd9576.c
@@ -88,8 +88,7 @@ static struct regmap_irq_chip bd9576_irq_chip = {
.irq_reg_stride = 1,
};
-static int bd957x_i2c_probe(struct i2c_client *i2c,
- const struct i2c_device_id *id)
+static int bd957x_i2c_probe(struct i2c_client *i2c)
{
int ret;
struct regmap *regmap;
@@ -180,7 +179,7 @@ static struct i2c_driver bd957x_drv = {
.name = "rohm-bd957x",
.of_match_table = bd957x_of_match,
},
- .probe = &bd957x_i2c_probe,
+ .probe_new = &bd957x_i2c_probe,
};
module_i2c_driver(bd957x_drv);
--
2.38.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] mfd: rohm-bd9576: convert to i2c's .probe_new()
2022-11-21 10:24 [PATCH] mfd: rohm-bd9576: convert to i2c's .probe_new() Uwe Kleine-König
@ 2022-11-21 11:33 ` Matti Vaittinen
2022-12-08 12:37 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Matti Vaittinen @ 2022-11-21 11:33 UTC (permalink / raw)
To: Uwe Kleine-König, Lee Jones; +Cc: linux-kernel, kernel
Thanks Uwe!
On 11/21/22 12:24, Uwe Kleine-König wrote:
> The probe function doesn't make use of the i2c_device_id * parameter so
> it can be trivially converted.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Matti Vaittinen <mazziesaccount@gmail.com>
> ---
> drivers/mfd/rohm-bd9576.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mfd/rohm-bd9576.c b/drivers/mfd/rohm-bd9576.c
> index f37cd4f27aeb..c854ab5bcd80 100644
> --- a/drivers/mfd/rohm-bd9576.c
> +++ b/drivers/mfd/rohm-bd9576.c
> @@ -88,8 +88,7 @@ static struct regmap_irq_chip bd9576_irq_chip = {
> .irq_reg_stride = 1,
> };
>
> -static int bd957x_i2c_probe(struct i2c_client *i2c,
> - const struct i2c_device_id *id)
> +static int bd957x_i2c_probe(struct i2c_client *i2c)
> {
> int ret;
> struct regmap *regmap;
> @@ -180,7 +179,7 @@ static struct i2c_driver bd957x_drv = {
> .name = "rohm-bd957x",
> .of_match_table = bd957x_of_match,
> },
> - .probe = &bd957x_i2c_probe,
> + .probe_new = &bd957x_i2c_probe,
> };
> module_i2c_driver(bd957x_drv);
>
--
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland
~~ When things go utterly wrong vim users can always type :help! ~~
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mfd: rohm-bd9576: convert to i2c's .probe_new()
2022-11-21 10:24 [PATCH] mfd: rohm-bd9576: convert to i2c's .probe_new() Uwe Kleine-König
2022-11-21 11:33 ` Matti Vaittinen
@ 2022-12-08 12:37 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Lee Jones @ 2022-12-08 12:37 UTC (permalink / raw)
To: Uwe Kleine-König; +Cc: Matti Vaittinen, linux-kernel, kernel
On Mon, 21 Nov 2022, Uwe Kleine-König wrote:
> The probe function doesn't make use of the i2c_device_id * parameter so
> it can be trivially converted.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/mfd/rohm-bd9576.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-12-08 12:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-21 10:24 [PATCH] mfd: rohm-bd9576: convert to i2c's .probe_new() Uwe Kleine-König
2022-11-21 11:33 ` Matti Vaittinen
2022-12-08 12:37 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox