The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Dalvin Aiguobas <pharcodra@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	outreachy@lists.linux.dev
Subject: Re: [PATCH] staging: wlan-ng: fix checkpatch error for spinlock
Date: Sun, 11 Dec 2022 12:33:30 +0100	[thread overview]
Message-ID: <Y5XACri80rFeamVy@kroah.com> (raw)
In-Reply-To: <Y5W5nKtLMV9b4xnm@kroah.com>

On Sun, Dec 11, 2022 at 12:06:04PM +0100, Greg Kroah-Hartman wrote:
> On Sun, Dec 11, 2022 at 11:56:49AM +0100, Dalvin Aiguobas wrote:
> > Checkpatch Styleproblem fixed by adding comment.
> > 
> > Signed-off-by: Dalvin <pharcodra@gmail.com>
> > ---
> >  drivers/staging/wlan-ng/hfa384x.h | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
> > index 0611e37df6ac..ad117d570bb6 100644
> > --- a/drivers/staging/wlan-ng/hfa384x.h
> > +++ b/drivers/staging/wlan-ng/hfa384x.h
> > @@ -1171,6 +1171,7 @@ struct hfa384x_usbctlx {
> >  };
> >  
> >  struct hfa384x_usbctlxq {
> > +	/* lock: Protect structure fields */

Also, does this comment really make sense?  To properly document a lock
takes a bit more text, if you read this would it help out in
understanding the code any?

thanks,

greg k-h

      reply	other threads:[~2022-12-11 11:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-11 10:56 [PATCH] staging: wlan-ng: fix checkpatch error for spinlock Dalvin Aiguobas
2022-12-11 11:06 ` Greg Kroah-Hartman
2022-12-11 11:33   ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y5XACri80rFeamVy@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=outreachy@lists.linux.dev \
    --cc=pharcodra@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox