From: Mark Brown <broonie@kernel.org>
To: Rouven Czerwinski <r.czerwinski@pengutronix.de>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
kernel@pengutronix.de, Marco Felsch <m.felsch@pengutronix.de>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ASoC: max98088: fix initial dai mute state
Date: Tue, 13 Dec 2022 12:01:45 +0000 [thread overview]
Message-ID: <Y5hpqWH2WuSIUHil@sirena.org.uk> (raw)
In-Reply-To: <20221213095328.122309-2-r.czerwinski@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 953 bytes --]
On Tue, Dec 13, 2022 at 10:53:28AM +0100, Rouven Czerwinski wrote:
> To fix that we need to explicit set the mute state. Now the first
> playback request gets played correctly.
> +++ b/sound/soc/codecs/max98088.c
> @@ -1710,6 +1710,11 @@ static int max98088_probe(struct snd_soc_component *component)
> snd_soc_component_write(component, M98088_REG_1E_DAI2_IOCFG,
> M98088_S2NORMAL|M98088_SDATA);
>
> + snd_soc_component_update_bits(component, M98088_REG_2F_LVL_DAI1_PLAY,
> + M98088_DAI_MUTE_MASK, M98088_DAI_MUTE);
> + snd_soc_component_update_bits(component, M98088_REG_31_LVL_DAI2_PLAY,
> + M98088_DAI_MUTE_MASK, M98088_DAI_MUTE);
> +
Won't this be broken again after suspend? The device gets powered off
over suspend, then when it powers on again with the output unmuted
nothing will do another write since the register is already in the state
in the cache.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-12-13 12:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-13 9:53 [PATCH 1/2] ASoC: max98088: fix dai1/2_hw_params access Rouven Czerwinski
2022-12-13 9:53 ` [PATCH 2/2] ASoC: max98088: fix initial dai mute state Rouven Czerwinski
2022-12-13 12:01 ` Mark Brown [this message]
2022-12-15 9:17 ` Marco Felsch
2022-12-15 12:00 ` Mark Brown
2022-12-13 12:04 ` [PATCH 1/2] ASoC: max98088: fix dai1/2_hw_params access Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5hpqWH2WuSIUHil@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=kernel@pengutronix.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=perex@perex.cz \
--cc=r.czerwinski@pengutronix.de \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox