From: Mark Brown <broonie@kernel.org>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: Rouven Czerwinski <r.czerwinski@pengutronix.de>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
kernel@pengutronix.de, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ASoC: max98088: fix initial dai mute state
Date: Thu, 15 Dec 2022 12:00:45 +0000 [thread overview]
Message-ID: <Y5sMbQZix760NH4T@sirena.org.uk> (raw)
In-Reply-To: <20221215091747.xn3f7ecrwoc7ssyo@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 785 bytes --]
On Thu, Dec 15, 2022 at 10:17:47AM +0100, Marco Felsch wrote:
> On 22-12-13, Mark Brown wrote:
> > > + snd_soc_component_update_bits(component, M98088_REG_2F_LVL_DAI1_PLAY,
> > > + M98088_DAI_MUTE_MASK, M98088_DAI_MUTE);
> > > + snd_soc_component_update_bits(component, M98088_REG_31_LVL_DAI2_PLAY,
> > > + M98088_DAI_MUTE_MASK, M98088_DAI_MUTE);
> > > +
> > Won't this be broken again after suspend? The device gets powered off
> > over suspend, then when it powers on again with the output unmuted
> > nothing will do another write since the register is already in the state
> > in the cache.
> I didn't found any suspend logic within the driver. Is this handled
> within the ASoC core?
Register save and restore for the device won't be.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-12-15 12:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-13 9:53 [PATCH 1/2] ASoC: max98088: fix dai1/2_hw_params access Rouven Czerwinski
2022-12-13 9:53 ` [PATCH 2/2] ASoC: max98088: fix initial dai mute state Rouven Czerwinski
2022-12-13 12:01 ` Mark Brown
2022-12-15 9:17 ` Marco Felsch
2022-12-15 12:00 ` Mark Brown [this message]
2022-12-13 12:04 ` [PATCH 1/2] ASoC: max98088: fix dai1/2_hw_params access Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5sMbQZix760NH4T@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=kernel@pengutronix.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=perex@perex.cz \
--cc=r.czerwinski@pengutronix.de \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox