From: Stephan Gerhold <stephan@gerhold.net>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Richard Acayan <mailingradian@gmail.com>,
Vinod Koul <vkoul@kernel.org>,
krishna Lanka <quic_vamslank@quicinc.com>,
Iskren Chernev <me@iskren.info>,
Martin Botka <martin.botka@somainline.org>,
Abel Vesa <abel.vesa@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/7] dt-bindings: pinctrl: qcom,msm8909: correct GPIO name pattern and example
Date: Wed, 1 Feb 2023 16:47:17 +0100 [thread overview]
Message-ID: <Y9qJheoYYCOnk1DO@gerhold.net> (raw)
In-Reply-To: <20230201153019.269718-2-krzysztof.kozlowski@linaro.org>
On Wed, Feb 01, 2023 at 04:30:14PM +0100, Krzysztof Kozlowski wrote:
> The MSM8909 TLMM pin controller has GPIOs 0-112, so narrow the pattern
> and gpio-ranges in the example.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Not sure if people care about Fixes tags for DT schema but this patch
definitely
Fixes: c249ec7ba1b1 ("dt-bindings: pinctrl: Add DT schema for qcom,msm8909-tlmm")
I have no idea what I was thinking when I used 117 instead of 113...
Thanks a lot for finding and fixing this!
Reviewed-by: Stephan Gerhold <stephan@gerhold.net>
> ---
> .../devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml
> index 449e6e34be61..85082adc1811 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml
> @@ -63,7 +63,7 @@ $defs:
> subnode.
> items:
> oneOf:
> - - pattern: "^gpio([0-9]|[1-9][0-9]|10[0-9]|11[0-7])$"
> + - pattern: "^gpio([0-9]|[1-9][0-9]|10[0-9]|11[0-2])$"
> - enum: [ sdc1_clk, sdc1_cmd, sdc1_data, sdc2_clk, sdc2_cmd,
> sdc2_data, qdsd_clk, qdsd_cmd, qdsd_data0, qdsd_data1,
> qdsd_data2, qdsd_data3 ]
> @@ -127,7 +127,7 @@ examples:
> interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>;
> gpio-controller;
> #gpio-cells = <2>;
> - gpio-ranges = <&tlmm 0 0 117>;
> + gpio-ranges = <&tlmm 0 0 113>;
> interrupt-controller;
> #interrupt-cells = <2>;
>
> --
> 2.34.1
>
next prev parent reply other threads:[~2023-02-01 15:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 15:30 [PATCH 1/7] dt-bindings: pinctrl: qcom,msm8226: correct GPIO name pattern Krzysztof Kozlowski
2023-02-01 15:30 ` [PATCH 2/7] dt-bindings: pinctrl: qcom,msm8909: correct GPIO name pattern and example Krzysztof Kozlowski
2023-02-01 15:47 ` Stephan Gerhold [this message]
2023-02-01 15:30 ` [PATCH 3/7] dt-bindings: pinctrl: qcom,sm6375: " Krzysztof Kozlowski
2023-02-01 15:30 ` [PATCH 4/7] dt-bindings: pinctrl: qcom,msm8953: correct GPIO name pattern Krzysztof Kozlowski
2023-02-01 15:30 ` [PATCH 5/7] dt-bindings: pinctrl: qcom,sdx55: " Krzysztof Kozlowski
2023-02-01 15:30 ` [PATCH 6/7] dt-bindings: pinctrl: qcom,msm8994: correct number of GPIOs Krzysztof Kozlowski
2023-02-01 15:30 ` [PATCH 7/7] dt-bindings: pinctrl: qcom: correct gpio-ranges in examples Krzysztof Kozlowski
2023-02-01 16:07 ` Stephan Gerhold
2023-02-01 16:31 ` Stephan Gerhold
2023-02-02 9:38 ` Krzysztof Kozlowski
2023-02-02 10:39 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9qJheoYYCOnk1DO@gerhold.net \
--to=stephan@gerhold.net \
--cc=abel.vesa@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailingradian@gmail.com \
--cc=martin.botka@somainline.org \
--cc=me@iskren.info \
--cc=quic_vamslank@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox