public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Stephan Gerhold <stephan@gerhold.net>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Richard Acayan <mailingradian@gmail.com>,
	Vinod Koul <vkoul@kernel.org>,
	krishna Lanka <quic_vamslank@quicinc.com>,
	Iskren Chernev <me@iskren.info>,
	Martin Botka <martin.botka@somainline.org>,
	Abel Vesa <abel.vesa@linaro.org>,
	linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 7/7] dt-bindings: pinctrl: qcom: correct gpio-ranges in examples
Date: Wed, 1 Feb 2023 17:31:26 +0100	[thread overview]
Message-ID: <Y9qT3vNTcuT+njIR@gerhold.net> (raw)
In-Reply-To: <Y9qORcPIuq4IZcL1@gerhold.net>

On Wed, Feb 01, 2023 at 05:07:40PM +0100, Stephan Gerhold wrote:
> On Wed, Feb 01, 2023 at 04:30:19PM +0100, Krzysztof Kozlowski wrote:
> > Correct the number of GPIOs in gpio-ranges to match reality.
> > 
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> AFAICT the current gpio-ranges do match the number of GPIOs (ngpios) in
> the pinctrl drivers for all/most of the platforms you update below. It
> looks like the special UFS_RESET pins are also exported as GPIOs in
> addition to the real GPIOs. I'm not sure if this is intended or a
> mistake.
> 

It looks like this is on purpose:

---
From 53a5372ce326116f3e3d3f1d701113b2542509f4 Mon Sep 17 00:00:00 2001
From: Bjorn Andersson <bjorn.andersson@linaro.org>
Date: Tue, 4 Jun 2019 00:19:59 -0700
Subject: [PATCH] pinctrl: qcom: sdm845: Expose ufs_reset as gpio

The ufs_reset pin is expected to be wired to the reset pin of the
primary UFS memory but is pretty much just a general purpose output pinr

Reorder the pins and expose it as gpio 150, so that the UFS driver can
toggle it.
---

And it's used in sdm845-mtp.dts:

&ufs_mem_hc {
	reset-gpios = <&tlmm 150 GPIO_ACTIVE_LOW>;
};

So I think this patch (together with the DT ones you sent) should be
dropped because it would prevent using the UFS_RESET as GPIO since it's
no longer included in gpio-ranges.

Thanks,
Stephan

  reply	other threads:[~2023-02-01 16:31 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-01 15:30 [PATCH 1/7] dt-bindings: pinctrl: qcom,msm8226: correct GPIO name pattern Krzysztof Kozlowski
2023-02-01 15:30 ` [PATCH 2/7] dt-bindings: pinctrl: qcom,msm8909: correct GPIO name pattern and example Krzysztof Kozlowski
2023-02-01 15:47   ` Stephan Gerhold
2023-02-01 15:30 ` [PATCH 3/7] dt-bindings: pinctrl: qcom,sm6375: " Krzysztof Kozlowski
2023-02-01 15:30 ` [PATCH 4/7] dt-bindings: pinctrl: qcom,msm8953: correct GPIO name pattern Krzysztof Kozlowski
2023-02-01 15:30 ` [PATCH 5/7] dt-bindings: pinctrl: qcom,sdx55: " Krzysztof Kozlowski
2023-02-01 15:30 ` [PATCH 6/7] dt-bindings: pinctrl: qcom,msm8994: correct number of GPIOs Krzysztof Kozlowski
2023-02-01 15:30 ` [PATCH 7/7] dt-bindings: pinctrl: qcom: correct gpio-ranges in examples Krzysztof Kozlowski
2023-02-01 16:07   ` Stephan Gerhold
2023-02-01 16:31     ` Stephan Gerhold [this message]
2023-02-02  9:38       ` Krzysztof Kozlowski
2023-02-02 10:39   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y9qT3vNTcuT+njIR@gerhold.net \
    --to=stephan@gerhold.net \
    --cc=abel.vesa@linaro.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mailingradian@gmail.com \
    --cc=martin.botka@somainline.org \
    --cc=me@iskren.info \
    --cc=quic_vamslank@quicinc.com \
    --cc=robh+dt@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox