* [PATCH] workqueue: Use %s instead of function name
@ 2021-01-23 8:04 Stephen Zhang
2021-01-27 14:43 ` Tejun Heo
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Zhang @ 2021-01-23 8:04 UTC (permalink / raw)
To: tj, jiangshanlai; +Cc: linux-kernel, Stephen Zhang
It is better to replace the function name with %s, in case the function
name changes.
Signed-off-by: Stephen Zhang <stephenzhangzsd@gmail.com>
---
kernel/workqueue.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index 9880b6c..8b1b616 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -2964,8 +2964,8 @@ void drain_workqueue(struct workqueue_struct *wq)
if (++flush_cnt == 10 ||
(flush_cnt % 100 == 0 && flush_cnt <= 1000))
- pr_warn("workqueue %s: drain_workqueue() isn't complete after %u tries\n",
- wq->name, flush_cnt);
+ pr_warn("workqueue %s: %s() isn't complete after %u tries\n",
+ wq->name, __func__, flush_cnt);
mutex_unlock(&wq->mutex);
goto reflush;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] workqueue: Use %s instead of function name
2021-01-23 8:04 [PATCH] workqueue: Use %s instead of function name Stephen Zhang
@ 2021-01-27 14:43 ` Tejun Heo
0 siblings, 0 replies; 2+ messages in thread
From: Tejun Heo @ 2021-01-27 14:43 UTC (permalink / raw)
To: Stephen Zhang; +Cc: jiangshanlai, linux-kernel
On Sat, Jan 23, 2021 at 04:04:00PM +0800, Stephen Zhang wrote:
> It is better to replace the function name with %s, in case the function
> name changes.
>
> Signed-off-by: Stephen Zhang <stephenzhangzsd@gmail.com>
Applied to wq/for-5.12.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-27 14:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-23 8:04 [PATCH] workqueue: Use %s instead of function name Stephen Zhang
2021-01-27 14:43 ` Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox