linux-5.10.11 build failure

linux-5.10.11 build failure

[Chris Clayton]

Hi,

Building 5.10.11 fails on my (x86-64) laptop thusly:

..

 AS      arch/x86/entry/thunk_64.o
  CC      arch/x86/entry/vsyscall/vsyscall_64.o
  AS      arch/x86/realmode/rm/header.o
  CC      arch/x86/mm/pat/set_memory.o
  CC      arch/x86/events/amd/core.o
  CC      arch/x86/kernel/fpu/init.o
  CC      arch/x86/entry/vdso/vma.o
  CC      kernel/sched/core.o
arch/x86/entry/thunk_64.o: warning: objtool: missing symbol for insn at offset 0x3e

  AS      arch/x86/realmode/rm/trampoline_64.o
make[2]: *** [scripts/Makefile.build:360: arch/x86/entry/thunk_64.o] Error 255
make[2]: *** Deleting file 'arch/x86/entry/thunk_64.o'
make[2]: *** Waiting for unfinished jobs....

..

Compiler is latest snapshot of gcc-10.

Happy to test the fix but please cc me as I'm not subscribed


Thanks,

Chris

Re: linux-5.10.11 build failure

[Greg Kroah-Hartman]

On Thu, Jan 28, 2021 at 09:17:10AM +0000, Chris Clayton wrote:
> Hi,
> 
> Building 5.10.11 fails on my (x86-64) laptop thusly:
> 
> ..
> 
>  AS      arch/x86/entry/thunk_64.o
>   CC      arch/x86/entry/vsyscall/vsyscall_64.o
>   AS      arch/x86/realmode/rm/header.o
>   CC      arch/x86/mm/pat/set_memory.o
>   CC      arch/x86/events/amd/core.o
>   CC      arch/x86/kernel/fpu/init.o
>   CC      arch/x86/entry/vdso/vma.o
>   CC      kernel/sched/core.o
> arch/x86/entry/thunk_64.o: warning: objtool: missing symbol for insn at offset 0x3e
> 
>   AS      arch/x86/realmode/rm/trampoline_64.o
> make[2]: *** [scripts/Makefile.build:360: arch/x86/entry/thunk_64.o] Error 255
> make[2]: *** Deleting file 'arch/x86/entry/thunk_64.o'
> make[2]: *** Waiting for unfinished jobs....
> 
> ..
> 
> Compiler is latest snapshot of gcc-10.
> 
> Happy to test the fix but please cc me as I'm not subscribed

Can you do 'git bisect' to track down the offending commit?

And what exact gcc version are you using?

thanks,

greg k-h

Re: linux-5.10.11 build failure

[Bhaskar Chowdhury]

[-- Attachment #1: Type: text/plain, Size: 1504 bytes --]

On 10:34 Thu 28 Jan 2021, Greg Kroah-Hartman wrote:
>On Thu, Jan 28, 2021 at 09:17:10AM +0000, Chris Clayton wrote:
>> Hi,
>>
>> Building 5.10.11 fails on my (x86-64) laptop thusly:
>>
>> ..
>>
>>  AS      arch/x86/entry/thunk_64.o
>>   CC      arch/x86/entry/vsyscall/vsyscall_64.o
>>   AS      arch/x86/realmode/rm/header.o
>>   CC      arch/x86/mm/pat/set_memory.o
>>   CC      arch/x86/events/amd/core.o
>>   CC      arch/x86/kernel/fpu/init.o
>>   CC      arch/x86/entry/vdso/vma.o
>>   CC      kernel/sched/core.o
>> arch/x86/entry/thunk_64.o: warning: objtool: missing symbol for insn at offset 0x3e
>>
>>   AS      arch/x86/realmode/rm/trampoline_64.o
>> make[2]: *** [scripts/Makefile.build:360: arch/x86/entry/thunk_64.o] Error 255
>> make[2]: *** Deleting file 'arch/x86/entry/thunk_64.o'
>> make[2]: *** Waiting for unfinished jobs....
>>
>> ..
>>
>> Compiler is latest snapshot of gcc-10.
>>
>> Happy to test the fix but please cc me as I'm not subscribed
>
>Can you do 'git bisect' to track down the offending commit?
>
>And what exact gcc version are you using?
>
>thanks,
>
>greg k-h


Okay, as far as the kernel goes ...I have built the 5.10.11 kernel on 5
different distros (Gentoo, Slackware, Debian, Arch and Opensuse-Tumbleweed)
from yesterday ...simple compile with little option tweak ..nothing breaks.

Probably, good fortune of mine! :)

There is "Pathetically and awfully wrote" mundane bash script do the stuff for
me.

~Bhaskar

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-5.10.11 build failure

[Chris Clayton]

On 28/01/2021 09:34, Greg Kroah-Hartman wrote:
> On Thu, Jan 28, 2021 at 09:17:10AM +0000, Chris Clayton wrote:
>> Hi,
>>
>> Building 5.10.11 fails on my (x86-64) laptop thusly:
>>
>> ..
>>
>>  AS      arch/x86/entry/thunk_64.o
>>   CC      arch/x86/entry/vsyscall/vsyscall_64.o
>>   AS      arch/x86/realmode/rm/header.o
>>   CC      arch/x86/mm/pat/set_memory.o
>>   CC      arch/x86/events/amd/core.o
>>   CC      arch/x86/kernel/fpu/init.o
>>   CC      arch/x86/entry/vdso/vma.o
>>   CC      kernel/sched/core.o
>> arch/x86/entry/thunk_64.o: warning: objtool: missing symbol for insn at offset 0x3e
>>
>>   AS      arch/x86/realmode/rm/trampoline_64.o
>> make[2]: *** [scripts/Makefile.build:360: arch/x86/entry/thunk_64.o] Error 255
>> make[2]: *** Deleting file 'arch/x86/entry/thunk_64.o'
>> make[2]: *** Waiting for unfinished jobs....
>>
>> ..
>>
>> Compiler is latest snapshot of gcc-10.
>>
>> Happy to test the fix but please cc me as I'm not subscribed
> 
> Can you do 'git bisect' to track down the offending commit?
> 

Sure, but I'll hold that request for a while. I updated to binutils-2.36 on Monday and I'm pretty sure that is a feature
of this build fail. I've reverted binutils to 2.35.1, and the build succeeds. Updated to 2.36 again and, surprise,
surprise, the kernel build fails again.

I've had a glance at the binutils ML and there are all sorts of issues being reported, but it's beyond my knowledge to
assess if this build error is related to any of them.

I'll stick with binutils-2.35.1 for the time being.

> And what exact gcc version are you using?
>

 It's built from the 10-20210123 snapshot tarball.

I can report this to the binutils folks, but might it be better if the objtool maintainer looks at it first? The
binutils change might just have opened the gate to a bug in objtool.

> thanks,
> 
> greg k-h
> 

Thanks.

Chris

Re: linux-5.10.11 build failure

[torvic9]

Maybe you need something like this: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?h=x86/entry&id=5e6dca82bcaa49348f9e5fcb48df4881f6d6c4ae

Greetings,
Tor

Re: linux-5.10.11 build failure

[Thomas Backlund]

Den 28.1.2021 kl. 12:05, skrev Chris Clayton:
> 
> On 28/01/2021 09:34, Greg Kroah-Hartman wrote:
>> On Thu, Jan 28, 2021 at 09:17:10AM +0000, Chris Clayton wrote:
>>> Hi,
>>>
>>> Building 5.10.11 fails on my (x86-64) laptop thusly:
>>>
>>> ..
>>>
>>>   AS      arch/x86/entry/thunk_64.o
>>>    CC      arch/x86/entry/vsyscall/vsyscall_64.o
>>>    AS      arch/x86/realmode/rm/header.o
>>>    CC      arch/x86/mm/pat/set_memory.o
>>>    CC      arch/x86/events/amd/core.o
>>>    CC      arch/x86/kernel/fpu/init.o
>>>    CC      arch/x86/entry/vdso/vma.o
>>>    CC      kernel/sched/core.o
>>> arch/x86/entry/thunk_64.o: warning: objtool: missing symbol for insn at offset 0x3e
>>>
>>>    AS      arch/x86/realmode/rm/trampoline_64.o
>>> make[2]: *** [scripts/Makefile.build:360: arch/x86/entry/thunk_64.o] Error 255
>>> make[2]: *** Deleting file 'arch/x86/entry/thunk_64.o'
>>> make[2]: *** Waiting for unfinished jobs....
>>>
>>> ..
>>>
>>> Compiler is latest snapshot of gcc-10.
>>>
>>> Happy to test the fix but please cc me as I'm not subscribed
>>
>> Can you do 'git bisect' to track down the offending commit?
>>
> 
> Sure, but I'll hold that request for a while. I updated to binutils-2.36 on Monday and I'm pretty sure that is a feature
> of this build fail. I've reverted binutils to 2.35.1, and the build succeeds. Updated to 2.36 again and, surprise,
> surprise, the kernel build fails again.
> 
> I've had a glance at the binutils ML and there are all sorts of issues being reported, but it's beyond my knowledge to
> assess if this build error is related to any of them.
> 
> I'll stick with binutils-2.35.1 for the time being.
> 
>> And what exact gcc version are you using?
>>
> 
>   It's built from the 10-20210123 snapshot tarball.
> 
> I can report this to the binutils folks, but might it be better if the objtool maintainer looks at it first? The
> binutils change might just have opened the gate to a bug in objtool.
> 
>> thanks,
>>
>> greg k-h
>>
> 


AFAIK you need this in stable trees:

 From 1d489151e9f9d1647110277ff77282fe4d96d09b Mon Sep 17 00:00:00 2001
From: Josh Poimboeuf <jpoimboe@redhat.com>
Date: Thu, 14 Jan 2021 16:14:01 -0600
Subject: [PATCH] objtool: Don't fail on missing symbol table


--
Thomas

Re: linux-5.10.11 build failure

[Chris Clayton]

Thanks, Thomas.

On 28/01/2021 11:24, Thomas Backlund wrote:
> Den 28.1.2021 kl. 12:05, skrev Chris Clayton:
>>
>> On 28/01/2021 09:34, Greg Kroah-Hartman wrote:
>>> On Thu, Jan 28, 2021 at 09:17:10AM +0000, Chris Clayton wrote:
>>>> Hi,
>>>>
>>>> Building 5.10.11 fails on my (x86-64) laptop thusly:
>>>>
>>>> ..
>>>>
>>>>   AS      arch/x86/entry/thunk_64.o
>>>>    CC      arch/x86/entry/vsyscall/vsyscall_64.o
>>>>    AS      arch/x86/realmode/rm/header.o
>>>>    CC      arch/x86/mm/pat/set_memory.o
>>>>    CC      arch/x86/events/amd/core.o
>>>>    CC      arch/x86/kernel/fpu/init.o
>>>>    CC      arch/x86/entry/vdso/vma.o
>>>>    CC      kernel/sched/core.o
>>>> arch/x86/entry/thunk_64.o: warning: objtool: missing symbol for insn at offset 0x3e
>>>>
>>>>    AS      arch/x86/realmode/rm/trampoline_64.o
>>>> make[2]: *** [scripts/Makefile.build:360: arch/x86/entry/thunk_64.o] Error 255
>>>> make[2]: *** Deleting file 'arch/x86/entry/thunk_64.o'
>>>> make[2]: *** Waiting for unfinished jobs....
>>>>
>>>> ..
>>>>
>>>> Compiler is latest snapshot of gcc-10.
>>>>
>>>> Happy to test the fix but please cc me as I'm not subscribed
>>>
>>> Can you do 'git bisect' to track down the offending commit?
>>>
>>
>> Sure, but I'll hold that request for a while. I updated to binutils-2.36 on Monday and I'm pretty sure that is a feature
>> of this build fail. I've reverted binutils to 2.35.1, and the build succeeds. Updated to 2.36 again and, surprise,
>> surprise, the kernel build fails again.
>>
>> I've had a glance at the binutils ML and there are all sorts of issues being reported, but it's beyond my knowledge to
>> assess if this build error is related to any of them.
>>
>> I'll stick with binutils-2.35.1 for the time being.
>>
>>> And what exact gcc version are you using?
>>>
>>
>>   It's built from the 10-20210123 snapshot tarball.
>>
>> I can report this to the binutils folks, but might it be better if the objtool maintainer looks at it first? The
>> binutils change might just have opened the gate to a bug in objtool.
>>
>>> thanks,
>>>
>>> greg k-h
>>>
>>
> 
> 
> AFAIK you need this in stable trees:
> 
>  From 1d489151e9f9d1647110277ff77282fe4d96d09b Mon Sep 17 00:00:00 2001
> From: Josh Poimboeuf <jpoimboe@redhat.com>
> Date: Thu, 14 Jan 2021 16:14:01 -0600
> Subject: [PATCH] objtool: Don't fail on missing symbol table
> 
> 

That may be the caae, but it doesn't fix the build failure I've reported in this thread. However, as suggested by Tor,
https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/patch/?id=5e6dca82bcaa49348f9e5fcb48df4881f6d6c4ae does fix it.

That hasn't made Linus' tree yet and I don't see a pull request, but it is in linux-next so I guess it could make it in
-rc6.

Chris
> --
> Thomas
> 

Re: linux-5.10.11 build failure

[Greg Kroah-Hartman]

On Thu, Jan 28, 2021 at 01:38:25PM +0000, Chris Clayton wrote:
> Thanks, Thomas.
> 
> On 28/01/2021 11:24, Thomas Backlund wrote:
> > Den 28.1.2021 kl. 12:05, skrev Chris Clayton:
> >>
> >> On 28/01/2021 09:34, Greg Kroah-Hartman wrote:
> >>> On Thu, Jan 28, 2021 at 09:17:10AM +0000, Chris Clayton wrote:
> >>>> Hi,
> >>>>
> >>>> Building 5.10.11 fails on my (x86-64) laptop thusly:
> >>>>
> >>>> ..
> >>>>
> >>>>   AS      arch/x86/entry/thunk_64.o
> >>>>    CC      arch/x86/entry/vsyscall/vsyscall_64.o
> >>>>    AS      arch/x86/realmode/rm/header.o
> >>>>    CC      arch/x86/mm/pat/set_memory.o
> >>>>    CC      arch/x86/events/amd/core.o
> >>>>    CC      arch/x86/kernel/fpu/init.o
> >>>>    CC      arch/x86/entry/vdso/vma.o
> >>>>    CC      kernel/sched/core.o
> >>>> arch/x86/entry/thunk_64.o: warning: objtool: missing symbol for insn at offset 0x3e
> >>>>
> >>>>    AS      arch/x86/realmode/rm/trampoline_64.o
> >>>> make[2]: *** [scripts/Makefile.build:360: arch/x86/entry/thunk_64.o] Error 255
> >>>> make[2]: *** Deleting file 'arch/x86/entry/thunk_64.o'
> >>>> make[2]: *** Waiting for unfinished jobs....
> >>>>
> >>>> ..
> >>>>
> >>>> Compiler is latest snapshot of gcc-10.
> >>>>
> >>>> Happy to test the fix but please cc me as I'm not subscribed
> >>>
> >>> Can you do 'git bisect' to track down the offending commit?
> >>>
> >>
> >> Sure, but I'll hold that request for a while. I updated to binutils-2.36 on Monday and I'm pretty sure that is a feature
> >> of this build fail. I've reverted binutils to 2.35.1, and the build succeeds. Updated to 2.36 again and, surprise,
> >> surprise, the kernel build fails again.
> >>
> >> I've had a glance at the binutils ML and there are all sorts of issues being reported, but it's beyond my knowledge to
> >> assess if this build error is related to any of them.
> >>
> >> I'll stick with binutils-2.35.1 for the time being.
> >>
> >>> And what exact gcc version are you using?
> >>>
> >>
> >>   It's built from the 10-20210123 snapshot tarball.
> >>
> >> I can report this to the binutils folks, but might it be better if the objtool maintainer looks at it first? The
> >> binutils change might just have opened the gate to a bug in objtool.
> >>
> >>> thanks,
> >>>
> >>> greg k-h
> >>>
> >>
> > 
> > 
> > AFAIK you need this in stable trees:
> > 
> >  From 1d489151e9f9d1647110277ff77282fe4d96d09b Mon Sep 17 00:00:00 2001
> > From: Josh Poimboeuf <jpoimboe@redhat.com>
> > Date: Thu, 14 Jan 2021 16:14:01 -0600
> > Subject: [PATCH] objtool: Don't fail on missing symbol table
> > 
> > 
> 
> That may be the caae, but it doesn't fix the build failure I've reported in this thread. However, as suggested by Tor,
> https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/patch/?id=5e6dca82bcaa49348f9e5fcb48df4881f6d6c4ae does fix it.
> 
> That hasn't made Linus' tree yet and I don't see a pull request, but it is in linux-next so I guess it could make it in
> -rc6.

Ok, thanks, so this is not a new regression for 5.10.y.

greg k-h

Re: linux-5.10.11 build failure

[Chris Clayton]

On 28/01/2021 14:41, Greg Kroah-Hartman wrote:
> On Thu, Jan 28, 2021 at 01:38:25PM +0000, Chris Clayton wrote:
>> Thanks, Thomas.
>>
>> On 28/01/2021 11:24, Thomas Backlund wrote:
>>> Den 28.1.2021 kl. 12:05, skrev Chris Clayton:
>>>>
>>>> On 28/01/2021 09:34, Greg Kroah-Hartman wrote:
>>>>> On Thu, Jan 28, 2021 at 09:17:10AM +0000, Chris Clayton wrote:
>>>>>> Hi,
>>>>>>
>>>>>> Building 5.10.11 fails on my (x86-64) laptop thusly:
>>>>>>
>>>>>> ..
>>>>>>
>>>>>>   AS      arch/x86/entry/thunk_64.o
>>>>>>    CC      arch/x86/entry/vsyscall/vsyscall_64.o
>>>>>>    AS      arch/x86/realmode/rm/header.o
>>>>>>    CC      arch/x86/mm/pat/set_memory.o
>>>>>>    CC      arch/x86/events/amd/core.o
>>>>>>    CC      arch/x86/kernel/fpu/init.o
>>>>>>    CC      arch/x86/entry/vdso/vma.o
>>>>>>    CC      kernel/sched/core.o
>>>>>> arch/x86/entry/thunk_64.o: warning: objtool: missing symbol for insn at offset 0x3e
>>>>>>
>>>>>>    AS      arch/x86/realmode/rm/trampoline_64.o
>>>>>> make[2]: *** [scripts/Makefile.build:360: arch/x86/entry/thunk_64.o] Error 255
>>>>>> make[2]: *** Deleting file 'arch/x86/entry/thunk_64.o'
>>>>>> make[2]: *** Waiting for unfinished jobs....
>>>>>>
>>>>>> ..
>>>>>>
>>>>>> Compiler is latest snapshot of gcc-10.
>>>>>>
>>>>>> Happy to test the fix but please cc me as I'm not subscribed
>>>>>
>>>>> Can you do 'git bisect' to track down the offending commit?
>>>>>
>>>>
>>>> Sure, but I'll hold that request for a while. I updated to binutils-2.36 on Monday and I'm pretty sure that is a feature
>>>> of this build fail. I've reverted binutils to 2.35.1, and the build succeeds. Updated to 2.36 again and, surprise,
>>>> surprise, the kernel build fails again.
>>>>
>>>> I've had a glance at the binutils ML and there are all sorts of issues being reported, but it's beyond my knowledge to
>>>> assess if this build error is related to any of them.
>>>>
>>>> I'll stick with binutils-2.35.1 for the time being.
>>>>
>>>>> And what exact gcc version are you using?
>>>>>
>>>>
>>>>   It's built from the 10-20210123 snapshot tarball.
>>>>
>>>> I can report this to the binutils folks, but might it be better if the objtool maintainer looks at it first? The
>>>> binutils change might just have opened the gate to a bug in objtool.
>>>>
>>>>> thanks,
>>>>>
>>>>> greg k-h
>>>>>
>>>>
>>>
>>>
>>> AFAIK you need this in stable trees:
>>>
>>>  From 1d489151e9f9d1647110277ff77282fe4d96d09b Mon Sep 17 00:00:00 2001
>>> From: Josh Poimboeuf <jpoimboe@redhat.com>
>>> Date: Thu, 14 Jan 2021 16:14:01 -0600
>>> Subject: [PATCH] objtool: Don't fail on missing symbol table
>>>
>>>
>>
>> That may be the caae, but it doesn't fix the build failure I've reported in this thread. However, as suggested by Tor,
>> https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/patch/?id=5e6dca82bcaa49348f9e5fcb48df4881f6d6c4ae does fix it.
>>
>> That hasn't made Linus' tree yet and I don't see a pull request, but it is in linux-next so I guess it could make it in
>> -rc6.
> 
> Ok, thanks, so this is not a new regression for 5.10.y.
> 

That seems to be the case, Greg. Neither 5.10.10 nor 5.10.9 build either.

> greg k-h
> 

Re: linux-5.10.11 build failure

[Josh Poimboeuf]

On Thu, Jan 28, 2021 at 01:38:25PM +0000, Chris Clayton wrote:
> Thanks, Thomas.
> 
> On 28/01/2021 11:24, Thomas Backlund wrote:
> > Den 28.1.2021 kl. 12:05, skrev Chris Clayton:
> >>
> >> On 28/01/2021 09:34, Greg Kroah-Hartman wrote:
> >>> On Thu, Jan 28, 2021 at 09:17:10AM +0000, Chris Clayton wrote:
> >>>> Hi,
> >>>>
> >>>> Building 5.10.11 fails on my (x86-64) laptop thusly:
> >>>>
> >>>> ..
> >>>>
> >>>>   AS      arch/x86/entry/thunk_64.o
> >>>>    CC      arch/x86/entry/vsyscall/vsyscall_64.o
> >>>>    AS      arch/x86/realmode/rm/header.o
> >>>>    CC      arch/x86/mm/pat/set_memory.o
> >>>>    CC      arch/x86/events/amd/core.o
> >>>>    CC      arch/x86/kernel/fpu/init.o
> >>>>    CC      arch/x86/entry/vdso/vma.o
> >>>>    CC      kernel/sched/core.o
> >>>> arch/x86/entry/thunk_64.o: warning: objtool: missing symbol for insn at offset 0x3e
> >>>>
> >>>>    AS      arch/x86/realmode/rm/trampoline_64.o
> >>>> make[2]: *** [scripts/Makefile.build:360: arch/x86/entry/thunk_64.o] Error 255
> >>>> make[2]: *** Deleting file 'arch/x86/entry/thunk_64.o'
> >>>> make[2]: *** Waiting for unfinished jobs....
> >>>>
> >>>> ..
> >>>>
> >>>> Compiler is latest snapshot of gcc-10.
> >>>>
> >>>> Happy to test the fix but please cc me as I'm not subscribed
> >>>
> >>> Can you do 'git bisect' to track down the offending commit?
> >>>
> >>
> >> Sure, but I'll hold that request for a while. I updated to binutils-2.36 on Monday and I'm pretty sure that is a feature
> >> of this build fail. I've reverted binutils to 2.35.1, and the build succeeds. Updated to 2.36 again and, surprise,
> >> surprise, the kernel build fails again.
> >>
> >> I've had a glance at the binutils ML and there are all sorts of issues being reported, but it's beyond my knowledge to
> >> assess if this build error is related to any of them.
> >>
> >> I'll stick with binutils-2.35.1 for the time being.
> >>
> >>> And what exact gcc version are you using?
> >>>
> >>
> >>   It's built from the 10-20210123 snapshot tarball.
> >>
> >> I can report this to the binutils folks, but might it be better if the objtool maintainer looks at it first? The
> >> binutils change might just have opened the gate to a bug in objtool.
> >>
> >>> thanks,
> >>>
> >>> greg k-h
> >>>
> >>
> > 
> > 
> > AFAIK you need this in stable trees:
> > 
> >  From 1d489151e9f9d1647110277ff77282fe4d96d09b Mon Sep 17 00:00:00 2001
> > From: Josh Poimboeuf <jpoimboe@redhat.com>
> > Date: Thu, 14 Jan 2021 16:14:01 -0600
> > Subject: [PATCH] objtool: Don't fail on missing symbol table
> > 
> > 
> 
> That may be the caae, but it doesn't fix the build failure I've reported in this thread. However, as suggested by Tor,
> https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/patch/?id=5e6dca82bcaa49348f9e5fcb48df4881f6d6c4ae does fix it.
> 
> That hasn't made Linus' tree yet and I don't see a pull request, but it is in linux-next so I guess it could make it in
> -rc6.

I mistakenly thought this was already in Linus' tree and submitted this
patch to stable a few days ago.

I talked to Boris (-tip maintainer), he's going to submit a pull request
to Linus this weekend.

-- 
Josh

Re: linux-5.10.11 build failure

[Chris Clayton]

Hi Greg,

On 29/01/2021 15:14, Josh Poimboeuf wrote:
> On Fri, Jan 29, 2021 at 12:09:53PM +0100, Greg Kroah-Hartman wrote:
>> On Fri, Jan 29, 2021 at 11:03:26AM +0000, Chris Clayton wrote:
>>>
>>>
>>> On 29/01/2021 10:11, Greg Kroah-Hartman wrote:
>>>> On Thu, Jan 28, 2021 at 10:00:15AM -0600, Josh Poimboeuf wrote:
...
>>>>
>>>> It is in Linus's tree now :)
>>>>
>>>> Now grabbed.
>>>>
>>>
>>> Are you sure, Greg? I don't see the patch in Linus' tree at
>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git. Nor do is see it in your stable queue at
>>> https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/. For clarity, I've attached the patch which
>>> fixes problem I reported and is currently sat in https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git As I
>>> understand it, the patch is scheduled to be included in a pull request to Linus this weekend in time for -rc6.
>>>
>>> In fact, I did a pull from Linus' tree a few minutes ago and the build failed in the way I reported in this thread. I
>>> added the patch and the build now succeeds.
>>
>> Ok, sorry, no, I grabbed 1d489151e9f9 ("objtool: Don't fail on missing
>> symbol table") which is what Josh asked me to take.  I got that confused
>> here.
> 
> I'm probably responsible for that confusion, I got mixed up myself.
> It'll be a good idea to take both anyway.
> 

The patch is now in Linus' tree at 5e6dca82bcaa49348f9e5fcb48df4881f6d6c4ae

Thanks.

Chris

Re: linux-5.10.11 build failure

[Greg Kroah-Hartman]

On Mon, Feb 01, 2021 at 08:59:09AM +0000, Chris Clayton wrote:
> Hi Greg,
> 
> On 29/01/2021 15:14, Josh Poimboeuf wrote:
> > On Fri, Jan 29, 2021 at 12:09:53PM +0100, Greg Kroah-Hartman wrote:
> >> On Fri, Jan 29, 2021 at 11:03:26AM +0000, Chris Clayton wrote:
> >>>
> >>>
> >>> On 29/01/2021 10:11, Greg Kroah-Hartman wrote:
> >>>> On Thu, Jan 28, 2021 at 10:00:15AM -0600, Josh Poimboeuf wrote:
> ...
> >>>>
> >>>> It is in Linus's tree now :)
> >>>>
> >>>> Now grabbed.
> >>>>
> >>>
> >>> Are you sure, Greg? I don't see the patch in Linus' tree at
> >>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git. Nor do is see it in your stable queue at
> >>> https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/. For clarity, I've attached the patch which
> >>> fixes problem I reported and is currently sat in https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git As I
> >>> understand it, the patch is scheduled to be included in a pull request to Linus this weekend in time for -rc6.
> >>>
> >>> In fact, I did a pull from Linus' tree a few minutes ago and the build failed in the way I reported in this thread. I
> >>> added the patch and the build now succeeds.
> >>
> >> Ok, sorry, no, I grabbed 1d489151e9f9 ("objtool: Don't fail on missing
> >> symbol table") which is what Josh asked me to take.  I got that confused
> >> here.
> > 
> > I'm probably responsible for that confusion, I got mixed up myself.
> > It'll be a good idea to take both anyway.
> > 
> 
> The patch is now in Linus' tree at 5e6dca82bcaa49348f9e5fcb48df4881f6d6c4ae

Thanks, now queued up.

greg k-h

Re: linux-5.10.11 build failure

[Josh Poimboeuf]

On Thu, Jan 28, 2021 at 11:24:47AM +0000, Thomas Backlund wrote:
> Den 28.1.2021 kl. 12:05, skrev Chris Clayton:
> > 
> > On 28/01/2021 09:34, Greg Kroah-Hartman wrote:
> >> On Thu, Jan 28, 2021 at 09:17:10AM +0000, Chris Clayton wrote:
> >>> Hi,
> >>>
> >>> Building 5.10.11 fails on my (x86-64) laptop thusly:
> >>>
> >>> ..
> >>>
> >>>   AS      arch/x86/entry/thunk_64.o
> >>>    CC      arch/x86/entry/vsyscall/vsyscall_64.o
> >>>    AS      arch/x86/realmode/rm/header.o
> >>>    CC      arch/x86/mm/pat/set_memory.o
> >>>    CC      arch/x86/events/amd/core.o
> >>>    CC      arch/x86/kernel/fpu/init.o
> >>>    CC      arch/x86/entry/vdso/vma.o
> >>>    CC      kernel/sched/core.o
> >>> arch/x86/entry/thunk_64.o: warning: objtool: missing symbol for insn at offset 0x3e
> >>>
> >>>    AS      arch/x86/realmode/rm/trampoline_64.o
> >>> make[2]: *** [scripts/Makefile.build:360: arch/x86/entry/thunk_64.o] Error 255
> >>> make[2]: *** Deleting file 'arch/x86/entry/thunk_64.o'
> >>> make[2]: *** Waiting for unfinished jobs....
> >>>
> >>> ..
> >>>
> >>> Compiler is latest snapshot of gcc-10.
> >>>
> >>> Happy to test the fix but please cc me as I'm not subscribed
> >>
> >> Can you do 'git bisect' to track down the offending commit?
> >>
> > 
> > Sure, but I'll hold that request for a while. I updated to binutils-2.36 on Monday and I'm pretty sure that is a feature
> > of this build fail. I've reverted binutils to 2.35.1, and the build succeeds. Updated to 2.36 again and, surprise,
> > surprise, the kernel build fails again.
> > 
> > I've had a glance at the binutils ML and there are all sorts of issues being reported, but it's beyond my knowledge to
> > assess if this build error is related to any of them.
> > 
> > I'll stick with binutils-2.35.1 for the time being.
> > 
> >> And what exact gcc version are you using?
> >>
> > 
> >   It's built from the 10-20210123 snapshot tarball.
> > 
> > I can report this to the binutils folks, but might it be better if the objtool maintainer looks at it first? The
> > binutils change might just have opened the gate to a bug in objtool.
> > 
> >> thanks,
> >>
> >> greg k-h
> >>
> > 
> 
> 
> AFAIK you need this in stable trees:
> 
>  From 1d489151e9f9d1647110277ff77282fe4d96d09b Mon Sep 17 00:00:00 2001
> From: Josh Poimboeuf <jpoimboe@redhat.com>
> Date: Thu, 14 Jan 2021 16:14:01 -0600
> Subject: [PATCH] objtool: Don't fail on missing symbol table

Actually I think you need:

  5e6dca82bcaa ("x86/entry: Emit a symbol for register restoring thunk")

I submitted a patch to stable list a few days ago.

(Though it's possible you need both commits, I'm not sure if binutils
 2.36 has the symbol stripping stuff)

-- 
Josh

Re: linux-5.10.11 build failure

[Chris Clayton]

On 28/01/2021 15:52, Josh Poimboeuf wrote:
> On Thu, Jan 28, 2021 at 11:24:47AM +0000, Thomas Backlund wrote:
>> Den 28.1.2021 kl. 12:05, skrev Chris Clayton:
>>>
>>> On 28/01/2021 09:34, Greg Kroah-Hartman wrote:
>>>> On Thu, Jan 28, 2021 at 09:17:10AM +0000, Chris Clayton wrote:
>>>>> Hi,
>>>>>
>>>>> Building 5.10.11 fails on my (x86-64) laptop thusly:
>>>>>
>>>>> ..
>>>>>
>>>>>   AS      arch/x86/entry/thunk_64.o
>>>>>    CC      arch/x86/entry/vsyscall/vsyscall_64.o
>>>>>    AS      arch/x86/realmode/rm/header.o
>>>>>    CC      arch/x86/mm/pat/set_memory.o
>>>>>    CC      arch/x86/events/amd/core.o
>>>>>    CC      arch/x86/kernel/fpu/init.o
>>>>>    CC      arch/x86/entry/vdso/vma.o
>>>>>    CC      kernel/sched/core.o
>>>>> arch/x86/entry/thunk_64.o: warning: objtool: missing symbol for insn at offset 0x3e
>>>>>
>>>>>    AS      arch/x86/realmode/rm/trampoline_64.o
>>>>> make[2]: *** [scripts/Makefile.build:360: arch/x86/entry/thunk_64.o] Error 255
>>>>> make[2]: *** Deleting file 'arch/x86/entry/thunk_64.o'
>>>>> make[2]: *** Waiting for unfinished jobs....
>>>>>
>>>>> ..
>>>>>
>>>>> Compiler is latest snapshot of gcc-10.
>>>>>
>>>>> Happy to test the fix but please cc me as I'm not subscribed
>>>>
>>>> Can you do 'git bisect' to track down the offending commit?
>>>>
>>>
>>> Sure, but I'll hold that request for a while. I updated to binutils-2.36 on Monday and I'm pretty sure that is a feature
>>> of this build fail. I've reverted binutils to 2.35.1, and the build succeeds. Updated to 2.36 again and, surprise,
>>> surprise, the kernel build fails again.
>>>
>>> I've had a glance at the binutils ML and there are all sorts of issues being reported, but it's beyond my knowledge to
>>> assess if this build error is related to any of them.
>>>
>>> I'll stick with binutils-2.35.1 for the time being.
>>>
>>>> And what exact gcc version are you using?
>>>>
>>>
>>>   It's built from the 10-20210123 snapshot tarball.
>>>
>>> I can report this to the binutils folks, but might it be better if the objtool maintainer looks at it first? The
>>> binutils change might just have opened the gate to a bug in objtool.
>>>
>>>> thanks,
>>>>
>>>> greg k-h
>>>>
>>>
>>
>>
>> AFAIK you need this in stable trees:
>>
>>  From 1d489151e9f9d1647110277ff77282fe4d96d09b Mon Sep 17 00:00:00 2001
>> From: Josh Poimboeuf <jpoimboe@redhat.com>
>> Date: Thu, 14 Jan 2021 16:14:01 -0600
>> Subject: [PATCH] objtool: Don't fail on missing symbol table
> 
> Actually I think you need:
> 
>   5e6dca82bcaa ("x86/entry: Emit a symbol for register restoring thunk")
> 
> I submitted a patch to stable list a few days ago.
> 

Yes, that's what I concluded, Josh. 5.10.11 builds with that patch added but it's not in Linus's tree yet, so, as I
understand it, is not yet a candidate from stable.


> (Though it's possible you need both commits, I'm not sure if binutils
>  2.36 has the symbol stripping stuff)
>