* [PATCH] perf tools: use ARRAY_SIZE
@ 2021-03-09 9:12 Jiapeng Chong
2021-03-09 12:09 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2021-03-09 9:12 UTC (permalink / raw)
To: peterz
Cc: mingo, acme, mark.rutland, alexander.shishkin, jolsa, namhyung,
linux-kernel, Jiapeng Chong
Fix the following cppcheck warnings:
./tools/perf/tests/demangle-ocaml-test.c:29:34-35: WARNING: Use
ARRAY_SIZE.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
tools/perf/tests/demangle-ocaml-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/tests/demangle-ocaml-test.c b/tools/perf/tests/demangle-ocaml-test.c
index a273ed5..2fac7d7 100644
--- a/tools/perf/tests/demangle-ocaml-test.c
+++ b/tools/perf/tests/demangle-ocaml-test.c
@@ -26,7 +26,7 @@ int test__demangle_ocaml(struct test *test __maybe_unused, int subtest __maybe_u
"Stdlib.bytes.++" },
};
- for (i = 0; i < sizeof(test_cases) / sizeof(test_cases[0]); i++) {
+ for (i = 0; i < ARRAY_SIZE(test_cases); i++) {
buf = ocaml_demangle_sym(test_cases[i].mangled);
if ((buf == NULL && test_cases[i].demangled != NULL)
|| (buf != NULL && test_cases[i].demangled == NULL)
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] perf tools: use ARRAY_SIZE
2021-03-09 9:12 [PATCH] perf tools: use ARRAY_SIZE Jiapeng Chong
@ 2021-03-09 12:09 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 2+ messages in thread
From: Arnaldo Carvalho de Melo @ 2021-03-09 12:09 UTC (permalink / raw)
To: Jiapeng Chong
Cc: peterz, mingo, mark.rutland, alexander.shishkin, jolsa, namhyung,
linux-kernel
Em Tue, Mar 09, 2021 at 05:12:25PM +0800, Jiapeng Chong escreveu:
> Fix the following cppcheck warnings:
>
> ./tools/perf/tests/demangle-ocaml-test.c:29:34-35: WARNING: Use
> ARRAY_SIZE.
Thanks, applied.
- Arnaldo
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> tools/perf/tests/demangle-ocaml-test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/tests/demangle-ocaml-test.c b/tools/perf/tests/demangle-ocaml-test.c
> index a273ed5..2fac7d7 100644
> --- a/tools/perf/tests/demangle-ocaml-test.c
> +++ b/tools/perf/tests/demangle-ocaml-test.c
> @@ -26,7 +26,7 @@ int test__demangle_ocaml(struct test *test __maybe_unused, int subtest __maybe_u
> "Stdlib.bytes.++" },
> };
>
> - for (i = 0; i < sizeof(test_cases) / sizeof(test_cases[0]); i++) {
> + for (i = 0; i < ARRAY_SIZE(test_cases); i++) {
> buf = ocaml_demangle_sym(test_cases[i].mangled);
> if ((buf == NULL && test_cases[i].demangled != NULL)
> || (buf != NULL && test_cases[i].demangled == NULL)
> --
> 1.8.3.1
>
--
- Arnaldo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-09 12:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-09 9:12 [PATCH] perf tools: use ARRAY_SIZE Jiapeng Chong
2021-03-09 12:09 ` Arnaldo Carvalho de Melo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox