From: Bhaskar Chowdhury <unixbhaskar@gmail.com>
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: suzuki.poulose@arm.com, leo.yan@linaro.org,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
rdunlap@infradead.org
Subject: Re: [PATCH] coresight-pmu.h: Fix a typo
Date: Sat, 27 Mar 2021 01:23:11 +0530 [thread overview]
Message-ID: <YF47p68yNRgIpuQU@Gentoo> (raw)
In-Reply-To: <20210326153213.GA2009902@xps15>
[-- Attachment #1: Type: text/plain, Size: 1505 bytes --]
On 09:32 Fri 26 Mar 2021, Mathieu Poirier wrote:
>Hi Bhaskar,
>
>On Fri, Mar 26, 2021 at 07:52:44PM +0530, Bhaskar Chowdhury wrote:
>>
>> s/orignally/originally/
>
>Even if the change is trivial this changelog is insufficient. Moreover, if you
>found the problem with an automated tool, please add the name of the tool to the
>changelog.
>
Oh Hi!
I think the changelog is sufficient enough to conveying the triviality of this
change.What's the point of writing unnecessary history , when a simple
statement can do the work.
These are hand picked ...there is no point mentioning the tool in the
changelog..it is all age old UNIX/Linux tool , nothing special.
>Thanks,
>Mathieu
>
>>
>> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
>> ---
>> include/linux/coresight-pmu.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/linux/coresight-pmu.h b/include/linux/coresight-pmu.h
>> index 4ac5c081af93..2d5c29e3cb8a 100644
>> --- a/include/linux/coresight-pmu.h
>> +++ b/include/linux/coresight-pmu.h
>> @@ -14,7 +14,7 @@
>> * Below are the definition of bit offsets for perf option, and works as
>> * arbitrary values for all ETM versions.
>> *
>> - * Most of them are orignally from ETMv3.5/PTM's ETMCR config, therefore,
>> + * Most of them are originally from ETMv3.5/PTM's ETMCR config, therefore,
>> * ETMv3.5/PTM doesn't define ETMCR config bits with prefix "ETM3_" and
>> * directly use below macros as config bits.
>> */
>> --
>> 2.26.2
>>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-03-26 19:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-26 14:22 [PATCH] coresight-pmu.h: Fix a typo Bhaskar Chowdhury
2021-03-26 15:32 ` Mathieu Poirier
2021-03-26 19:53 ` Bhaskar Chowdhury [this message]
2021-03-29 14:38 ` Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YF47p68yNRgIpuQU@Gentoo \
--to=unixbhaskar@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=leo.yan@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=rdunlap@infradead.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox