* [PATCH] staging: hikey9xx: Remove defined but unused macros
@ 2021-05-23 17:27 Fabio M. De Francesco
2021-05-25 16:24 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Fabio M. De Francesco @ 2021-05-23 17:27 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Greg Kroah-Hartman, linux-staging,
linux-kernel
Cc: Fabio M. De Francesco
Removed defined but unused macros. Issue detected by GCC running with
-Wunused-macro warning option set.
Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
---
drivers/staging/hikey9xx/hisi-spmi-controller.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/drivers/staging/hikey9xx/hisi-spmi-controller.c b/drivers/staging/hikey9xx/hisi-spmi-controller.c
index 0d42bc65f39b..b64594e2a84b 100644
--- a/drivers/staging/hikey9xx/hisi-spmi-controller.c
+++ b/drivers/staging/hikey9xx/hisi-spmi-controller.c
@@ -21,16 +21,10 @@
#define SPMI_APB_SPMI_CMD_BASE_ADDR 0x0100
#define SPMI_APB_SPMI_WDATA0_BASE_ADDR 0x0104
-#define SPMI_APB_SPMI_WDATA1_BASE_ADDR 0x0108
-#define SPMI_APB_SPMI_WDATA2_BASE_ADDR 0x010c
-#define SPMI_APB_SPMI_WDATA3_BASE_ADDR 0x0110
#define SPMI_APB_SPMI_STATUS_BASE_ADDR 0x0200
#define SPMI_APB_SPMI_RDATA0_BASE_ADDR 0x0204
-#define SPMI_APB_SPMI_RDATA1_BASE_ADDR 0x0208
-#define SPMI_APB_SPMI_RDATA2_BASE_ADDR 0x020c
-#define SPMI_APB_SPMI_RDATA3_BASE_ADDR 0x0210
#define SPMI_PER_DATAREG_BYTE 4
/*
@@ -64,9 +58,6 @@ enum spmi_controller_cmd_op_code {
#define SPMI_APB_TRANS_DONE BIT(0)
#define SPMI_APB_TRANS_FAIL BIT(2)
-/* Command register fields */
-#define SPMI_CONTROLLER_CMD_MAX_BYTE_COUNT 16
-
/* Maximum number of support PMIC peripherals */
#define SPMI_CONTROLLER_TIMEOUT_US 1000
#define SPMI_CONTROLLER_MAX_TRANS_BYTES 16
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] staging: hikey9xx: Remove defined but unused macros
2021-05-23 17:27 [PATCH] staging: hikey9xx: Remove defined but unused macros Fabio M. De Francesco
@ 2021-05-25 16:24 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2021-05-25 16:24 UTC (permalink / raw)
To: Fabio M. De Francesco; +Cc: Mauro Carvalho Chehab, linux-staging, linux-kernel
On Sun, May 23, 2021 at 07:27:09PM +0200, Fabio M. De Francesco wrote:
> Removed defined but unused macros. Issue detected by GCC running with
> -Wunused-macro warning option set.
>
> Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> ---
> drivers/staging/hikey9xx/hisi-spmi-controller.c | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/drivers/staging/hikey9xx/hisi-spmi-controller.c b/drivers/staging/hikey9xx/hisi-spmi-controller.c
> index 0d42bc65f39b..b64594e2a84b 100644
> --- a/drivers/staging/hikey9xx/hisi-spmi-controller.c
> +++ b/drivers/staging/hikey9xx/hisi-spmi-controller.c
> @@ -21,16 +21,10 @@
> #define SPMI_APB_SPMI_CMD_BASE_ADDR 0x0100
>
> #define SPMI_APB_SPMI_WDATA0_BASE_ADDR 0x0104
> -#define SPMI_APB_SPMI_WDATA1_BASE_ADDR 0x0108
> -#define SPMI_APB_SPMI_WDATA2_BASE_ADDR 0x010c
> -#define SPMI_APB_SPMI_WDATA3_BASE_ADDR 0x0110
>
> #define SPMI_APB_SPMI_STATUS_BASE_ADDR 0x0200
>
> #define SPMI_APB_SPMI_RDATA0_BASE_ADDR 0x0204
> -#define SPMI_APB_SPMI_RDATA1_BASE_ADDR 0x0208
> -#define SPMI_APB_SPMI_RDATA2_BASE_ADDR 0x020c
> -#define SPMI_APB_SPMI_RDATA3_BASE_ADDR 0x0210
>
> #define SPMI_PER_DATAREG_BYTE 4
> /*
> @@ -64,9 +58,6 @@ enum spmi_controller_cmd_op_code {
> #define SPMI_APB_TRANS_DONE BIT(0)
> #define SPMI_APB_TRANS_FAIL BIT(2)
>
> -/* Command register fields */
> -#define SPMI_CONTROLLER_CMD_MAX_BYTE_COUNT 16
> -
> /* Maximum number of support PMIC peripherals */
> #define SPMI_CONTROLLER_TIMEOUT_US 1000
> #define SPMI_CONTROLLER_MAX_TRANS_BYTES 16
> --
> 2.31.1
>
>
Leaving macros that are not used are fine to keep around, it documents
the hardware.
That's a pretty foolish gcc warning :(
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-25 16:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-05-23 17:27 [PATCH] staging: hikey9xx: Remove defined but unused macros Fabio M. De Francesco
2021-05-25 16:24 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox