From: Greg KH <gregkh@linuxfoundation.org>
To: Jeya R <jeyr@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org, srinivas.kandagatla@linaro.org,
linux-kernel@vger.kernel.org, fastrpc.upstream@qti.qualcomm.com
Subject: Re: [PATCH] misc: fastrpc: Update number of max fastrpc sessions
Date: Mon, 20 Sep 2021 09:51:18 +0200 [thread overview]
Message-ID: <YUg9dmThHg9s8XAy@kroah.com> (raw)
In-Reply-To: <1632123274-32054-1-git-send-email-jeyr@codeaurora.org>
On Mon, Sep 20, 2021 at 01:04:34PM +0530, Jeya R wrote:
> For latest chipsets, upto 13 fastrpc sessions can be
> supported. This includes 12 compute sessions and 1 cpz
> session. Not updating this might result to out of bounds
> memory access issues if more than 9 context bank nodes
> are added to the DT file.
>
> Signed-off-by: Jeya R <jeyr@codeaurora.org>
> ---
> drivers/misc/fastrpc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c
> index beda610..bd7811e 100644
> --- a/drivers/misc/fastrpc.c
> +++ b/drivers/misc/fastrpc.c
> @@ -24,7 +24,7 @@
> #define SDSP_DOMAIN_ID (2)
> #define CDSP_DOMAIN_ID (3)
> #define FASTRPC_DEV_MAX 4 /* adsp, mdsp, slpi, cdsp*/
> -#define FASTRPC_MAX_SESSIONS 9 /*8 compute, 1 cpz*/
> +#define FASTRPC_MAX_SESSIONS 13 /*12 compute, 1 cpz*/
> #define FASTRPC_ALIGN 128
> #define FASTRPC_MAX_FDLIST 16
> #define FASTRPC_MAX_CRCLIST 64
> --
> 2.7.4
>
What happens if you run this on "older" chipsets?
And is this an issue now, or can this wait to 5.16-rc1?
thanks,
greg k-h
next prev parent reply other threads:[~2021-09-20 7:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 7:34 [PATCH] misc: fastrpc: Update number of max fastrpc sessions Jeya R
2021-09-20 7:51 ` Greg KH [this message]
2021-09-20 12:53 ` Srinivas Kandagatla
2021-09-21 14:12 ` Greg KH
2021-09-21 14:47 ` Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUg9dmThHg9s8XAy@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=fastrpc.upstream@qti.qualcomm.com \
--cc=jeyr@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox