From: Greg KH <gregkh@linuxfoundation.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Jeya R <jeyr@codeaurora.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
fastrpc.upstream@qti.qualcomm.com
Subject: Re: [PATCH] misc: fastrpc: Update number of max fastrpc sessions
Date: Tue, 21 Sep 2021 16:12:27 +0200 [thread overview]
Message-ID: <YUnoS04YWVtaxcDr@kroah.com> (raw)
In-Reply-To: <88370a7c-9e28-ae1b-2f48-bc38a8cff78f@linaro.org>
On Mon, Sep 20, 2021 at 01:53:39PM +0100, Srinivas Kandagatla wrote:
>
>
> On 20/09/2021 08:51, Greg KH wrote:
> > On Mon, Sep 20, 2021 at 01:04:34PM +0530, Jeya R wrote:
> > > For latest chipsets, upto 13 fastrpc sessions can be
> > > supported. This includes 12 compute sessions and 1 cpz
> > > session. Not updating this might result to out of bounds
> > > memory access issues if more than 9 context bank nodes
> > > are added to the DT file.
> > >
> > > Signed-off-by: Jeya R <jeyr@codeaurora.org>
> > > ---
> > > drivers/misc/fastrpc.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c
> > > index beda610..bd7811e 100644
> > > --- a/drivers/misc/fastrpc.c
> > > +++ b/drivers/misc/fastrpc.c
> > > @@ -24,7 +24,7 @@
> > > #define SDSP_DOMAIN_ID (2)
> > > #define CDSP_DOMAIN_ID (3)
> > > #define FASTRPC_DEV_MAX 4 /* adsp, mdsp, slpi, cdsp*/
> > > -#define FASTRPC_MAX_SESSIONS 9 /*8 compute, 1 cpz*/
> > > +#define FASTRPC_MAX_SESSIONS 13 /*12 compute, 1 cpz*/
> > > #define FASTRPC_ALIGN 128
> > > #define FASTRPC_MAX_FDLIST 16
> > > #define FASTRPC_MAX_CRCLIST 64
> > > --
> > > 2.7.4
> > >
> >
> > What happens if you run this on "older" chipsets?
>
> This change should not have any implications on the older chips, as the
> existing compute context bank device tree entries will not exceed 9.
>
> >
> > And is this an issue now, or can this wait to 5.16-rc1?
>
> We could wait take in 5.16-rc1, as its an enhancement to allow more compute
> context banks.
Ok, can I get a reviewed-by: for this?
next prev parent reply other threads:[~2021-09-21 14:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 7:34 [PATCH] misc: fastrpc: Update number of max fastrpc sessions Jeya R
2021-09-20 7:51 ` Greg KH
2021-09-20 12:53 ` Srinivas Kandagatla
2021-09-21 14:12 ` Greg KH [this message]
2021-09-21 14:47 ` Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUnoS04YWVtaxcDr@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=fastrpc.upstream@qti.qualcomm.com \
--cc=jeyr@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox