From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: "Mark Brown" <broonie@kernel.org>,
"Arnd Bergmann" <arnd@arndb.de>,
"Aswath Govindraju" <a-govindraju@ti.com>,
"Emmanuel Gil Peyrot" <linkmauve@linkmauve.fr>,
"Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] eeprom: 93xx46: fix MODULE_DEVICE_TABLE
Date: Fri, 15 Oct 2021 10:54:00 +0200 [thread overview]
Message-ID: <YWlBqLFS7KpBvrg9@kroah.com> (raw)
In-Reply-To: <20211014153730.3821376-1-arnd@kernel.org>
On Thu, Oct 14, 2021 at 05:37:18PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The newly added SPI device ID table does not work because the
> entry is incorrectly copied from the OF device table.
>
> During build testing, this shows as a compile failure when building
> it as a loadable module:
>
> drivers/misc/eeprom/eeprom_93xx46.c:424:1: error: redefinition of '__mod_of__eeprom_93xx46_of_table_device_table'
> MODULE_DEVICE_TABLE(of, eeprom_93xx46_of_table);
>
> Change the entry to refer to the correct symbol.
>
> Fixes: 137879f7ff23 ("eeprom: 93xx46: Add SPI device ID table")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/misc/eeprom/eeprom_93xx46.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Ah, nice catch, will queue this up now, thanks!
greg k-h
prev parent reply other threads:[~2021-10-15 8:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-14 15:37 [PATCH] eeprom: 93xx46: fix MODULE_DEVICE_TABLE Arnd Bergmann
2021-10-15 8:54 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YWlBqLFS7KpBvrg9@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=a-govindraju@ti.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=broonie@kernel.org \
--cc=j.neuschaefer@gmx.net \
--cc=linkmauve@linkmauve.fr \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox