* [PATCH] eeprom: 93xx46: fix MODULE_DEVICE_TABLE
@ 2021-10-14 15:37 Arnd Bergmann
2021-10-15 8:54 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2021-10-14 15:37 UTC (permalink / raw)
To: Greg Kroah-Hartman, Mark Brown
Cc: Arnd Bergmann, Aswath Govindraju, Emmanuel Gil Peyrot,
Jonathan Neuschäfer, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The newly added SPI device ID table does not work because the
entry is incorrectly copied from the OF device table.
During build testing, this shows as a compile failure when building
it as a loadable module:
drivers/misc/eeprom/eeprom_93xx46.c:424:1: error: redefinition of '__mod_of__eeprom_93xx46_of_table_device_table'
MODULE_DEVICE_TABLE(of, eeprom_93xx46_of_table);
Change the entry to refer to the correct symbol.
Fixes: 137879f7ff23 ("eeprom: 93xx46: Add SPI device ID table")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/misc/eeprom/eeprom_93xx46.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/eeprom/eeprom_93xx46.c b/drivers/misc/eeprom/eeprom_93xx46.c
index 660ee924f8b1..1f15399e5cb4 100644
--- a/drivers/misc/eeprom/eeprom_93xx46.c
+++ b/drivers/misc/eeprom/eeprom_93xx46.c
@@ -421,7 +421,7 @@ static const struct spi_device_id eeprom_93xx46_spi_ids[] = {
.driver_data = (kernel_ulong_t)µchip_93lc46b_data, },
{}
};
-MODULE_DEVICE_TABLE(of, eeprom_93xx46_of_table);
+MODULE_DEVICE_TABLE(spi, eeprom_93xx46_spi_ids);
static int eeprom_93xx46_probe_dt(struct spi_device *spi)
{
--
2.29.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] eeprom: 93xx46: fix MODULE_DEVICE_TABLE
2021-10-14 15:37 [PATCH] eeprom: 93xx46: fix MODULE_DEVICE_TABLE Arnd Bergmann
@ 2021-10-15 8:54 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2021-10-15 8:54 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Mark Brown, Arnd Bergmann, Aswath Govindraju, Emmanuel Gil Peyrot,
Jonathan Neuschäfer, linux-kernel
On Thu, Oct 14, 2021 at 05:37:18PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The newly added SPI device ID table does not work because the
> entry is incorrectly copied from the OF device table.
>
> During build testing, this shows as a compile failure when building
> it as a loadable module:
>
> drivers/misc/eeprom/eeprom_93xx46.c:424:1: error: redefinition of '__mod_of__eeprom_93xx46_of_table_device_table'
> MODULE_DEVICE_TABLE(of, eeprom_93xx46_of_table);
>
> Change the entry to refer to the correct symbol.
>
> Fixes: 137879f7ff23 ("eeprom: 93xx46: Add SPI device ID table")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/misc/eeprom/eeprom_93xx46.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Ah, nice catch, will queue this up now, thanks!
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-15 8:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-14 15:37 [PATCH] eeprom: 93xx46: fix MODULE_DEVICE_TABLE Arnd Bergmann
2021-10-15 8:54 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox