From: Christoph Hellwig <hch@infradead.org>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Christoph Hellwig <hch@infradead.org>,
James Bottomley <jejb@linux.ibm.com>,
daejun7.park@samsung.com, ALIM AKHTAR <alim.akhtar@samsung.com>,
"avri.altman@wdc.com" <avri.altman@wdc.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"huobean@gmail.com" <huobean@gmail.com>,
Keoseong Park <keosung.park@samsung.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] scsi: ufs: Fix proper API to send HPB pre-request
Date: Thu, 28 Oct 2021 10:10:24 -0700 [thread overview]
Message-ID: <YXrZgC7mYVQS+CE6@infradead.org> (raw)
In-Reply-To: <54b45df9-9339-c69d-73b5-9c293449b849@acm.org>
On Thu, Oct 28, 2021 at 10:07:52AM -0700, Bart Van Assche wrote:
> I spent some time looking around for other examples of allocating and
> inserting a request from inside block layer callbacks. I only found one
> such example, namely in the NVMe core. nvme_timeout() calls
> nvme_alloc_request() and blk_execute_rq_nowait(). The difference between
> what the UFS HPB code is doing and what nvme_timeout() does doesn't seem
> that big to me.
The difference is that nvme_timeout allocates a request on the
admin queue, and only does so for commands on the I/O queues.
next prev parent reply other threads:[~2021-10-28 17:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20211027223619epcms2p60bbc74c9ba9757c58709a99acd0892ff@epcms2p6>
2021-10-27 22:36 ` [PATCH] scsi: ufs: Fix proper API to send HPB pre-request Daejun Park
2021-10-28 4:16 ` Bart Van Assche
2021-10-28 14:28 ` James Bottomley
2021-10-28 15:27 ` Christoph Hellwig
2021-10-28 17:07 ` Bart Van Assche
2021-10-28 17:10 ` Christoph Hellwig [this message]
2021-10-28 15:59 ` Bart Van Assche
2021-10-28 19:12 ` James Bottomley
2021-10-28 20:04 ` Bart Van Assche
2021-10-28 20:12 ` James Bottomley
2021-10-28 21:20 ` Daejun Park
2021-10-28 15:22 ` James Bottomley
2021-10-29 1:32 ` Ming Lei
2021-10-29 1:50 ` Daejun Park
2021-10-29 2:10 ` Ming Lei
2021-10-29 2:50 ` Daejun Park
2021-10-29 3:14 ` Ming Lei
2021-10-29 4:39 ` Daejun Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXrZgC7mYVQS+CE6@infradead.org \
--to=hch@infradead.org \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=daejun7.park@samsung.com \
--cc=huobean@gmail.com \
--cc=jejb@linux.ibm.com \
--cc=keosung.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox