From: "Luís Henriques" <lhenriques@suse.de>
To: Ilya Dryomov <idryomov@gmail.com>
Cc: Jeff Layton <jlayton@kernel.org>, Xiubo Li <xiubli@redhat.com>,
Patrick Donnelly <pdonnell@redhat.com>,
Ceph Development <ceph-devel@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] ceph: libceph: move ceph_osdc_copy_from() into cephfs code
Date: Mon, 8 Nov 2021 10:30:41 +0000 [thread overview]
Message-ID: <YYj8UQFLHTI0WwGg@suse.de> (raw)
In-Reply-To: <CAOi1vP8QYm+JR7c2_t5uSk-8jmqTmRs4WNYhDAoYfgar2cPw4Q@mail.gmail.com>
Hi Ilya,
On Mon, Nov 08, 2021 at 04:46:40AM +0100, Ilya Dryomov wrote:
> On Thu, Nov 4, 2021 at 1:31 PM Luís Henriques <lhenriques@suse.de> wrote:
> >
> > This patch moves ceph_osdc_copy_from() function out of libceph code into
> > cephfs. There are no other users for this function, and there is the need
> > (in another patch) to access internal ceph_osd_request struct members.
> > Thus, instead of changing ceph_osdc_copy_from() to return the request,
> > simply move it where it is needed.
>
> Hi Luis,
>
> ceph_alloc_copyfrom_request() does exactly that -- returns the request.
> I have dropped this sentence from the changelog but wanted to check if
> you meant to keep the change instead of just moving and renaming.
Dropping that sentence seems the right thing to do. I've just checked the
'testing' branch and the changelog looks good to me. Thanks!
Cheers,
--
Luís
next prev parent reply other threads:[~2021-11-08 10:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-04 12:31 [PATCH v2 0/2] ceph: metrics for remote object copies Luís Henriques
2021-11-04 12:31 ` [PATCH v2 1/2] ceph: libceph: move ceph_osdc_copy_from() into cephfs code Luís Henriques
2021-11-08 3:46 ` Ilya Dryomov
2021-11-08 10:30 ` Luís Henriques [this message]
2021-11-04 12:31 ` [PATCH v2 2/2] ceph: add a new metric to keep track of remote object copies Luís Henriques
2021-11-04 15:09 ` [PATCH v2 0/2] ceph: metrics for " Jeff Layton
2021-11-04 15:37 ` Luís Henriques
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYj8UQFLHTI0WwGg@suse.de \
--to=lhenriques@suse.de \
--cc=ceph-devel@vger.kernel.org \
--cc=idryomov@gmail.com \
--cc=jlayton@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pdonnell@redhat.com \
--cc=xiubli@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox