From: Jeff Layton <jlayton@kernel.org>
To: "Luís Henriques" <lhenriques@suse.de>,
"Ilya Dryomov" <idryomov@gmail.com>,
"Xiubo Li" <xiubli@redhat.com>
Cc: Patrick Donnelly <pdonnell@redhat.com>,
ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] ceph: metrics for remote object copies
Date: Thu, 04 Nov 2021 11:09:32 -0400 [thread overview]
Message-ID: <b2fcd4ff9dd84ceb90650d24b56bd704985c85b8.camel@kernel.org> (raw)
In-Reply-To: <20211104123147.1632-1-lhenriques@suse.de>
On Thu, 2021-11-04 at 12:31 +0000, Luís Henriques wrote:
> Hi!
>
> Here's v2 of this patchset. The differences from v1:
>
> * Instead of changing ceph_osdc_copy_from() in libceph.ko to return an
> osd request, move that function into the cephfs code instead.
>
> Other than that, the 2nd patch is quite similar to the one from v1: it
> effectively hooks the 'copyfrom' metrics infrastructure.
>
> Luís Henriques (2):
> ceph: libceph: move ceph_osdc_copy_from() into cephfs code
> ceph: add a new metric to keep track of remote object copies
>
> fs/ceph/debugfs.c | 3 +-
> fs/ceph/file.c | 78 ++++++++++++++++++++++++++++-----
> fs/ceph/metric.h | 8 ++++
> include/linux/ceph/osd_client.h | 19 ++++----
> net/ceph/osd_client.c | 60 ++++---------------------
> 5 files changed, 94 insertions(+), 74 deletions(-)
>
Looks good. Thanks, Luis. Merged into testing branch.
--
Jeff Layton <jlayton@kernel.org>
next prev parent reply other threads:[~2021-11-04 15:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-04 12:31 [PATCH v2 0/2] ceph: metrics for remote object copies Luís Henriques
2021-11-04 12:31 ` [PATCH v2 1/2] ceph: libceph: move ceph_osdc_copy_from() into cephfs code Luís Henriques
2021-11-08 3:46 ` Ilya Dryomov
2021-11-08 10:30 ` Luís Henriques
2021-11-04 12:31 ` [PATCH v2 2/2] ceph: add a new metric to keep track of remote object copies Luís Henriques
2021-11-04 15:09 ` Jeff Layton [this message]
2021-11-04 15:37 ` [PATCH v2 0/2] ceph: metrics for " Luís Henriques
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2fcd4ff9dd84ceb90650d24b56bd704985c85b8.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=ceph-devel@vger.kernel.org \
--cc=idryomov@gmail.com \
--cc=lhenriques@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=pdonnell@redhat.com \
--cc=xiubli@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox