From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Puranjay Mohan <puranjay12@gmail.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
rafael@kernel.org, heikki.krogerus@linux.intel.com,
kuba@kernel.org, saravanak@google.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
"Hennerich, Michael" <Michael.Hennerich@analog.com>,
Jonathan Cameron <jic23@kernel.org>,
linux-iio <linux-iio@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] device property: Add fwnode_irq_get_byname()
Date: Wed, 10 Nov 2021 19:27:03 +0200 [thread overview]
Message-ID: <YYwA5/8Zoq6BT29P@smile.fi.intel.com> (raw)
In-Reply-To: <CANk7y0jRKVrTRZCzq0W1G7_Ef1QqF5yqKs==DwsR+xuhra3b4A@mail.gmail.com>
On Wed, Nov 10, 2021 at 10:34:43PM +0530, Puranjay Mohan wrote:
> On Wed, Nov 10, 2021 at 2:23 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Wed, Nov 10, 2021 at 01:38:39AM +0530, Puranjay Mohan wrote:
> I wrote this function keeping the device tree in mind. I will have to
> look into ACPI and see how the cases you mentioned can be implemented.
> Let's see how far I can get with understanding the ACPI.
Yeah.
What you need to have is
1) expand fwnode_irq_get() to support ACPI GPIO IRQ resources.
2) provide a simple version of the fwnode_irq_get_by_name() like
if (is_of_node())
return of_...();
return acpi_dev_gpio_irq_get_by();
3) establish understanding about naming for ACPI and
4) extend fwnode_irq_get_by_name() by it
if (is_of_node())
return of_...();
ret = acpi_irq_get_by_name();
if (ret > 0)
return ret;
return acpi_dev_gpio_irq_get_by();
As I mentioned, items 1 and 2 are easy to achieve with currently existing APIs.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-11-10 17:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-09 20:08 [PATCH v2 0/2] device property: Adding fwnode_irq_get_byname() Puranjay Mohan
2021-11-09 20:08 ` [PATCH v2 1/2] device property: Add fwnode_irq_get_byname() Puranjay Mohan
2021-11-10 8:53 ` Andy Shevchenko
2021-11-10 17:04 ` Puranjay Mohan
2021-11-10 17:27 ` Andy Shevchenko [this message]
2021-11-09 20:08 ` [PATCH v2 2/2] iio: accel: adxl355: use fwnode_irq_get_byname() Puranjay Mohan
2022-02-01 16:25 ` Andy Shevchenko
2022-02-27 12:41 ` Jonathan Cameron
2022-04-10 17:13 ` Jonathan Cameron
2022-04-11 10:17 ` Andy Shevchenko
2021-11-09 22:42 ` [PATCH v2 0/2] device property: Adding fwnode_irq_get_byname() Saravana Kannan
2021-11-10 8:32 ` Andy Shevchenko
2021-11-10 8:32 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYwA5/8Zoq6BT29P@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Michael.Hennerich@analog.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jic23@kernel.org \
--cc=kuba@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=puranjay12@gmail.com \
--cc=rafael@kernel.org \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox