* [PATCH] serial: 8250_pci: remove redundant assignment to tmp after the mask operation
@ 2021-12-05 23:28 Colin Ian King
2021-12-06 13:46 ` Andy Shevchenko
0 siblings, 1 reply; 2+ messages in thread
From: Colin Ian King @ 2021-12-05 23:28 UTC (permalink / raw)
To: Greg Kroah-Hartman, Jiri Slaby, Andy Shevchenko, linux-serial
Cc: kernel-janitors, linux-kernel
The variable tmp is being masked with a bitmask and the value is being
written to port base + 0x3c. However, the masked value is being written
back to tmp and tmp is never used after this. The assignmentment is
redundant, replace the &= operator with just &.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/tty/serial/8250/8250_pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/8250/8250_pci.c
index 60f8fffdfd77..81aac3c25ead 100644
--- a/drivers/tty/serial/8250/8250_pci.c
+++ b/drivers/tty/serial/8250/8250_pci.c
@@ -1278,7 +1278,7 @@ static int pci_quatech_init(struct pci_dev *dev)
outl(inl(base + 0x38) | 0x00002000, base + 0x38);
tmp = inl(base + 0x3c);
outl(tmp | 0x01000000, base + 0x3c);
- outl(tmp &= ~0x01000000, base + 0x3c);
+ outl(tmp & ~0x01000000, base + 0x3c);
}
}
return 0;
--
2.33.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] serial: 8250_pci: remove redundant assignment to tmp after the mask operation
2021-12-05 23:28 [PATCH] serial: 8250_pci: remove redundant assignment to tmp after the mask operation Colin Ian King
@ 2021-12-06 13:46 ` Andy Shevchenko
0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2021-12-06 13:46 UTC (permalink / raw)
To: Colin Ian King
Cc: Greg Kroah-Hartman, Jiri Slaby, linux-serial, kernel-janitors,
linux-kernel
On Sun, Dec 05, 2021 at 11:28:22PM +0000, Colin Ian King wrote:
> The variable tmp is being masked with a bitmask and the value is being
> written to port base + 0x3c. However, the masked value is being written
> back to tmp and tmp is never used after this. The assignmentment is
> redundant, replace the &= operator with just &.
Make sense (maybe you can replace all those 0x00...BIT...00 by BIT()
and GENMASK() later on).
Reviewesd-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
> drivers/tty/serial/8250/8250_pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/8250/8250_pci.c
> index 60f8fffdfd77..81aac3c25ead 100644
> --- a/drivers/tty/serial/8250/8250_pci.c
> +++ b/drivers/tty/serial/8250/8250_pci.c
> @@ -1278,7 +1278,7 @@ static int pci_quatech_init(struct pci_dev *dev)
> outl(inl(base + 0x38) | 0x00002000, base + 0x38);
> tmp = inl(base + 0x3c);
> outl(tmp | 0x01000000, base + 0x3c);
> - outl(tmp &= ~0x01000000, base + 0x3c);
> + outl(tmp & ~0x01000000, base + 0x3c);
> }
> }
> return 0;
> --
> 2.33.1
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-06 13:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-05 23:28 [PATCH] serial: 8250_pci: remove redundant assignment to tmp after the mask operation Colin Ian King
2021-12-06 13:46 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox