From: Greg KH <gregkh@linuxfoundation.org>
To: Ryan Cai <ycaibb@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org
Subject: Re: [Resource Leak] Missing closing files
Date: Thu, 30 Dec 2021 07:57:50 +0100 [thread overview]
Message-ID: <Yc1YbthVqjBIAOyC@kroah.com> (raw)
In-Reply-To: <5C277DBF-B1EF-4193-9983-63105E5BC053@gmail.com>
On Thu, Dec 30, 2021 at 11:04:58AM +0800, Ryan Cai wrote:
> Dear Kernel maintainers,
>
> In linux/drivers/zorro/gen-devlist.c, the file opened at Line 39 may not closed when going to Line 65.
>
> I think, return 1 at Line 65 should be goto error. Should it be a bug? I can send a patch.
>
> Location: https://github.com/torvalds/linux/blob/5bfc75d92efd494db37f5c4c173d3639d4772966/drivers/zorro/gen-devlist.c#L39-L65
Do you use this program / file?
If so, and you can duplicate the problem, sure, send a patch after
testing it.
thanks,
greg k-h
prev parent reply other threads:[~2021-12-30 6:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-30 3:04 [Resource Leak] Missing closing files Ryan Cai
2021-12-30 6:57 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yc1YbthVqjBIAOyC@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=ycaibb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox