* [Resource Leak] Missing closing files
@ 2021-12-30 3:04 Ryan Cai
2021-12-30 6:57 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Ryan Cai @ 2021-12-30 3:04 UTC (permalink / raw)
To: greg; +Cc: linux-kernel, linux-m68k
Dear Kernel maintainers,
In linux/drivers/zorro/gen-devlist.c, the file opened at Line 39 may not closed when going to Line 65.
I think, return 1 at Line 65 should be goto error. Should it be a bug? I can send a patch.
Location: https://github.com/torvalds/linux/blob/5bfc75d92efd494db37f5c4c173d3639d4772966/drivers/zorro/gen-devlist.c#L39-L65
Best,
Ryan
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Resource Leak] Missing closing files
2021-12-30 3:04 [Resource Leak] Missing closing files Ryan Cai
@ 2021-12-30 6:57 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2021-12-30 6:57 UTC (permalink / raw)
To: Ryan Cai; +Cc: linux-kernel, linux-m68k
On Thu, Dec 30, 2021 at 11:04:58AM +0800, Ryan Cai wrote:
> Dear Kernel maintainers,
>
> In linux/drivers/zorro/gen-devlist.c, the file opened at Line 39 may not closed when going to Line 65.
>
> I think, return 1 at Line 65 should be goto error. Should it be a bug? I can send a patch.
>
> Location: https://github.com/torvalds/linux/blob/5bfc75d92efd494db37f5c4c173d3639d4772966/drivers/zorro/gen-devlist.c#L39-L65
Do you use this program / file?
If so, and you can duplicate the problem, sure, send a patch after
testing it.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-30 6:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-30 3:04 [Resource Leak] Missing closing files Ryan Cai
2021-12-30 6:57 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox