* [PATCH] can: softing_cs: fix memleak on registration failure
@ 2021-12-22 10:48 Johan Hovold
2021-12-22 11:05 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Johan Hovold @ 2021-12-22 10:48 UTC (permalink / raw)
To: Wolfgang Grandegger, Marc Kleine-Budde
Cc: David S. Miller, Jakub Kicinski, linux-can, netdev, linux-kernel,
Johan Hovold, stable
In case device registration fails during probe, the driver state and the
embedded platform device structure needs to be freed using
platform_device_put() to properly free all resources (e.g. the device
name).
Fixes: 0a0b7a5f7a04 ("can: add driver for Softing card")
Cc: stable@vger.kernel.org # 2.6.38
Signed-off-by: Johan Hovold <johan@kernel.org>
---
drivers/net/can/softing/softing_cs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/can/softing/softing_cs.c b/drivers/net/can/softing/softing_cs.c
index 2e93ee792373..e5c939b63fa6 100644
--- a/drivers/net/can/softing/softing_cs.c
+++ b/drivers/net/can/softing/softing_cs.c
@@ -293,7 +293,7 @@ static int softingcs_probe(struct pcmcia_device *pcmcia)
return 0;
platform_failed:
- kfree(dev);
+ platform_device_put(pdev);
mem_failed:
pcmcia_bad:
pcmcia_failed:
--
2.32.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] can: softing_cs: fix memleak on registration failure
2021-12-22 10:48 [PATCH] can: softing_cs: fix memleak on registration failure Johan Hovold
@ 2021-12-22 11:05 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2021-12-22 11:05 UTC (permalink / raw)
To: Johan Hovold
Cc: Wolfgang Grandegger, Marc Kleine-Budde, David S. Miller,
Jakub Kicinski, linux-can, netdev, linux-kernel, stable
On Wed, Dec 22, 2021 at 11:48:43AM +0100, Johan Hovold wrote:
> In case device registration fails during probe, the driver state and the
> embedded platform device structure needs to be freed using
> platform_device_put() to properly free all resources (e.g. the device
> name).
>
> Fixes: 0a0b7a5f7a04 ("can: add driver for Softing card")
> Cc: stable@vger.kernel.org # 2.6.38
> Signed-off-by: Johan Hovold <johan@kernel.org>
> ---
> drivers/net/can/softing/softing_cs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/can/softing/softing_cs.c b/drivers/net/can/softing/softing_cs.c
> index 2e93ee792373..e5c939b63fa6 100644
> --- a/drivers/net/can/softing/softing_cs.c
> +++ b/drivers/net/can/softing/softing_cs.c
> @@ -293,7 +293,7 @@ static int softingcs_probe(struct pcmcia_device *pcmcia)
> return 0;
>
> platform_failed:
> - kfree(dev);
> + platform_device_put(pdev);
> mem_failed:
> pcmcia_bad:
> pcmcia_failed:
> --
> 2.32.0
>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-22 11:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-22 10:48 [PATCH] can: softing_cs: fix memleak on registration failure Johan Hovold
2021-12-22 11:05 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox