From: Borislav Petkov <bp@alien8.de>
To: Kuniyuki Iwashima <kuniyu@amazon.co.jp>
Cc: dave.hansen@intel.com, benh@amazon.com,
dave.hansen@linux.intel.com, kuni1840@gmail.com,
linux-kernel@vger.kernel.org, mingo@redhat.com,
tglx@linutronix.de, x86@kernel.org
Subject: Re: [PATCH] x86/boot: Avoid redundant address overlap tests in memcpy().
Date: Mon, 24 Jan 2022 23:48:17 +0100 [thread overview]
Message-ID: <Ye8ssRJEpau57jKj@zn.tnic> (raw)
In-Reply-To: <20220124221447.1030-1-kuniyu@amazon.co.jp>
On Tue, Jan 25, 2022 at 07:14:47AM +0900, Kuniyuki Iwashima wrote:
> > Also, is this worth the churn? It probably saves less than 10
> > instructions, all of which are ridiculously cheap. Is there a *reason*
> > for this other than being a pure cleanup?
>
> This is just for cleanup.
Was wondering the same thing, whether this is even worth the trouble.
I'm sure you can find real bugs to fix.
:-)
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
prev parent reply other threads:[~2022-01-24 23:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-23 1:58 [PATCH] x86/boot: Avoid redundant address overlap tests in memcpy() Kuniyuki Iwashima
2022-01-24 17:38 ` Dave Hansen
2022-01-24 22:14 ` Kuniyuki Iwashima
2022-01-24 22:48 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ye8ssRJEpau57jKj@zn.tnic \
--to=bp@alien8.de \
--cc=benh@amazon.com \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=kuni1840@gmail.com \
--cc=kuniyu@amazon.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox