From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Rodolfo Giometti <giometti@enneenne.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/1] pps: generators: pps_gen_parport: Switch to use module_parport_driver()
Date: Mon, 7 Feb 2022 16:54:25 +0200 [thread overview]
Message-ID: <YgEyoemcpsvC3bcI@smile.fi.intel.com> (raw)
In-Reply-To: <YgEtpvGHId1xKSDY@kroah.com>
On Mon, Feb 07, 2022 at 03:33:10PM +0100, Greg Kroah-Hartman wrote:
> On Mon, Feb 07, 2022 at 04:19:44PM +0200, Andy Shevchenko wrote:
> > Switch to use module_parport_driver() to reduce boilerplate code.
> You changed the functionality here :(
>
> Currently if send_delay is too big, loading the module will fail.
>
> Now it succeeds but binding to a device fails, that's a functional
> change. Are you _SURE_ that is ok to do?
We already discussed that during v1 IIRC. And I told that it might even gain
additional flexibility for built-in case of the module.
> And why did you not mention any of this in the changelog text? You
> passed this off as a mere code cleanup, no functional change :(
This is fair point. Since we end up in the same Q above. I will update
changelog in v5.
Thank you for review!
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2022-02-07 15:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-07 14:19 [PATCH v4 1/1] pps: generators: pps_gen_parport: Switch to use module_parport_driver() Andy Shevchenko
2022-02-07 14:33 ` Greg Kroah-Hartman
2022-02-07 14:54 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgEyoemcpsvC3bcI@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=giometti@enneenne.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox