* Re: [PATCH] staging: rtl8723bs: fix indentation
2022-04-05 14:54 [PATCH] staging: rtl8723bs: fix indentation Sevinj Aghayeva
@ 2022-04-05 15:02 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2022-04-05 15:02 UTC (permalink / raw)
To: Sevinj Aghayeva; +Cc: linux-staging, linux-kernel, outreachy
On Tue, Apr 05, 2022 at 10:54:24AM -0400, Sevinj Aghayeva wrote:
> Adhere to Linux kernel coding style.
>
> Reported by checkpatch:
>
> WARNING: suspect code indent for conditional statements
>
> Signed-off-by: Sevinj Aghayeva <sevinj.aghayeva@gmail.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 14 +++-----------
> 1 file changed, 3 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> index 04e29e228c1e..1bdbd0971f73 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> @@ -5143,17 +5143,9 @@ void link_timer_hdl(struct timer_list *t)
> } else if (pmlmeinfo->state & WIFI_FW_AUTH_STATE) {
> /* re-auth timer */
> if (++pmlmeinfo->reauth_count > REAUTH_LIMIT) {
> - /* if (pmlmeinfo->auth_algo != dot11AuthAlgrthm_Auto) */
> - /* */
> - pmlmeinfo->state = 0;
> - report_join_res(padapter, -1);
> - return;
> - /* */
> - /* else */
> - /* */
> - /* pmlmeinfo->auth_algo = dot11AuthAlgrthm_Shared; */
> - /* pmlmeinfo->reauth_count = 0; */
> - /* */
> + pmlmeinfo->state = 0;
> + report_join_res(padapter, -1);
> + return;
> }
>
> pmlmeinfo->auth_seq = 1;
> --
> 2.25.1
>
>
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.
You are receiving this message because of the following common error(s)
as indicated below:
- You did not specify a description of why the patch is needed, or
possibly, any description at all, in the email body. Please read the
section entitled "The canonical patch format" in the kernel file,
Documentation/SubmittingPatches for what is needed in order to
properly describe the change.
- You did not write a descriptive Subject: for the patch, allowing Greg,
and everyone else, to know what this patch is all about. Please read
the section entitled "The canonical patch format" in the kernel file,
Documentation/SubmittingPatches for what a proper Subject: line should
look like.
- This looks like a new version of a previously submitted patch, but you
did not list below the --- line any changes from the previous version.
Please read the section entitled "The canonical patch format" in the
kernel file, Documentation/SubmittingPatches for what needs to be done
here to properly describe this.
If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.
thanks,
greg k-h's patch email bot
^ permalink raw reply [flat|nested] 2+ messages in thread