From: Uladzislau Rezki <urezki@gmail.com>
To: Joel Fernandes <joel@joelfernandes.org>
Cc: linux-kernel@vger.kernel.org,
Josh Triplett <josh@joshtriplett.org>,
Lai Jiangshan <jiangshanlai@gmail.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
"Paul E. McKenney" <paulmck@kernel.org>,
rcu@vger.kernel.org, Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH RFC] rcu/nocb: Provide default all-CPUs mask for RCU_NOCB_CPU=y
Date: Mon, 11 Apr 2022 15:49:06 +0200 [thread overview]
Message-ID: <YlQx0rZzrdWIA5w+@pc638.lan> (raw)
In-Reply-To: <20220407210734.2548973-1-joel@joelfernandes.org>
Hello, Joel.
> On systems with CONFIG_RCU_NOCB_CPU=y, there is no default mask provided
> which ends up not offloading any CPU. This patch removes yet another
> dependency from the bootloader having to know about RCU, about how many
> CPUs the system has, and about how to provide the mask. Basically, I
> think we should stop pretending that the user knows what they are doing :).
> In other words, if NO_CB_CPU is enabled, lets make use of it.
>
Could you also please modify the documentation accordingly and send v2?
<snip>
urezki@pc638:~/data/raid0/coding/linux-rcu.git$ grep -rn RCU_NOCB_CPU ./Documentation/
./Documentation/timers/no_hz.rst:188:using the CONFIG_RCU_NOCB_CPU=y Kconfig option. The specific CPUs to
./Documentation/admin-guide/kernel-parameters.txt:4380: In kernels built with CONFIG_RCU_NOCB_CPU=y,
./Documentation/admin-guide/kernel-parameters.txt:4507: When RCU_NOCB_CPU is set, also adjust the
./Documentation/admin-guide/kernel-per-CPU-kthreads.rst:311:3. Build with CONFIG_RCU_NOCB_CPU=y and boot with the rcu_nocbs=
./Documentation/admin-guide/kernel-per-CPU-kthreads.rst:331:2. Build with CONFIG_RCU_NOCB_CPU=n, which will prevent these
./Documentation/RCU/Design/Requirements/Requirements.rst:1424:``CONFIG_RCU_NOCB_CPU=y`` and booted with ``rcu_nocbs=1-63``, where
urezki@pc638:~/data/raid0/coding/linux-rcu.git$ grep -rn RCU_NOCB_CPU ./kernel/rcu/
...
./kernel/rcu/Kconfig:198:config RCU_NOCB_CPU
..
<snip>
--
Uladzislau Rezki
next prev parent reply other threads:[~2022-04-11 13:49 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-07 21:07 [PATCH RFC] rcu/nocb: Provide default all-CPUs mask for RCU_NOCB_CPU=y Joel Fernandes
2022-04-08 14:22 ` Paul E. McKenney
2022-04-08 14:52 ` Joel Fernandes
2022-04-08 15:50 ` Paul E. McKenney
2022-04-08 17:20 ` Joel Fernandes
2022-04-08 17:49 ` Paul E. McKenney
2022-04-08 18:22 ` Joel Fernandes
2022-04-08 18:23 ` Joel Fernandes
2022-04-08 20:54 ` Paul E. McKenney
2022-04-08 21:46 ` Uladzislau Rezki
2022-04-11 14:08 ` Paul E. McKenney
2022-04-11 15:20 ` Uladzislau Rezki
2022-04-11 15:17 ` Joel Fernandes
2022-04-11 15:41 ` Paul E. McKenney
2022-04-14 19:19 ` Joel Fernandes
2022-04-14 19:42 ` Paul E. McKenney
2022-04-14 19:49 ` Joel Fernandes
2022-04-14 19:51 ` Joel Fernandes
2022-04-14 21:10 ` Paul E. McKenney
2022-04-14 21:09 ` Paul E. McKenney
2022-04-14 21:14 ` Joel Fernandes
2022-04-14 21:31 ` Paul E. McKenney
2022-04-14 21:38 ` Joel Fernandes
2022-04-14 22:37 ` Paul E. McKenney
2022-04-20 20:36 ` Steven Rostedt
2022-04-11 13:49 ` Uladzislau Rezki [this message]
2022-04-11 15:17 ` Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YlQx0rZzrdWIA5w+@pc638.lan \
--to=urezki@gmail.com \
--cc=jiangshanlai@gmail.com \
--cc=joel@joelfernandes.org \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=paulmck@kernel.org \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox